* Can thread gathering use In-Reply-To: <message-id>?
@ 2002-05-15 17:05 Tom Koelman
2002-05-15 18:53 ` Jesper Harder
0 siblings, 1 reply; 8+ messages in thread
From: Tom Koelman @ 2002-05-15 17:05 UTC (permalink / raw)
Just now I saw the thread called "Gathering very loose threads", in
which the original post and the reply to it were not gathered. I have
gnus-summary-thread-gathering-function set to
gnus-gather-threads-by-references. On inspection of the reply I
noticed that it didn't have its References header set, but did have a
header called In-Reply_To: with the correct message-id.
Is there some way to make gnus use this information?
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-15 17:05 Can thread gathering use In-Reply-To: <message-id>? Tom Koelman
@ 2002-05-15 18:53 ` Jesper Harder
2002-05-15 20:14 ` Tom Koelman
0 siblings, 1 reply; 8+ messages in thread
From: Jesper Harder @ 2002-05-15 18:53 UTC (permalink / raw)
tkoelman@xs4all.nl (Tom Koelman) writes:
> On inspection of the reply I noticed that it didn't have its
> References header set, but did have a header called In-Reply_To: with
> the correct message-id.
>
> Is there some way to make gnus use this information?
Hmm, I would have thought Gnus already does it. This piece of code from
`gnus-nov-parse-line' seems to do exactly that:
(when (and (string= references "")
(setq in-reply-to (mail-header-extra header))
(setq in-reply-to (cdr (assq 'In-Reply-To in-reply-to))))
(mail-header-set-references
header (gnus-extract-message-id-from-in-reply-to in-reply-to)))
You could try do edebug `gnus-nov-parse-line' to find out, if it really
works.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-15 18:53 ` Jesper Harder
@ 2002-05-15 20:14 ` Tom Koelman
2002-05-15 21:25 ` Andras BALI
2002-05-19 1:38 ` Jesper Harder
0 siblings, 2 replies; 8+ messages in thread
From: Tom Koelman @ 2002-05-15 20:14 UTC (permalink / raw)
Jesper Harder wrote:
> tkoelman@xs4all.nl (Tom Koelman) writes:
>
>> On inspection of the reply I noticed that it didn't have its
>> References header set, but did have a header called In-Reply_To: with
>> the correct message-id.
>>
>> Is there some way to make gnus use this information?
>
> Hmm, I would have thought Gnus already does it.
You are right, thanks.
I had set gnus-summary-thread-gathering-function to
gnus-gather-threads-by-references. When I turned that off the thread
was gathered nicely. I am a bit surprised that the default thread
gathering behaviour is something different than one of the two values
I can set that variable to. Maybe this is a documentation bug?
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-15 20:14 ` Tom Koelman
@ 2002-05-15 21:25 ` Andras BALI
2002-05-16 7:01 ` Tom Koelman
2002-05-19 1:38 ` Jesper Harder
1 sibling, 1 reply; 8+ messages in thread
From: Andras BALI @ 2002-05-15 21:25 UTC (permalink / raw)
On 15 May 2002, Tom Koelman wrote:
>>> On inspection of the reply I noticed that it didn't have its
>>> References header set, but did have a header called In-Reply_To: with
>>> the correct message-id.
>>> Is there some way to make gnus use this information?
>> Hmm, I would have thought Gnus already does it.
> You are right, thanks.
> I had set gnus-summary-thread-gathering-function to
> gnus-gather-threads-by-references. When I turned that off the thread
> was gathered nicely.
Actually the default value of gnus-summary-thread-gathering-function
is gnus-gather-threads-by-subject. No matter what I set g-s-t-g-f to,
my Gnus doesn't seem to use the In-Reply-To fields.
Eg. there was a message on a mailing list (by Joe Foo), and there was
a reply (by Joe Bar) which had the same subject (except for the Re:
prefix) and only an In-Reply-To field. Gnus displayed this thread of
two messages the following way (yes, I have gnus-make-false-root set
to 'dummy):
subject
R [ 546: Joe Foo 4] +->
R [ 717: Joe Bar 4] `->
Which is just wrong. What could cause this behaviour?
Thanks,
--
BALI, Andra's GPG KeyID: 78560E1C
drewie@bigfoot.com, bali@debian.org http://drewie.hup.hu
Debian GNU/Linux. The Universal Operating System. http://www.debian.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-15 21:25 ` Andras BALI
@ 2002-05-16 7:01 ` Tom Koelman
0 siblings, 0 replies; 8+ messages in thread
From: Tom Koelman @ 2002-05-16 7:01 UTC (permalink / raw)
Andras BALI wrote:
> Actually the default value of gnus-summary-thread-gathering-function
> is gnus-gather-threads-by-subject. No matter what I set g-s-t-g-f to,
> my Gnus doesn't seem to use the In-Reply-To fields.
I can't reproduce that, Andras. Whether I set g-s-t-g-f to
g-g-t-b-s explicitly or don't touch it at all (which indeed is
g-g-t-b-s as well), gathering on In-Reply-To works nicely. It is only
when I set g-s-t-g-f to gather by references that it seems to ignore
the In-Reply-To header.
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-15 20:14 ` Tom Koelman
2002-05-15 21:25 ` Andras BALI
@ 2002-05-19 1:38 ` Jesper Harder
2002-05-20 14:24 ` Tom Koelman
1 sibling, 1 reply; 8+ messages in thread
From: Jesper Harder @ 2002-05-19 1:38 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
tkoelman@xs4all.nl (Tom Koelman) writes:
> Jesper Harder wrote:
>
>> tkoelman@xs4all.nl (Tom Koelman) writes:
>>
>>> On inspection of the reply I noticed that it didn't have its
>>> References header set, but did have a header called In-Reply_To:
>>> with the correct message-id.
>>>
>>> Is there some way to make gnus use this information?
>>
>> Hmm, I would have thought Gnus already does it.
>
> You are right, thanks.
> I had set gnus-summary-thread-gathering-function to
> gnus-gather-threads-by-references. When I turned that off the thread
> was gathered nicely.
Hmm, I think this patch should make work with
gnus-gather-threads-by-references, too:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-sum.el.patch --]
[-- Type: text/x-patch, Size: 708 bytes --]
--- /home/harder/gnus/lisp/gnus-sum.el Fri May 17 02:03:24 2002
+++ gnus-sum.el Sun May 19 02:49:51 2002
@@ -3525,7 +3525,14 @@
(result threads)
ids references id gthread gid entered ref)
(while threads
- (when (setq references (mail-header-references (caar threads)))
+ (when (or
+ (not (string= "" (setq references
+ (mail-header-references (caar threads)))))
+ (and
+ (setq references
+ (cdr (assq 'In-Reply-To (mail-header-extra (caar threads)))))
+ (setq references
+ (gnus-extract-message-id-from-in-reply-to references))))
(setq id (mail-header-id (caar threads))
ids (inline (gnus-split-references references))
entered nil)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-19 1:38 ` Jesper Harder
@ 2002-05-20 14:24 ` Tom Koelman
2002-05-26 18:07 ` Jesper Harder
0 siblings, 1 reply; 8+ messages in thread
From: Tom Koelman @ 2002-05-20 14:24 UTC (permalink / raw)
Jesper Harder wrote:
> tkoelman@xs4all.nl (Tom Koelman) writes:
>
>> Jesper Harder wrote:
>>
>>> tkoelman@xs4all.nl (Tom Koelman) writes:
>>>
>>>> On inspection of the reply I noticed that it didn't have its
>>>> References header set, but did have a header called In-Reply_To:
>>>> with the correct message-id.
>>>>
>>>> Is there some way to make gnus use this information?
>>>
>>> Hmm, I would have thought Gnus already does it.
>>
>> You are right, thanks.
>> I had set gnus-summary-thread-gathering-function to
>> gnus-gather-threads-by-references. When I turned that off the thread
>> was gathered nicely.
>
> Hmm, I think this patch should make work with
> gnus-gather-threads-by-references, too:
[patch snipped]
Jesper, I applied your patch to gnus-sum.el. I use Oort 0.06 btw. In
.gnus I set gnus-summary-thread-gathering-function to
gnus-gather-threads-by-reference.
Now when I enter gnus.ding on quimby and look at articles
<Pine.LNX.4.44.0205151452570.4915-100000@yxa.extundo.com> and
<uk7q53f3s.fsf@axis.com>, they show up in my summary buffer like this:
! [ 31: Niklas Morberg ] Gathering very loose threads
! [ 40: Simon Josefsson ] Re: Gathering very loose threads
while the second one has In-Reply-To: <uk7q53f3s.fsf@axis.com>. Does
this mean I didn't apply you patch correctly or is my understanding of
thread gathering incorrect?
Regards,
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Can thread gathering use In-Reply-To: <message-id>?
2002-05-20 14:24 ` Tom Koelman
@ 2002-05-26 18:07 ` Jesper Harder
0 siblings, 0 replies; 8+ messages in thread
From: Jesper Harder @ 2002-05-26 18:07 UTC (permalink / raw)
tkoelman@xs4all.nl (Tom Koelman) writes:
> Jesper, I applied your patch to gnus-sum.el. I use Oort 0.06 btw. In
> .gnus I set gnus-summary-thread-gathering-function to
> gnus-gather-threads-by-reference.
>
> Now when I enter gnus.ding on quimby and look at articles
> <Pine.LNX.4.44.0205151452570.4915-100000@yxa.extundo.com> and
> <uk7q53f3s.fsf@axis.com>, they show up in my summary buffer like this:
>
> ! [ 31: Niklas Morberg ] Gathering very loose threads
> ! [ 40: Simon Josefsson ] Re: Gathering very loose threads
>
> while the second one has In-Reply-To: <uk7q53f3s.fsf@axis.com>.
Strange. What I'm seeing with a 'clean' Gnus with basically no
customizations except:
(setq gnus-summary-thread-gathering-function
'gnus-gather-threads-by-reference)
is this:
! [ 56: Niklas Morberg ] Gathering very loose threads
! [ 65: Simon Josefsson ]
And if I display non-ticked old messages, this:
! [ 56: Niklas Morberg ] Gathering very loose threads
O [ 79: Bill White ] odd nnir error
O [ 53: Kai Großjohann ]
! [ 65: Simon Josefsson ] Re: Gathering very loose threads
O [ 39: Niklas Morberg ]
> Does this mean I didn't apply you patch correctly or is my
> understanding of thread gathering incorrect?
I played with it a bit more, and the patch doesn't seem to do anything
useful after all.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2002-05-26 18:07 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-15 17:05 Can thread gathering use In-Reply-To: <message-id>? Tom Koelman
2002-05-15 18:53 ` Jesper Harder
2002-05-15 20:14 ` Tom Koelman
2002-05-15 21:25 ` Andras BALI
2002-05-16 7:01 ` Tom Koelman
2002-05-19 1:38 ` Jesper Harder
2002-05-20 14:24 ` Tom Koelman
2002-05-26 18:07 ` Jesper Harder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).