Gnus development mailing list
 help / color / mirror / Atom feed
* APOP auth support in mail-source.el
@ 1999-02-02  2:22 Tatsuya Ichikawa
  1999-02-02 13:13 ` Tatsuya Ichikawa
  0 siblings, 1 reply; 6+ messages in thread
From: Tatsuya Ichikawa @ 1999-02-02  2:22 UTC (permalink / raw)
  Cc: ichikawa

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]


  From Pterodactyl Gnus v0.73 , mail-source.el does not support APOP
  authentication scheme , but pop3.el support APOP authentication
  scheme.

  I create patch to support APOP auth in mail-source.el.


[-- Attachment #2: mail-source.el.diff --]
[-- Type: application/octet-stream, Size: 2393 bytes --]

*** mail-source.el.orig	Tue Feb 02 10:17:14 1999
--- mail-source.el	Tue Feb 02 11:04:24 1999
***************
*** 74,79 ****
--- 74,84 ----
         (:args)
         (:function)
         (:password))
+       (apop
+        (:server (getenv "MAILHOST"))
+        (:port "pop3")
+        (:user (or (user-login-name) (getenv "LOGNAME") (getenv "USER")))
+        (:password))
        (maildir
         (:path)))
      "Mapping from keywords to default values.
***************
*** 83,88 ****
--- 88,94 ----
    '((file mail-source-fetch-file)
      (directory mail-source-fetch-directory)
      (pop mail-source-fetch-pop)
+     (apop mail-source-fetch-apop)
      (qmail mail-source-fetch-qmail))
    "A mapping from source type to fetcher function.")
  
***************
*** 332,338 ****
  	   (t
  	    (let ((pop3-password password)
  		  (pop3-maildrop user)
! 		  (pop3-mailhost server))
  	      (save-excursion (pop3-movemail mail-source-crash-box)))))
  	  (mail-source-callback callback server)
  	;; We nix out the password in case the error
--- 338,370 ----
  	   (t
  	    (let ((pop3-password password)
  		  (pop3-maildrop user)
! 		  (pop3-mailhost server)
! 		  (pop3-authentication-scheme 'pass))
! 	      (save-excursion (pop3-movemail mail-source-crash-box)))))
! 	  (mail-source-callback callback server)
! 	;; We nix out the password in case the error
! 	;; was because of a wrong password being given.
! 	(setq mail-source-password-cache
! 	      (delq (assoc from mail-source-password-cache)
! 		    mail-source-password-cache))
! 	0))))
! 
! (defun mail-source-fetch-apop (source callback)
!   "Fetcher for single-file sources."
!   (mail-source-bind (pop source)
!     (let ((from (format "%s:%s:%s" server user port))
! 	  (mail-source-string (format "apop:%s@%s" user server)))
!       (setq password
! 	    (or password
! 		(cdr (assoc from mail-source-password-cache))
! 		(mail-source-read-passwd
! 		 (format "Password for %s at %s: " user server))))
!       (unless (assoc from mail-source-password-cache)
! 	(push (cons from password) mail-source-password-cache))
!       (let ((pop3-password password)
! 	    (pop3-maildrop user)
! 	    (pop3-mailhost server)
! 	    (pop3-authentication-scheme 'apop))
  	      (save-excursion (pop3-movemail mail-source-crash-box)))))
  	  (mail-source-callback callback server)
  	;; We nix out the password in case the error


[-- Attachment #3: Type: text/plain, Size: 52 bytes --]


-- 
  Tatsuya Ichikawa <t-ichi@po.shiojiri.ne.jp>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: APOP auth support in mail-source.el
  1999-02-02  2:22 APOP auth support in mail-source.el Tatsuya Ichikawa
@ 1999-02-02 13:13 ` Tatsuya Ichikawa
  1999-02-02 21:04   ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Tatsuya Ichikawa @ 1999-02-02 13:13 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

>>>>> In <u7lu17dek.fsf@hv08.hv.epson.co.jp>
>>>>> Tatsuya Ichikawa <t-ichi@po.shiojiri.ne.jp> wrote:
>   From Pterodactyl Gnus v0.73 , mail-source.el does not support APOP
>   authentication scheme , but pop3.el support APOP authentication
>   scheme.
>   I create patch to support APOP auth in mail-source.el.

  Here is better patch to support APOP with mail-source.el.
  So please apply this patch.

1999-02-01  Tatsuya Ichikawa <t-ichi@po.shiojiri.ne.jp>

	* lisp/mail-source.el : Support APOP authentication scheme.


[-- Attachment #2: mail-source.el.patch --]
[-- Type: application/octet-stream, Size: 2090 bytes --]

*** mail-source.el.orig	Tue Feb 02 22:09:24 1999
--- mail-source.el	Tue Feb 02 22:07:52 1999
***************
*** 74,79 ****
--- 74,87 ----
         (:args)
         (:function)
         (:password))
+       (apop
+        (:server (getenv "MAILHOST"))
+        (:port "pop3")
+        (:user (or (user-login-name) (getenv "LOGNAME") (getenv "USER")))
+        (:program)
+        (:args)
+        (:function)
+        (:password))
        (maildir
         (:path)))
      "Mapping from keywords to default values.
***************
*** 83,88 ****
--- 91,97 ----
    '((file mail-source-fetch-file)
      (directory mail-source-fetch-directory)
      (pop mail-source-fetch-pop)
+     (apop mail-source-fetch-pop)
      (qmail mail-source-fetch-qmail))
    "A mapping from source type to fetcher function.")
  
***************
*** 310,316 ****
    "Fetcher for single-file sources."
    (mail-source-bind (pop source)
      (let ((from (format "%s:%s:%s" server user port))
! 	  (mail-source-string (format "pop:%s@%s" user server)))
        (setq password
  	    (or password
  		(cdr (assoc from mail-source-password-cache))
--- 319,325 ----
    "Fetcher for single-file sources."
    (mail-source-bind (pop source)
      (let ((from (format "%s:%s:%s" server user port))
! 	  (mail-source-string (format "%s:%s@%s" (car source) user server)))
        (setq password
  	    (or password
  		(cdr (assoc from mail-source-password-cache))
***************
*** 332,338 ****
  	   (t
  	    (let ((pop3-password password)
  		  (pop3-maildrop user)
! 		  (pop3-mailhost server))
  	      (save-excursion (pop3-movemail mail-source-crash-box)))))
  	  (mail-source-callback callback server)
  	;; We nix out the password in case the error
--- 341,348 ----
  	   (t
  	    (let ((pop3-password password)
  		  (pop3-maildrop user)
! 		  (pop3-mailhost server)
! 		  (pop3-authentication-scheme (if (eq 'apop (car source)) 'apop 'pass)))
  	      (save-excursion (pop3-movemail mail-source-crash-box)))))
  	  (mail-source-callback callback server)
  	;; We nix out the password in case the error


[-- Attachment #3: Type: text/plain, Size: 201 bytes --]


-- 
Tatsuya Ichikawa   : Shiojiri Internet... <t-ichi@po.shiojiri.ne.jp>
# PGP Public Key   : See X-Info Header of this message. ;-p
# Meadow's Page    : http://www.shiojiri.ne.jp/~t-ichi/meadow.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: APOP auth support in mail-source.el
  1999-02-02 13:13 ` Tatsuya Ichikawa
@ 1999-02-02 21:04   ` Lars Magne Ingebrigtsen
  1999-02-03  1:00     ` Tatsuya Ichikawa
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-02-02 21:04 UTC (permalink / raw)


Tatsuya Ichikawa <t-ichi@niagara.shiojiri.ne.jp> writes:

>   Here is better patch to support APOP with mail-source.el.

I've applied your patch, but then I removed most of it again and added 
an :authentication keyword to the pop fetcher instead which can be
either `password' or `apop'.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: APOP auth support in mail-source.el
  1999-02-02 21:04   ` Lars Magne Ingebrigtsen
@ 1999-02-03  1:00     ` Tatsuya Ichikawa
  1999-02-03  1:31       ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Tatsuya Ichikawa @ 1999-02-03  1:00 UTC (permalink / raw)
  Cc: ding

>>>>> In <m3btjcy0tw.fsf@quimbies.gnus.org>
>>>>>  Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
Lars> I've applied your patch, but then I removed most of it again and
Lars> added an :authentication keyword to the pop fetcher instead which
Lars> can be either `password' or `apop'.

  Thanks.
  But I post patch again in

  Message-Id: <199902021319.WAA26855@niagara.shiojiri.ne.jp>

  Did you read it??

-- 
  Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: APOP auth support in mail-source.el
  1999-02-03  1:00     ` Tatsuya Ichikawa
@ 1999-02-03  1:31       ` Lars Magne Ingebrigtsen
  1999-02-03  1:49         ` Tatsuya Ichikawa
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-02-03  1:31 UTC (permalink / raw)


Tatsuya Ichikawa <ichikawa@hv.epson.co.jp> writes:

>   But I post patch again in
> 
>   Message-Id: <199902021319.WAA26855@niagara.shiojiri.ne.jp>
> 
>   Did you read it??

Yes -- that's the patch I applied and then unapplied. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: APOP auth support in mail-source.el
  1999-02-03  1:31       ` Lars Magne Ingebrigtsen
@ 1999-02-03  1:49         ` Tatsuya Ichikawa
  0 siblings, 0 replies; 6+ messages in thread
From: Tatsuya Ichikawa @ 1999-02-03  1:49 UTC (permalink / raw)
  Cc: ding

>>>>> In <m3vhhkuvc6.fsf@quimbies.gnus.org>
>>>>>  Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
Lars> >   But I post patch again in
Lars> >   Message-Id: <199902021319.WAA26855@niagara.shiojiri.ne.jp>
Lars> >   Did you read it??
Lars> Yes -- that's the patch I applied and then unapplied.

  All right. Isee.

-- 
  Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~1999-02-03  1:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-02-02  2:22 APOP auth support in mail-source.el Tatsuya Ichikawa
1999-02-02 13:13 ` Tatsuya Ichikawa
1999-02-02 21:04   ` Lars Magne Ingebrigtsen
1999-02-03  1:00     ` Tatsuya Ichikawa
1999-02-03  1:31       ` Lars Magne Ingebrigtsen
1999-02-03  1:49         ` Tatsuya Ichikawa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).