Re: patch for "POP SSL connexion failed"

[rahed <raherh@gmail.com>]

Denys Duchier <denys.duchier@univ-orleans.fr> writes:

> up'ed.  Here is a fix that seems to work well for me:
>
> cvs server: Diffing .
> Index: pop3.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/pop3.el,v
> retrieving revision 7.26
> diff -u -r7.26 pop3.el
> --- pop3.el	4 Oct 2007 18:51:28 -0000	7.26
> +++ pop3.el	13 Nov 2007 20:35:35 -0000
> @@ -241,16 +241,20 @@
>  					      mailhost port)))
>  		(when process
>  		  ;; There's a load of info printed that needs deleting.
> -		  (while (when (memq (process-status process) '(open run))
> -			   (pop3-accept-process-output process)
> -			   (goto-char (point-max))
> -			   (forward-line -1)
> -			   (if (looking-at "\\+OK")
> -			       (progn
> -				 (delete-region (point-min) (point))
> -				 nil)
> -			     (pop3-quit process)
> -			     (error "POP SSL connexion failed"))))
> +		  (let ((again 't))
> +		    ;; repeat until
> +		    ;; - either we received the +OK line
> +		    ;; - or accept-process-output timed out without getting anything
> +		    (while (and again (setq again (memq (process-status process) '(open run))))
> +		      (setq again (pop3-accept-process-output process))
> +		      (goto-char (point-max))
> +		      (forward-line -1)
> +		      (cond ((looking-at "\\+OK")
> +			     (setq again nil)
> +			     (delete-region (point-min) (point)))
> +			    ((not again)
> +			     (pop3-quit-process)
> +			     (error "POP SSL connexion failed")))))
>  		  process)))
>  	     ((eq pop3-stream-type 'starttls)
>  	      ;; gnutls-cli, openssl don't accept service names

Shouldn't the line
> +			     (pop3-quit-process)

read
> +			     (pop3-quit process)
?

When I start gnus with this patch it freezes with a message in the
minibuffer:

Opening TLS connection to 'pop.gmail.com'...done

and a trace of POP session to pop.gmail.com buffer has a line
+OK Gpop ready for requests from ...

Apparently it waits for user/passwd.
Could someone elaborate?

-- 
Radek