Re: Overbearing undownloaded face

[Kevin Greiner <kgreiner@xpediantsolutions.com>]

Simon Josefsson <jas@extundo.com> writes:

> Harry Putnam <hgp@sbcglobal.net> writes:
>
>> I've recently come back to using the agent after several mnths of
>> running plugged only.  The current setup with undownloaded face seems
>> to overpower other long standing faces and options.
>
> Yup.  I've been using this, perhaps the defaults should be changed?
> Currently undownloadable marks is more important than, say, tick
> marks, which doesn't seem right to me.  And I was used to the black
> marks on unread messages.
>
> I sent a message asking for opinions about this a few months ago, but
> now that I try to find my message, I note that it contained a screen
> shot so it was probably rejected due to size.  So:  Opinions?
>
> --- gnus-sum.el.~6.342.~	Tue Apr 29 02:44:20 2003
> +++ gnus-sum.el	Fri May  2 14:16:54 2003
> @@ -902,12 +902,6 @@
>  (defcustom gnus-summary-highlight
>    '(((eq mark gnus-canceled-mark)
>       . gnus-summary-cancelled-face)
> -    ((and uncached (> score default-high))
> -     . gnus-summary-high-undownloaded-face)
> -    ((and uncached (< score default-low))
> -     . gnus-summary-low-undownloaded-face)
> -    (uncached
> -     . gnus-summary-normal-undownloaded-face)
>      ((and (> score default-high)
>  	  (or (eq mark gnus-dormant-mark)
>  	      (eq mark gnus-ticked-mark)))
> @@ -935,6 +929,12 @@
>       . gnus-summary-high-read-face)
>      ((< score default-low)
>       . gnus-summary-low-read-face)
> +    ((and uncached (> score default-high))
> +     . gnus-summary-high-undownloaded-face)
> +    ((and uncached (< score default-low))
> +     . gnus-summary-low-undownloaded-face)
> +    (uncached
> +     . gnus-summary-normal-undownloaded-face)
>      (t
>       . gnus-summary-normal-read-face))
>    "*Controls the highlighting of summary buffer lines.

I realize that this will come as a surprise but this is exactly how I
initially added the undownloaded faces to gnus-summary-highlight.  The
only problem is that it simply doesn't work.  The
gnus-summary-(high/low)-undownloaded-face never appear as the
preceeding default-(low/high) rules override them.  The undownloaded
normal face does appear but only on articles that have absolutely no
marks.  So if you tick several articles because they appear
interesting, you loose the warning that those articles are unavailable
while offline.

After several days of frustration, I ended up with the undownloaded
faces at the beginning of the list.

The patch that I would consider is to change the (and uncached (...))
tests to (and uncached gnus-agent-use-undownloaded-faces (...)).  Of
course, I'd like to default gnus-agent-use-undownloaded-faces to t
but that would still be objectable to some.

Kevin