cvs keyword hacking in texi/Makefile.in

cvs keyword hacking in texi/Makefile.in

[Miles Bader]

This little bit appears in (my checkout of) texi/Makefile.in:

   gnus-faq.texi: gnus-faq.xml
           ./xml2texi.sh $< $@.tmp
           @echo
   # FIXME: This should be done in xml2texi.scm or gnus-faq.xml should be
   # changed:
           sed '/\$$Id: Makefile.in,v 7.12 2005/03/24 09:14:37 miles Exp $$/d' < $@.tmp > $@

Besides the more general question of whether CVS keywords should be
used at all, this probably doesn't do what someone thought it does
-- it replaces the expansion of $Id$ for `Makefile.in' in the text
of `gnus-faq.xml'?!?  That's surely a nop...?

-Miles
-- 
/\ /\
(^.^)
(")")
*This is the cute kitty virus, please copy this into your sig so it can spread.

Re: cvs keyword hacking in texi/Makefile.in

[Reiner Steib]

On Thu, Mar 24 2005, Miles Bader wrote:

>    # FIXME: This should be done in xml2texi.scm or gnus-faq.xml should be
>    # changed:
>            sed '/\$$Id: Makefile.in,v 7.12 2005/03/24 09:14:37 miles Exp $$/d' < $@.tmp > $@
>
> Besides the more general question of whether CVS keywords should be
> used at all, this probably doesn't do what someone thought it does
> -- it replaces the expansion of $Id$ for `Makefile.in' in the text
> of `gnus-faq.xml'?!?  That's surely a nop...?

Oops, it was supposed to remove the gnus-faq.xml-Id when creating
gnus-faq.texi.  Of course it worked fine, until I committed it.  :-/

Unless Frank or Karl come up with a better idea (see the Makefile
comment above), I will probably the CVS keyword from gnus-faq.xml.

A different approach would be to do the following in Makefile.in...
|  sed '/[$$]Id:.*[$$]/d' < $@.tmp > $@
... which will give...
|  sed '/[$]Id:.*[$]/d' < gnus-faq.texi.tmp > gnus-faq.texi
... on the shell.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: cvs keyword hacking in texi/Makefile.in

[Karl Pflästerer]

On 24 Mrz 2005, reinersteib+gmane@imap.cc wrote:

> On Thu, Mar 24 2005, Miles Bader wrote:
>
>>    # FIXME: This should be done in xml2texi.scm or gnus-faq.xml should be
>>    # changed:
>>            sed '/\$$Id: Makefile.in,v 7.12 2005/03/24 09:14:37 miles Exp $$/d' < $@.tmp >
>>            	$@
>>
>> Besides the more general question of whether CVS keywords should be
>> used at all, this probably doesn't do what someone thought it does
>> -- it replaces the expansion of $Id$ for `Makefile.in' in the text
>> of `gnus-faq.xml'?!?  That's surely a nop...?
>
> Oops, it was supposed to remove the gnus-faq.xml-Id when creating
> gnus-faq.texi.  Of course it worked fine, until I committed it.  :-/
>
> Unless Frank or Karl come up with a better idea (see the Makefile
> comment above), I will probably the CVS keyword from gnus-faq.xml.

Could you elaborate what you wanted to achieve so I can write a Scheme
solution?

   KP

Re: cvs keyword hacking in texi/Makefile.in

[Miles Bader]

Karl Pflästerer <sigurd <at> 12move.de> writes:
> Could you elaborate what you wanted to achieve so I can write a Scheme
> solution?

My personal goal is to simply get rid of CVS keywords where possible; this
probably has the easiest implementation too... :-)

-Miles

Re: cvs keyword hacking in texi/Makefile.in

[Reiner Steib]

On Fri, Mar 25 2005, Miles Bader wrote:

> Karl Pflästerer <sigurd <at> 12move.de> writes:
>> Could you elaborate what you wanted to achieve so I can write a Scheme
>> solution?
>
> My personal goal is to simply get rid of CVS keywords where possible; this
> probably has the easiest implementation too... :-)

ACK.  The primary goal is _not_ to include the CVS keyword "$Id: ...$"
from gnus-faq.xml when generating gnus-faq.texi and the Gnus manuals
which include gnus-faq.texi.  (It should not even be included as a
comment, because this also makes trouble when merging changes.)  By
adding the sed command ('/[$]Id:.*[$]/d') in the Makefile, we get rid
of the Id tag when generating gnus-faq.texi.

Of course removing the Id tag from gnus-faq.xml would be the most
simple solution, but maybe we want to have the tag present in the
(X)HTML versions published on <URL:http://my.gnus.org/FAQ>?  It's nice
to see the revision date on the web version to see that they are up to
date.  The Id tag is located in the introductory part of the FAQ which
IMHO requires some modifications besides the Id tag:

,----[ <news:v9mzsvvdbp.fsf@marauder.physik.uni-ulm.de> ]
| > -  The "Changes" section should not be present in the texi version.
| 
| At least the CVS $ID$ should not be included.  I'm not sure if the
| faq-discuss mailing list is necessary.
`----

Maybe excluding some parts for the texi-version could be achieved best
by adding some markup in gnus-faq.xml which you can use in
xml2texi.scm?  (I'd also like to hear Frank's opinion on that.)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: cvs keyword hacking in texi/Makefile.in

[Karl Pflästerer]

On 25 Mrz 2005, reinersteib+gmane@imap.cc wrote:

>
> On Fri, Mar 25 2005, Miles Bader wrote:
>
>> Karl Pflästerer <sigurd <at> 12move.de> writes:
>>> Could you elaborate what you wanted to achieve so I can write a Scheme
>>> solution?
>>
>> My personal goal is to simply get rid of CVS keywords where possible; this
>> probably has the easiest implementation too... :-)
>
> ACK.  The primary goal is _not_ to include the CVS keyword "$Id: ...$"
> from gnus-faq.xml when generating gnus-faq.texi and the Gnus manuals
> which include gnus-faq.texi.  (It should not even be included as a
> comment, because this also makes trouble when merging changes.)  By
> adding the sed command ('/[$]Id:.*[$]/d') in the Makefile, we get rid
> of the Id tag when generating gnus-faq.texi.
>
> Of course removing the Id tag from gnus-faq.xml would be the most
> simple solution, but maybe we want to have the tag present in the
> (X)HTML versions published on <URL:http://my.gnus.org/FAQ>?  It's nice
> to see the revision date on the web version to see that they are up to
> date.  The Id tag is located in the introductory part of the FAQ which
> IMHO requires some modifications besides the Id tag:
>
> ,----[ <news:v9mzsvvdbp.fsf@marauder.physik.uni-ulm.de> ]
> | > -  The "Changes" section should not be present in the texi version.
> | 
> | At least the CVS $ID$ should not be included.  I'm not sure if the
> | faq-discuss mailing list is necessary.
> `----
>
> Maybe excluding some parts for the texi-version could be achieved best
> by adding some markup in gnus-faq.xml which you can use in
> xml2texi.scm?  (I'd also like to hear Frank's opinion on that.)

The clever guy I a am :-) I thought about that from the beginning.
There is a list of ignored sections.  Just try that patch:

Index: xml2texi.scm
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/xml2texi.scm,v
retrieving revision 7.2
diff -r7.2 xml2texi.scm
52c52
< (define +ignored-sections+ '("Frequently Asked Questions with Answers"))
---
> (define +ignored-sections+ '("Frequently Asked Questions with Answers" "Changes"))


The section with the title "Changes" will be excluded from the Texi
file.


   KP