Gnus development mailing list
 help / color / mirror / Atom feed
From: Danny Siu <dsiu@adobe.com>
Subject: Re: nnimap: nnimap-request-move-article does not delete the original
Date: Mon, 20 Feb 2006 18:28:53 -0800	[thread overview]
Message-ID: <ur75xh2ca.fsf@adobe.com> (raw)
In-Reply-To: <loom.20060217T052653-659@post.gmane.org>

Wolfram,

Thanks for the patch.  I have installed it and finally moved articles in
nnimap are marked correctly for expiration.

Can someone with cvs access submit this patch?

Wolfram Fenske writes:

  Wolfram> Andreas Vögele <voegelas <at> gmx.net> writes:
  >> When moving a message from one IMAP folder to another folder the
  >> message is copied but the original message isn't deleted.

  Wolfram> I'm having the same problem, usign Gnus v5.10.7.
 
  >> `nnimap-request-move-article' from CVS first evaluates `accept-form',
  >> which is set to `gnus-request-accept-article', to copy the article.
  >> Then the original messages's \Deleted flag is set.
  >> 
  >> But `gnus-request-accept-article' selects the destination IMAP folder.
  >> Since the source folder isn't selected again, the \Deleted flag is set
  >> while the wrong IMAP folder is selected.

  Wolfram> Thanks to your hints, I was able to come up with a patch that
  Wolfram> completely fixes the problem, at least for me. One line of code
  Wolfram> before the (imap-message-flags-add ...) in
  Wolfram> nnimap-request-move-article:

  Wolfram> *** /usr/home/wfenske/share/xemacs/site-lisp/gnus/nnimap.el Fri
  Wolfram>     Feb 17
  Wolfram> 00:40:24 2006
  Wolfram> --- /usr/local/lib/xemacs/xemacs-packages/lisp/gnus/nnimap.el Fri
  Wolfram>     Feb 17
  Wolfram> 05:10:57 2006 ***************
  Wolfram> *** 1492,1497 ****
  Wolfram> --- 1492,1498 ----
  Wolfram>                (setq result (eval accept-form)) (kill-buffer buf)
  Wolfram>                result)
  Wolfram> + (nnimap-possibly-change-group group server)
  Wolfram>              (imap-message-flags-add
  Wolfram>               (imap-range-to-message-set (list article))
  Wolfram>               "\\Deleted" 'silent nnimap-server-buffer))


  Wolfram> Cheers Wolfram

-- Danny Siu



  reply	other threads:[~2006-02-21  2:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-13 12:21 nnimap: nnimap-request-move-article does not delete the original message Andreas Vögele
2006-01-16 21:27 ` nnimap: nnimap-request-move-article does not delete the original Danny Siu
2006-01-17 23:09   ` Sebastian Tennant
2006-02-17  4:47 ` nnimap: nnimap-request-move-article does not delete the original message Wolfram Fenske
2006-02-21  2:28   ` Danny Siu [this message]
2006-02-21  7:14     ` nnimap: nnimap-request-move-article does not delete the original Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ur75xh2ca.fsf@adobe.com \
    --to=dsiu@adobe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).