From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/56717 Path: main.gmane.org!not-for-mail From: Kevin Greiner Newsgroups: gmane.emacs.gnus.general Subject: Re: Exact article count for nnml groups Date: Fri, 12 Mar 2004 17:56:51 -0600 Sender: ding-owner@lists.math.uh.edu Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1079135845 23396 80.91.224.253 (12 Mar 2004 23:57:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 12 Mar 2004 23:57:25 +0000 (UTC) Original-X-From: ding-owner+M5256@lists.math.uh.edu Sat Mar 13 00:57:17 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B1wWj-0007EC-00 for ; Sat, 13 Mar 2004 00:57:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1B1wWY-0008Rp-00; Fri, 12 Mar 2004 17:57:06 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1B1wWQ-0008Rj-00 for ding@lists.math.uh.edu; Fri, 12 Mar 2004 17:56:58 -0600 Original-Received: from quimby.gnus.org (quimby.gnus.org [80.91.224.244]) by justine.libertine.org (Postfix) with ESMTP id C76683A003D for ; Fri, 12 Mar 2004 17:56:56 -0600 (CST) Original-Received: from news by quimby.gnus.org with local (Exim 3.35 #1 (Debian)) id 1B1wWO-0007aF-00 for ; Sat, 13 Mar 2004 00:56:56 +0100 Original-To: ding@gnus.org Original-Path: not-for-mail Original-Newsgroups: gnus.ding Original-Lines: 58 Original-NNTP-Posting-Host: h-66-134-21-51.hstqtx02.covad.net Original-X-Trace: quimby.gnus.org 1079135816 29154 66.134.21.51 (12 Mar 2004 23:56:56 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: Fri, 12 Mar 2004 23:56:56 +0000 (UTC) User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (windows-nt) Cancel-Lock: sha1:LMtPO5sS+sSwl+UWalUAkR9pJ38= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:56717 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:56717 David Hanak writes: > Hi, > > Here's a patch I submitted last June which allows the group buffer to show > exact article counts for nnml groups instead of the estimate based on the > difference of the greatest and smallest article numbers. Kai then helped > me to improve it a bit, and then suggested to wait until the feature freeze > is over. I guess it is over now, and it would be nice if it could be > integrated into No Gnus. (I have all the paperwork done.) > > It is fairly simple, and perhaps a little bit out of date (after all, the > lisp files I patched were probably modified since then), but since they're > only additions, it shouldn't be too hard to merge them. Also, if anyone > writes functions to retrieve the list of existing article numbers for any > other backend than nnml, i.e., nnimap, then it should be able to display > exact article counts for those backends, too. David, I suspect that, since your proposing changing the back-end API, everyone is waiting to see how Lars responds to your proposal. There are a few points that I'd like to see addressed. * I'm not really happy with the use of a regexp to select groups. Your gnus-get-group-articles-list is making calls to the backend (i.e. server-specific code). Shouldn't the on/off switch be in the server's method? * The gnus-get-group-articles-list, gnsu-parse-group-articles-list aren't specific to the summary. They should be put in gnus-int. * I don't find the name gnus-get-group-articles-list nor its description that informative. From its use, and your text, I would say that you are returning the list of active articles. That got me thinking that the name should be something like gnus-get-active-articles. * The previous points had me looking in gnus-int where I found gnus-request-group-articles. Your new backend 'get-group-articles-list is simply the existing 'request-group-articles returning the articles as a list rather than in a buffer. From looking at your implementation, I can see why you want to do this as it certainly optimizes the API for nnml. However, I don't think that that is the proper way to approach the problem. You should either use the existing 'request-group-articles function, even if it is inefficient for nnml, or start a separate thread to discuss updating 'request-group-articles to return a list rather than a buffer. * From what I can see, there's only one call to your new code and that's in gnus-articles-to-read. Are you sure that this one function in gnus-sum is all that is necessary to change the article counts in the GROUP buffer? Also, which article count are you trying to correct? By my reading, the group buffer can display eight different counts for each group. Kevin