Re: two agent nits

[Kevin Greiner <kgreiner@xpediantsolutions.com>]

Simon Josefsson <jas@extundo.com> writes:

> Kevin Greiner <kgreiner@xpediantsolutions.com> writes:
>
>> Simon Josefsson <jas@extundo.com> writes:
>>
>>> * I can't seem to get the agent to fetch read articles.
>>>   gnus-agent-consider-all-articles's value is t
>>>   The default agent category predicate is 'true'.
>>>   `J s' and `J u' just download unread or ticked articles.
>>
>> Have to tried setting gnus-agent-consider-all-articles to nil?  That
>> seems to work for me.
>
> I tried, but still the same.  Pressing `J u' on groups just say it is
> finished, but only the unread/ticked articles are in my local cache.
>
> Hm.  The manual and the docstring for the variable doesn't seem to be
> in sync.  I thought the variable did what the docstring said, but the
> manual just discuss missing headers.  Which one is correct?

The variable gnus-agent-consider-all-articles appears in
gnus-agent-fetch-headers but NOT gnus-agent-fetch-articles.  However,
gnus-agent-fetch-group-1 calls gnus-agent-fetch-headers to get the
list of new articles so gnus-agent-consider-all-articles may, by
modifying the return value of gnus-agent-fetch-headers, effect the
list of articles being fetched by gnus-agent-fetch-articles.

In fact, that is almost certainly what is going wrong in your case.
For you to have read the article, you had to open the summary buffer.
That implies that gnus-agent-fetch-headers already fetched the headers
of each read article.  Now, it's later and you want
gnus-agent-fetch-group-1 to fetch the article.  The only problem is
that it uses gnus-agent-fetch-header to get the article list and
gnus-agent-fetch-header skips over those articles because their
headers have already been fetched.

I'll look into this further to see if I can reproduce it here.  If I
can, I'll work up a patch.  It will be a few days as I'm currently
busy on other projects.

Kevin