void-function ignore-errors from byte-compiled gnus-start.elc

void-function ignore-errors from byte-compiled gnus-start.elc

[Neil Crellin]

With two different recent releases of 5.8.2+cvs-updates, I get the
following error on trying to start gnus, plugged or unplugged.
Removing gnus-start.elc however allows both to work.  Any ideas here?

Signaling: (void-function ignore-errors)
  (ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init"))
  eval((ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init")))
  custom-initialize-reset(gnus-site-init-file (ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init")))
  custom-declare-variable(gnus-site-init-file (ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init")) ("/home/neilc/lisp/gnus/gnus-5.8.2.1/lisp/gnus-start.elc" . -1283) :group gnus-start :type (choice file (const nil)))
  gnus-1(nil nil nil)
  gnus(nil)
  call-interactively(gnus)
  execute-extended-command(nil)
* call-interactively(execute-extended-command)

-- 
Neil Crellin <neilc@wallaby.cc>

Re: void-function ignore-errors from byte-compiled gnus-start.elc

[Michael Welsh Duggan]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

Neil Crellin <neilc@wallaby.cc> writes:

> With two different recent releases of 5.8.2+cvs-updates, I get the
> following error on trying to start gnus, plugged or unplugged.
> Removing gnus-start.elc however allows both to work.  Any ideas here?
> 
> Signaling: (void-function ignore-errors)
>   (ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init"))
>   eval((ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init")))
>   custom-initialize-reset(gnus-site-init-file (ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init")))
>   custom-declare-variable(gnus-site-init-file (ignore-errors (concat (file-name-directory ...) "site-lisp/gnus-init")) ("/home/neilc/lisp/gnus/gnus-5.8.2.1/lisp/gnus-start.elc" . -1283) :group gnus-start :type (choice file (const nil)))
>   gnus-1(nil nil nil)
>   gnus(nil)
>   call-interactively(gnus)
>   execute-extended-command(nil)
> * call-interactively(execute-extended-command)

Interesting.  It looks as though ignore-errors isn't getting expanded
by the byte compiler.  Hmm...  Let me look.

Ah, I see.  The way defcustom works is causing the `ignore-errors' not
to be byte compiled.  Try the following patch:


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1684 bytes --]

cvs server: Diffing .
Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 5.250
diff -c -r5.250 ChangeLog
*** ChangeLog	1999/12/04 16:04:14	5.250
--- ChangeLog	1999/12/04 17:06:43
***************
*** 1,3 ****
--- 1,8 ----
+ 1999-12-04  Michael Welsh Duggan  <md5i@cs.cmu.edu>
+ 
+ 	* gnus-start.el (gnus-site-init-file): Don't use cl macros in
+ 	  defcustom definitions.
+ 
  1999-12-04  Simon Josefsson  <jas@pdc.kth.se>
  
  	* mm-decode.el (mm-display-part): Let mm-display-external return
Index: gnus-start.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-start.el,v
retrieving revision 5.44
diff -c -r5.44 gnus-start.el
*** gnus-start.el	1999/12/04 08:15:21	5.44
--- gnus-start.el	1999/12/04 17:06:46
***************
*** 47,56 ****
    :type 'file)
  
  (defcustom gnus-site-init-file
!   (ignore-errors
!     (concat (file-name-directory
! 	     (directory-file-name installation-directory))
! 	    "site-lisp/gnus-init"))
    "*The site-wide Gnus Emacs-Lisp startup file name, or nil if none.
  If a file with the `.el' or `.elc' suffixes exists, it will be read instead."
    :group 'gnus-start
--- 47,57 ----
    :type 'file)
  
  (defcustom gnus-site-init-file
!   (condition-case nil
!       (concat (file-name-directory
! 	       (directory-file-name installation-directory))
! 	      "site-lisp/gnus-init")
!     (error nil))
    "*The site-wide Gnus Emacs-Lisp startup file name, or nil if none.
  If a file with the `.el' or `.elc' suffixes exists, it will be read instead."
    :group 'gnus-start

[-- Attachment #3: Type: text/plain, Size: 38 bytes --]


-- 
Michael Duggan
(md5i@cs.cmu.edu)