Re: gnus-replace-in-string: Avoid inf-loop in XEmacs

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Thu, Apr 20 2006, Steve Youngs wrote:

> * Reiner Steib <reinersteib+gmane@imap.cc> writes:
>   > Is it just a wrapper around `replace-in-string' or is it Emacs
>   > implementation of `replace-regexp-in-string'?  Hm...
>
> This is from SXEmacs (which I ripped from XE 21.5)...
>
>
> (defun replace-regexp-in-string (regexp rep string &optional
> 					fixedcase literal subexp start)
>   "Replace all matches for REGEXP with REP in STRING.

The code is the same as in current Emacs CVS.  Some corrections in the
doc string and comments have been made in the meantime.

[...]
>   > We should change `gnus-replace-in-string' as follows, I think:
>   > --- gnus-util.el	20 Apr 2006 12:10:00 +0200	6.104.2.24
>   > +++ gnus-util.el	20 Apr 2006 14:52:55 +0200	
>
> I wondered why this wouldn't apply for me, until I realised it was a
> much older version of gnus-util.el that I had.  Is it from the v5-10
> branch?

Yes, 6.104.2.24 is the v5-10 branch.

>   > Does shifting down "((fboundp 'replace-in-string) ...)" solve this
>   > problem too?
>
> Yes.

I've committed the change (v5-10 and trunk).  Feel free to adjust the
version info on SXEmacs when necessary:

   ;; Prefer `replace-regexp-in-string' (present in Emacs, XEmacs 21.5,
   ;; SXEmacs 22.1.4) over `replace-in-string'.  The later leads to inf-loops
   ;; on empty matches:
   ;;   (replace-in-string "foo" "/*$" "/")
   ;;   (replace-in-string "xe" "\\(x\\)?" "")

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/