From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63531 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: s/defmacro/defsubst/ in mm-decode.el Date: Tue, 01 Aug 2006 13:02:48 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: References: <87u0559yz0.fsf@freemail.hu> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1154432035 30718 80.91.229.2 (1 Aug 2006 11:33:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2006 11:33:55 +0000 (UTC) Original-X-From: ding-owner+m12058@lists.math.uh.edu Tue Aug 01 13:33:53 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G7sVN-0006HB-4m for ding-account@gmane.org; Tue, 01 Aug 2006 13:33:46 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1G7sV3-0007oE-00; Tue, 01 Aug 2006 06:33:25 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1G7sT9-0007o8-00 for ding@lists.math.uh.edu; Tue, 01 Aug 2006 06:31:27 -0500 Original-Received: from quimby.gnus.org ([80.91.227.211]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1G7sT7-0004Ko-Jk for ding@lists.math.uh.edu; Tue, 01 Aug 2006 06:31:27 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1G7sT2-0006SA-00 for ; Tue, 01 Aug 2006 13:31:20 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1G7sSq-0005iT-4H for ding@gnus.org; Tue, 01 Aug 2006 13:31:08 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 01 Aug 2006 13:31:08 +0200 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 01 Aug 2006 13:31:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 37 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: .*T0'iU(sujq_j9\J>-d4fg;N/1++U#U$_5ii6k.=|"-n'?5O:Hyz&wi'-!I~,}7~GgT=0S /&-R5sbkNy5+Xo1y{Tw2KKxi@Xh"g@]Qc|.U<*]WDd)qvGowFDvfU1F]{EDho:7P0@|oOD=Bc{K4?> WP68K[Mx:}=`ZT'6g4'f+g?;`vri2!)xGy}3:=l'(/Cea0l4lo^H5#@/Z3ev Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:Bz7YCqxfhJKsbgj1mQIVvqe6UxY= X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:63531 Archived-At: On Tue, Jul 25 2006, Magnus Henoch wrote: > The following patch changes some macros in mm-decode.el to inline > functions, thereby making W3 happy, which tries to use them as > functions. Shouldn't this be fixed in w3 instead? (Is w3 still alive?) Could you point us to the relevant w3 code? Are you sure that this change can't break any existing (Gnus) code? (I'm no expert, but I seem to recall that s/defmacro/defsubst/ might make a difference WRT to the expansion of the arguments. CMIIW.) > --- orig/lisp/mm-decode.el > +++ mod/lisp/mm-decode.el > @@ -59,10 +59,10 @@ > > ;;; Convenience macros. > > -(defmacro mm-handle-buffer (handle) > - `(nth 0 ,handle)) > -(defmacro mm-handle-type (handle) > - `(nth 1 ,handle)) > +(defsubst mm-handle-buffer (handle) > + (nth 0 handle)) > +(defsubst mm-handle-type (handle) > + (nth 1 handle)) > (defsubst mm-handle-media-type (handle) > (if (stringp (car handle)) > (car handle) [...] Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/