Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
Subject: Re: merge popfix, pop3 (gnu emacs) and XEmacs version
Date: Fri, 16 Sep 2005 17:24:53 +0200	[thread overview]
Message-ID: <v94q8l3uii.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <87r7byw64p.fsf@mat.ucm.es>

On Fri, Sep 09 2005, Uwe Brauer wrote:

> What about popfix?

[ It's quite hard to find.  Finally I found the code you're most
  probably referring to in
  http://thread.gmane.org/gmane.emacs.xemacs.beta/15978 ]

On a quick glance...

It lacks documentation and author/copyright notices.  Would the author
assign his code?

I suspect that there's some amount of duplicate code (e.g. `pop-send'
and `pop3-send-command').  Would he help to merge it into pop3.el or
(maybe better as a first step) use functions from `pop3' if possible?

I'd suggest to use a proper namespace prefix, say "pop3-summary" and
rename the library accordingly.  I.e. each variable and function
should start with this prefix.

It doesn't work on Emacs (at least the keymap stuff).

Some variables should be defcustomed and many functions should get a
doc string.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




      reply	other threads:[~2005-09-16 15:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-08 16:55 Uwe Brauer
2005-09-08 17:47 ` Reiner Steib
2005-09-08 18:35   ` Reiner Steib
2005-09-09 16:36   ` Uwe Brauer
2005-09-16 15:24     ` Reiner Steib [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v94q8l3uii.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).