Changes in article-hide-headers break mml-preview (was: Changes committed gnus/lisp (ChangeLog gnus-art.el))

Changes in article-hide-headers break mml-preview (was: Changes committed gnus/lisp (ChangeLog gnus-art.el))

[Reiner Steib]

On Fri, Jun 04 2004, Katsumi Yamaoka wrote:

> (article-hide-headers): Refer to the values for gnus-ignored-headers and
>  gnus-visible-headers in the summary buffer since a user may have set them
>  as group parameters.

In my configuration, your changes in article-hide-headers break
mml-preview.  edebugging `article-hide-headers' I get...

  edebug-signal:
  Buffer is read-only: #<buffer *Article nndraft:drafts*>

... at the following spot:

	    ;; Mark the rank of the header.
	    (put-text-property
	     (point) (1+ (point)) 'message-rank
	     (if (or (and visible (looking-at visible))
		     (and ignored
			  (not (looking-at ignored))))
		 (gnus-article-header-rank)
	       (+ 2 max)))

After evaluating the defun of `article-hide-headers' from gnus-art.el
7.42 doesn't show this problem.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: Changes in article-hide-headers break mml-preview

[Katsumi Yamaoka]

>>>>> In <v94qpmgso3.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib <4.uce.03.r.s@nurfuerspam.de> wrote:

> On Fri, Jun 04 2004, Katsumi Yamaoka wrote:

>> (article-hide-headers): Refer to the values for gnus-ignored-headers and
>>  gnus-visible-headers in the summary buffer since a user may have set them
>>  as group parameters.

> In my configuration, your changes in article-hide-headers break
> mml-preview.  edebugging `article-hide-headers' I get...

>   edebug-signal:
>   Buffer is read-only: #<buffer *Article nndraft:drafts*>

I'm sorry for that.  Could you let me know the way to run mml-preview
on the "*Article nndraft:drafts*" buffer?  I only know mml-preview
makes the "*MIME preview of ...*" buffer when I type the `C-c C-m P'
key in the message buffer, and I couldn't reproduce such a problem.

P.S.  I must go home right now, but I will fix it tomorrow...
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Changes in article-hide-headers break mml-preview

[Reiner Steib]

On Tue, Jun 08 2004, Katsumi Yamaoka wrote:

>>>>>>	Reiner Steib <4.uce.03.r.s@nurfuerspam.de> wrote:
[...]
>> In my configuration, your changes in article-hide-headers break
>> mml-preview.  edebugging `article-hide-headers' I get...
>
>>   edebug-signal:
>>   Buffer is read-only: #<buffer *Article nndraft:drafts*>
>
> I'm sorry for that.  Could you let me know the way to run mml-preview
> on the "*Article nndraft:drafts*" buffer?  I only know mml-preview
> makes the "*MIME preview of ...*" buffer when I type the `C-c C-m P'

I also use a simple `M-x mml-preview' from the message buffer.  But in
my message buffer, `gnus-article-buffer' is "*Article nndraft:drafts*"
so (set-buffer gnus-article-buffer) changes to this buffer instead of
the "*MIME preview of ...*" buffer.

> key in the message buffer, and I couldn't reproduce such a problem.

In some way, I depends on my configuration, but I don't know how/why
(I cannot reproduce it with a minimal ~/.gnus.el yet).

> P.S.  I must go home right now, but I will fix it tomorrow...

Don't worry about it; I'll just use the old defun until you have time
to fix the problem.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: Changes in article-hide-headers break mml-preview

[Katsumi Yamaoka]

Fixed.  The error arose when gnus-single-article-buffer is nil.

>>>>> In <v9pt8ajgfo.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib <4.uce.03.r.s@nurfuerspam.de> wrote:

> On Tue, Jun 08 2004, Katsumi Yamaoka wrote:

>>>>>>>	Reiner Steib <4.uce.03.r.s@nurfuerspam.de> wrote:

>>> In my configuration, your changes in article-hide-headers break
>>> mml-preview.  edebugging `article-hide-headers' I get...
>>
>>>   edebug-signal:
>>>   Buffer is read-only: #<buffer *Article nndraft:drafts*>

[...]

> I also use a simple `M-x mml-preview' from the message buffer.  But in
> my message buffer, `gnus-article-buffer' is "*Article nndraft:drafts*"
> so (set-buffer gnus-article-buffer) changes to this buffer instead of
> the "*MIME preview of ...*" buffer.

mml-preview sets gnus-article-buffer as "*MIME preview of...*",
however it is set again as "*Article method:group*" in the
existing summary buffer if gnus-single-article-buffer is nil.

>> P.S.  I must go home right now, but I will fix it tomorrow...

> Don't worry about it; I'll just use the old defun until you have time
> to fix the problem.

Thanks.  I have noticed it in the train to home. :)
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Changes in article-hide-headers break mml-preview

[Reiner Steib]

On Wed, Jun 09 2004, Katsumi Yamaoka wrote:

> Fixed.  The error arose when gnus-single-article-buffer is nil.

Thanks, now it works for me (yes, I have set
`gnus-single-article-buffer' to nil).

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/