Latest cvs attachements have no button, appear inline

Latest cvs attachements have no button, appear inline

[Harry Putnam]

Using todays cvs I sent a message with an attachment added with the
C-c C-a command (`mml-attach-file').  I gcc'ed a copy to the same
group.

Looking at the gcc I see no evidence of an attachment.  The file I
attached was a plain text file.  I answered `plain/text' when
prompted.  However there is no mime button.  The file just appears in
line as if it were part of the text.

This is not the way its supposed to work is it?  shouldn't I see a
button of some kind and be able to display it by hitting <RET> or
hide it by rehitting <RET>?

I'm not sure what the recipient got but I wanted them to get an
attachment, not an inline document.

Re: Latest cvs attachements have no button, appear inline

[Harry Putnam]

Harry Putnam <reader@newsguy.com> writes:

> I'm not sure what the recipient got but I wanted them to get an
> attachment, not an inline document.

With a little more testing I see there are two choice at the 
`disposition' prompt one gets when using C-c C-a (`mml-attach-file')
Apparently the default is `inline' but I think that may have happened
somewhat recently.

Since we already have C-x i to insert files inline, wouldn't it make
sense to default to `attachment'.  That's almost always what I would
want when attaching something.  Or maybe its configurable.  But still
`attachemnt' seems to be a sensible default.

Re: Latest cvs attachements have no button, appear inline

[Reiner Steib]

On Fri, Jan 02 2004, Harry Putnam wrote:

> Harry Putnam <reader@newsguy.com> writes:
>
>> I'm not sure what the recipient got but I wanted them to get an
>> attachment, not an inline document.

See below.

> With a little more testing I see there are two choice at the 
> `disposition' prompt one gets when using C-c C-a (`mml-attach-file')
> Apparently the default is `inline' but I think that may have happened
> somewhat recently.

Correct:

2003-12-30  Reiner Steib  <Reiner.Steib@gmx.de>
[...]
	* mml.el (mml-minibuffer-read-disposition): New function.
	(mml-attach-file): Use it.

IMHO it makes sense to offer a choice for the disposition (apart from
editing the mml tags).

> Since we already have C-x i to insert files inline, 

Note that this is not the same, since it gives just plain inline text,
whereas an attachment with disposition "inline" is still a separate
MIME part.  The recipient (or his MUA) may choose how to display it.
The disposition is only a recommendation.

> wouldn't it make sense to default to `attachment'.  That's almost
> always what I would want when attaching something.  Or maybe its
> configurable.  But still `attachemnt' seems to be a sensible
> default.

I introduced `mml-minibuffer-read-disposition' because I often changed
"attachment" to "inline".  ;-)

The default choice depends on the content-type:

		      (if (string-match "^text/.*" type)
			  "inline"
			"attachment")

Maybe I should make the "^text/.*" regexp customizable?  WDYT?  (We
already have `mm-inline-media-tests', `mm-inlined-types' and so on for
_viewing_.  But I don't think we should use the same preferences for
composing.)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

Re: Latest cvs attachements have no button, appear inline

[Harry Putnam]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> IMHO it makes sense to offer a choice for the disposition (apart from
> editing the mml tags).
>
>> Since we already have C-x i to insert files inline, 
>
> Note that this is not the same, since it gives just plain inline text,
> whereas an attachment with disposition "inline" is still a separate
> MIME part.  The recipient (or his MUA) may choose how to display it.
> The disposition is only a recommendation.
>
>> wouldn't it make sense to default to `attachment'.  That's almost
>> always what I would want when attaching something.  Or maybe its
>> configurable.  But still `attachemnt' seems to be a sensible
>> default.
>
> I introduced `mml-minibuffer-read-disposition' because I often changed
> "attachment" to "inline".  ;-)
>
> The default choice depends on the content-type:
>
> 		      (if (string-match "^text/.*" type)
> 			  "inline"
> 			"attachment")
>
> Maybe I should make the "^text/.*" regexp customizable?  WDYT?  (We
> already have `mm-inline-media-tests', `mm-inlined-types' and so on for
> _viewing_.  But I don't think we should use the same preferences for
> composing.)

Now I've heard the reasoning it seems just as well to leave it as is.
The bit about inline being different than C-x i seems like a good
point.

It threw me only because I had been used to previous behavior that
would make it an `attachment' by default.

Most attachments probably aren't text so having `text' default to 
`inline' seems ok.