From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/46564 Path: main.gmane.org!not-for-mail From: Reiner Steib <4uce.02.r.steib@gmx.net> Newsgroups: gmane.emacs.gnus.general Subject: Re: Incorporate message-utils.el? Date: Mon, 16 Sep 2002 20:01:47 +0200 Sender: owner-ding@hpc.uh.edu Message-ID: References: Reply-To: reiner.steib@gmx.de NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: main.gmane.org 1032211228 16347 127.0.0.1 (16 Sep 2002 21:20:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 16 Sep 2002 21:20:28 +0000 (UTC) Return-path: Original-Received: from karazm.math.uh.edu ([129.7.128.1]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17r3IB-0004FX-00 for ; Mon, 16 Sep 2002 23:20:27 +0200 Original-Received: from sina.hpc.uh.edu (lists@sina.hpc.uh.edu [129.7.128.10]) by karazm.math.uh.edu (8.9.3/8.9.3) with ESMTP id NAA01156; Mon, 16 Sep 2002 13:02:18 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Mon, 16 Sep 2002 13:02:56 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id NAA23189 for ; Mon, 16 Sep 2002 13:02:40 -0500 (CDT) Original-Received: (qmail 18056 invoked by alias); 16 Sep 2002 18:01:50 -0000 Original-Received: (qmail 18051 invoked from network); 16 Sep 2002 18:01:49 -0000 Original-Received: from theotp5.physik.uni-ulm.de (134.60.10.145) by gnus.org with SMTP; 16 Sep 2002 18:01:49 -0000 Original-Received: (from ste@localhost) by theotp5.physik.uni-ulm.de (8.11.2/8.11.2) id g8GI1la22217; Mon, 16 Sep 2002 20:01:47 +0200 X-Authentication-Warning: theotp5.physik.uni-ulm.de: ste set sender to reiner.steib@physik.uni-ulm.de using -f Original-To: ding@gnus.org Mail-Followup-To: ding@gnus.org X-Face: #vK]N[`vqjuod*|)'[iD7/"3AB-ApT%fmN"LWAg@oS7OesGv~)n[OBTLM#I="J'Y^-7I I/ps7o_'IK@#-Rs{::DZ@O8yS|fexe,XslY[:dNWOb~>?mC-&i_c)say:"\IpA.5U.b]'NY;Pks{lb h.+#6%DpZuaK3dcHB`Av3zc:r!C%~s0&m,tWj]&},qg.+0ww2gK%f!:GK|wMl.I!(voY*1"^li8"~B BNG)9LvPi?^DMR-GVDnZqhu*3Hi,+g=wFhI)BL6&u{EOVEHjVEVq~d?_}lMntWAc3(6?kftjc>_f>! g0wM(qPM$d5]^TT_Qyi&L?LGVG)SHN;Gk/,pkY9,~ Original-Lines: 148 User-Agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.3.50 (i586-pc-linux-gnu) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:46564 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:46564 On Fri, Sep 13 2002, Kai Gro=DFjohann wrote: > Reiner Steib <4uce.02.r.steib@gmx.net> writes: [...] > One suggestion: invoke message-make-reply-subject instead, and do > something like > > (defcustom message-make-reply-subject-functions > '(message-strip-subject-re message-util-strip-was) > "Some useful docstring" > ...other.custom.stuff...) > > (defun message-make-reply-subject (subject) > (let ((funcs message-make-reply-subject-functions)) > (while funcs > (setq subject (funcall (pop funcs) subject))) > subject)) Sorry Kai, I haven't received your message in time before I started to change `message.el' (I had no net connection during the weekend), but I think we can always add your suggestion later. Up to now, I'm scrupling, because of the following (but I guess you will convince me finally ;-) ): - It would allow the user to produce strange subject like "Antwort: Re: ..." very easily. :-( - Currently, I have the following code: (defun message-reply [...] (when gnus-list-identifiers (setq subject (message-strip-list-identifiers subject))) (setq subject (concat "Re: " (message-strip-subject-re subject))) (when message-subject-trailing-was-query (setq subject (message-strip-subject-trailing-was subject))) Should `message-strip-list-identifiers' be in `message-make-reply-subject-functions' too? Then m-s-l-i has to check for `gnus-list-identifiers' and we call m-s-l-i even if g-l-i is nil. For `message-strip-subject-trailing-was' it's similar: m-s-s-t-w does nothing when m-s-t-w-q is nil. - Assume we add new functions later and the user has changed the default. If he used add-to-list it should be okay. What about customize? Does it respect the (changed) default or does it apply the (old) saved value? (Sorry, I don't use customize, so I don't know.) Okay, what I have done so far is the following=20 ,----[ *Draft* for the ChangeLog entry ] | * message.el (message-strip-subject-trailing-was, | message-change-subject, message-add-archive-header, | message-xpost-fup2-header, message-xpost-insert-note, | message-xpost-fup2, message-reduce-to-to-cc): New functions | adopted from message-utils.el. Add functions to the keymap (TODO: | in mode describtion) and menu. | (message-change-subject,message-xpost-fup2): Signal error if | current header is empty. | (message-xpost-insert-note): Changed insert position. | (message-archive-note): Ensure to insert note in message body. | (message-archive-header, message-archive-note, | message-xpost-default, message-xpost-note, message-fup2-note, | message-xpost-note-function): New variables adopted from | message-utils.el. Changed some doc-strings. | (message-mark-insert-{begin,end}): Rename from | message-{begin,end}-inserted-text-mark (message-utils.el), changed | values. | (message-subject-trailing-was-query, | message-subject-trailing-was-ask-regexp, | message-subject-trailing-was-regexp): New variables. | (message-to-list-only): Changed doc-string, added menu entry. `---- As I moved everything to `message.el', `message-utils.el' can be removed. I'm not sure where to put the menu entries for the functions. Which commands should be in the "Field" and which in the "Message" menu? I would suggest to put commands acting on the headers of the message to "Field" and others to "Message": "Field" menu: ["To" message-goto-to t] ["From" message-goto-from t] ["Subject" message-goto-subject t] + ["Change subject" message-change-subject t] ["Cc" message-goto-cc t] + ["Bcc" message-goto-bcc t] + ["Fcc" message-goto-fcc t] ["Reply-To" message-goto-reply-to t] + "----" + ;; (typical) news stuff ["Summary" message-goto-summary t] ["Keywords" message-goto-keywords t] ["Newsgroups" message-goto-newsgroups t] ["Followup-To" message-goto-followup-to t] - ["Mail-Followup-To" message-goto-mail-followup-to t] + ;; ["Followup-To (with note in body)" message-xpost-fup2 t] + ["Crosspost / Followup-To" message-xpost-fup2 t] ["Distribution" message-goto-distribution t] + ["X-No-Archive:" message-add-archive-header t ] + "----" + ;; (typical) mailing-lists stuff + ["Send to list only" message-to-list-only t] + ["Mail-Followup-To" message-goto-mail-followup-to t] + ["Reduce To: to Cc:" message-reduce-to-to-cc t] + "----" ["Body" message-goto-body t] ["Signature" message-goto-signature t])) "Message" menu: + ["Insert Region Marked" message-mark-inserted-region=20 + ["Insert File Marked" message-mark-insert-file=20 But apparently, this is not the convention we have. Looking at the manual, I found "Flag As (Un)important" in and "Request Receipt" in , though both are in the "Message" menu. I'm confused. Could somebody explain the convention? Now the key bindings: It's related to the previous question. If we consider e.g. `message-change-subject' as a "Field"-command, it should have a `C-c C-f' prefix, right? I'd suggest these: + (define-key message-mode-map "\C-c\C-fs" 'message-change-subject) + (define-key message-mode-map "\C-c\C-fx" 'message-xpost-fup2) + (define-key message-mode-map "\C-c\C-ft" 'message-reduce-to-to-cc) + (define-key message-mode-map "\C-c\C-fa" 'message-add-archive-header) + (define-key message-mode-map "\C-c\M-m" 'message-mark-inserted-region) + (define-key message-mode-map "\C-c\M-f" 'message-mark-insert-file) Other suggestions for the key bindings, anyone? If nobody has objections, I will also change the mode description (add the key bindings) and the manual (describing the new functions and key bindings).=20 I didn't attach the patch to this message, because it's not complete as long the above mentioned items are unclear for me. Bye, Reiner. --=20 ,,, (o o) ---ooO-(_)-Ooo--- PGP key available via WWW http://rsteib.home.pages.de/