Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Harald Hanche-Olsen <hanche@math.ntnu.no>
Cc: <ding@gnus.org>
Subject: Re: Problem running gnus when image is not already loaded
Date: Sat, 02 Feb 2008 19:12:43 +0100	[thread overview]
Message-ID: <v963x7b52c.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <20080202.185810.69637060.hanche@math.ntnu.no>

On Sat, Feb 02 2008, Harald Hanche-Olsen wrote:

> I noticed just now that you put the code to force the loading of
> whatever library find-image comes from before the test
> (display-graphic-p).  I think it should go after, since it makes
> little sense to force the loading of this library if the user is
> running emacs in a terminal.

Correct.  Thanks again.  I will install the following, unless someone
points out a problem or offers a better way.

--8<---------------cut here---------------start------------->8---
--- gnus.el.~7.77.~	2008-01-20 10:27:58.000000000 +0100
+++ gnus.el	2008-02-02 19:09:41.000000000 +0100
@@ -1003,6 +1003,12 @@
    ((and
      (fboundp 'find-image)
      (display-graphic-p)
+     (or
+      ;; Make sure the library defining `image-load-path' is loaded now
+      ;; (`find-image' is autoloaded).  Else, we may get "defvar ignored
+      ;; because image-load-path is let-bound".
+      (find-image '(nil (:type xpm :file "gnus.xpm")))
+      t)
      (let* ((data-directory (nnheader-find-etc-directory "images/gnus"))
 	    (image-load-path (cond (data-directory
 				    (list data-directory))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



      reply	other threads:[~2008-02-02 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080202.121924.157909693.hanche@math.ntnu.no>
2008-02-02 13:27 ` Reiner Steib
2008-02-02 16:03   ` Harald Hanche-Olsen
2008-02-02 17:50     ` Reiner Steib
2008-02-02 17:58   ` Harald Hanche-Olsen
2008-02-02 18:12     ` Reiner Steib [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v963x7b52c.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=ding@gnus.org \
    --cc=hanche@math.ntnu.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).