* Documentation & Keybinding for `gnus-article-browse-html-article'
@ 2006-03-15 13:30 Hynek Schlawack
2006-04-12 4:46 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Hynek Schlawack @ 2006-03-15 13:30 UTC (permalink / raw)
Hi,
some time ago, my HTML-viewing-code has been commited to CVS. Now it's up
to define a key-binding, a menuitem and add some documentation.
So, where would you categorize this code to?
Reiner suggested "<menu-bar> <Article> <Washing> <Html>" but there's
already a Html entry in the Washing-menu. Any other suggestions? "Extern HTML"?
The keybinding is even trickier I'm afraid. :( `W H' (as an analogy to
`W h') is already taken. Am I mistaken or it `W R' (_r_ender) still
free?
And last but not least, where would you put the documentation to? Is
this really `washing'? I'm a bit baffled in this point. :)
-hs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Documentation & Keybinding for `gnus-article-browse-html-article'
2006-03-15 13:30 Documentation & Keybinding for `gnus-article-browse-html-article' Hynek Schlawack
@ 2006-04-12 4:46 ` Lars Magne Ingebrigtsen
2006-05-18 13:32 ` Reiner Steib
0 siblings, 1 reply; 5+ messages in thread
From: Lars Magne Ingebrigtsen @ 2006-04-12 4:46 UTC (permalink / raw)
Hynek Schlawack <hs+ding@ox.cx> writes:
> some time ago, my HTML-viewing-code has been commited to CVS. Now it's up
> to define a key-binding, a menuitem and add some documentation.
[...]
> And last but not least, where would you put the documentation to? Is
> this really `washing'? I'm a bit baffled in this point. :)
This isn't really "washing" -- it's more akin to
`gnus-article-view-part-externally', which is bound to `K e'. So I'd
suggest `K H' for the binding, and put it in the same
menu/documentation node as `K e'.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Documentation & Keybinding for `gnus-article-browse-html-article'
2006-04-12 4:46 ` Lars Magne Ingebrigtsen
@ 2006-05-18 13:32 ` Reiner Steib
2006-05-23 12:43 ` Hynek Schlawack
0 siblings, 1 reply; 5+ messages in thread
From: Reiner Steib @ 2006-05-18 13:32 UTC (permalink / raw)
Cc: Hynek Schlawack
On Wed, Apr 12 2006, Lars Magne Ingebrigtsen wrote:
> Hynek Schlawack <hs+ding@ox.cx> writes:
>> some time ago, my HTML-viewing-code has been commited to CVS.
[ `gnus-article-browse-html-article' ]
>> Now it's up to define a key-binding, a menuitem and add some
>> documentation.
>
>> And last but not least, where would you put the documentation to? Is
>> this really `washing'? I'm a bit baffled in this point. :)
>
> This isn't really "washing" -- it's more akin to
> `gnus-article-view-part-externally', which is bound to `K e'. So I'd
> suggest `K H' for the binding, and put it in the same
> menu/documentation node as `K e'.
Hynek, could you provide a patch following Larsi's suggestions?
BTW, (info "(gnus)Saving Articles") also has similar commands:
,----[ (info "(gnus)Saving Articles") ]
| `O p'
| `|'
| Save the current article in a pipe. [...]
|
| `O P'
| Save the current article into muttprint. [...]
`----
But `gnus-article-browse-html-article' doesn't use the process/prefix
convention (maybe it could be extended to use it?):
,----[ (info "(gnus)Saving Articles") ]
| All these commands use the process/prefix convention (*note
| Process/Prefix::).
`----
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Documentation & Keybinding for `gnus-article-browse-html-article'
2006-05-18 13:32 ` Reiner Steib
@ 2006-05-23 12:43 ` Hynek Schlawack
2006-05-23 14:26 ` Reiner Steib
0 siblings, 1 reply; 5+ messages in thread
From: Hynek Schlawack @ 2006-05-23 12:43 UTC (permalink / raw)
Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>> And last but not least, where would you put the documentation to? Is
>>> this really `washing'? I'm a bit baffled in this point. :)
>>
>> This isn't really "washing" -- it's more akin to
>> `gnus-article-view-part-externally', which is bound to `K e'. So I'd
>> suggest `K H' for the binding, and put it in the same
>> menu/documentation node as `K e'.
> Hynek, could you provide a patch following Larsi's suggestions?
I'm sorry, that I've been really busy in the last weeks so I haven't
been able to follow this list and I've missed his mail. :(
The patch for a key binding is straight forward:
--8<---------------cut here---------------start------------->8---
Index: lisp/gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 7.172
diff -u -r7.172 gnus-art.el
--- lisp/gnus-art.el 16 May 2006 09:40:32 -0000 7.172
+++ lisp/gnus-art.el 23 May 2006 12:06:07 -0000
@@ -2708,7 +2708,6 @@
(gnus-article-browse-html-parts handle))))))))
showed))
-;; TODO: Key binding
(defun gnus-article-browse-html-article ()
"View \"text/html\" parts of the current article with a WWW browser."
(interactive)
Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 7.145
diff -u -r7.145 gnus-sum.el
--- lisp/gnus-sum.el 19 May 2006 00:00:51 -0000 7.145
+++ lisp/gnus-sum.el 23 May 2006 12:06:07 -0000
@@ -2092,6 +2092,7 @@
"c" gnus-article-copy-part
"C" gnus-article-view-part-as-charset
"e" gnus-article-view-part-externally
+ "H" gnus-article-browse-html-article
"E" gnus-article-encrypt-body
"i" gnus-article-inline-part
"|" gnus-article-pipe-part)
@@ -2128,7 +2129,8 @@
"b" gnus-uu-decode-binhex
"B" gnus-uu-decode-binhex
"p" gnus-uu-decode-postscript
- "P" gnus-uu-decode-postscript-and-save)
+ "P" gnus-uu-decode-postscript-and-save
+ "H" gnus-article-browse-html-article)
(gnus-define-keys
(gnus-uu-extract-view-map "v" gnus-uu-extract-map)
--8<---------------cut here---------------end--------------->8---
The docs are a bit trickier though:
> BTW, (info "(gnus)Saving Articles") also has similar commands:
>
> ,----[ (info "(gnus)Saving Articles") ]
> | `O p'
> | `|'
> | Save the current article in a pipe. [...]
> |
> | `O P'
> | Save the current article into muttprint. [...]
> `----
>
> But `gnus-article-browse-html-article' doesn't use the process/prefix
> convention (maybe it could be extended to use it?):
>
> ,----[ (info "(gnus)Saving Articles") ]
> | All these commands use the process/prefix convention (*note
> | Process/Prefix::).
> `----
I'd put it into (info "(gnus)MIME Commands"), I'll have to implement:
,----[ (info "(gnus)MIME Commands") ]
| The following commands all understand the numerical prefix. For
| instance, `3 b' means "view the third MIME part".
`----
Any `best practices'? ;) Unfortunately, the list of attachments is
recursive, so I guess I'll have to use a counter. Any other (more
elegant) ideas?
-hs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Documentation & Keybinding for `gnus-article-browse-html-article'
2006-05-23 12:43 ` Hynek Schlawack
@ 2006-05-23 14:26 ` Reiner Steib
0 siblings, 0 replies; 5+ messages in thread
From: Reiner Steib @ 2006-05-23 14:26 UTC (permalink / raw)
On Tue, May 23 2006, Hynek Schlawack wrote:
> --- lisp/gnus-sum.el 19 May 2006 00:00:51 -0000 7.145
> +++ lisp/gnus-sum.el 23 May 2006 12:06:07 -0000
> @@ -2092,6 +2092,7 @@
> "c" gnus-article-copy-part
> "C" gnus-article-view-part-as-charset
> "e" gnus-article-view-part-externally
> + "H" gnus-article-browse-html-article
> "E" gnus-article-encrypt-body
> "i" gnus-article-inline-part
> "|" gnus-article-pipe-part)
Installed. Thanks.
> @@ -2128,7 +2129,8 @@
> "b" gnus-uu-decode-binhex
> "B" gnus-uu-decode-binhex
> "p" gnus-uu-decode-postscript
> - "P" gnus-uu-decode-postscript-and-save)
> + "P" gnus-uu-decode-postscript-and-save
> + "H" gnus-article-browse-html-article)
I think one keybinding is sufficient.
> I'd put it into (info "(gnus)MIME Commands"), I'll have to implement:
>
> ,----[ (info "(gnus)MIME Commands") ]
> | The following commands all understand the numerical prefix. For
> | instance, `3 b' means "view the third MIME part".
> `----
>
> Any `best practices'? ;) Unfortunately, the list of attachments is
> recursive, so I guess I'll have to use a counter. Any other (more
> elegant) ideas?
Did you look at the use of `gnus-article-part-wrapper' in
`gnus-mime-view-part-internally' or the other MIME commands? If it's
more complicated, just document that
`gnus-article-browse-html-article' doesn't honor the numerical prefix
(yet).
BTW, I have implemented (by not yet committed) an extension to
`gnus-article-browse-html-article' which inserts some article headers
into the html output. It is a bit hackish, but I think this is useful
when printing html articles via `gnus-article-browse-html-article'.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-05-23 14:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-15 13:30 Documentation & Keybinding for `gnus-article-browse-html-article' Hynek Schlawack
2006-04-12 4:46 ` Lars Magne Ingebrigtsen
2006-05-18 13:32 ` Reiner Steib
2006-05-23 12:43 ` Hynek Schlawack
2006-05-23 14:26 ` Reiner Steib
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).