On Sun, Jan 09 2005, Steve Youngs wrote:

> The default settings should give a User-Agent header similar to the
> one in this message's headers.

| User-Agent: Gnus/5.110003 (No Gnus v0.3) SXEmacs/22.1.1 "Aston Martin" (linux)

Is a quoted string like "Aston Martin" allowed in RFC 2616?  Upto now,
we had it inside the bracket:

| [...] XEmacs/21.4 (Security Through Obscurity, berkeley-unix)

[...]
> +	* gnus.el (gnus-user-agent-display-codename): New.  When non-nil
> +	and a (S)XEmacs codename exists, display it in the User-Agent
> +	header. 

I'd prefer not to introduce another variable.  We already have
`gnus-user-agent' for this.  It is confusing to have several variables
for the same thing.  How about making `gnus-user-agent' a list?

,----[ C-h v gnus-user-agent RET ]
| gnus-user-agent's value is (gnus emacs type)
| 
| Which information should be exposed in the User-Agent header.
| 
| Can be a list of symbols or a string.  Valid symbols are `gnus'
| (show Gnus version) and `emacs' (show Emacs version).  In
| addition to the Emacs version, you can add `codename' (show
| (S)XEmacs codename) or either `config' (show system
| configuration) or `type' (show system type).  If you set it to
| a string, be sure to use a valid format, see RFC 2616.
`----

With a customize buffer like for the list:

,----
| [X] gnus
| [X] emacs
| [X] system: Value Menu type
| [ ] codename
`----

Changes:

  * gnus.el (gnus-user-agent): Use list of symbols instead of
  symbols.  Display full version number for (S)XEmacs.  Optionally
  display (S)XEmacs codename.
  
  * gnus-util.el (gnus-emacs-version): Update for new
  `gnus-user-agent'.
  
  * gnus-msg.el (gnus-extended-version): Make it possible to omit
  Gnus version.

See the attached patch for details.

>  (eval-when-compile
> -  (defvar xemacs-codename))
> +  (defvar xemacs-codename)
> +  (defvar sxemacs-codename)
> +  (defvar running-xemacs)
> +  (defvar running-sxemacs))

Is there any benefit of using `running-[s]xemacs' instead of (featurep
'[s]xemacs)?

Bye, Reiner.