Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
Cc: <ding@gnus.org>
Subject: gnus-summary-from-or-to-or-newsgroups (was: Changes committed gnus/lisp (gnus-sum.el))
Date: Mon, 27 Mar 2006 20:11:49 +0200	[thread overview]
Message-ID: <v97j6fu596.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <E1FNvQ3-00022a-00@quimby.gnus.org> (Karl Kleinpaste's message of "Mon, 27 Mar 2006 19:22:19 +0200")

On Mon, Mar 27 2006, Karl Kleinpaste on ding-patches:

> (gnus-summary-from-or-to-or-newsgroups): Improve newsgroups handling
> for NNTP overviews which don't include Newsgroups.

> --- gnus-sum.el:7.128	Wed Mar 22 08:12:55 2006
> +++ gnus-sum.el	Mon Mar 27 19:22:18 2006
> @@ -3522,7 +3522,13 @@
>  		      (inline
>  			(gnus-summary-extract-address-component
>  			 (funcall gnus-decode-encoded-word-function to)))))
> -	     ((setq newsgroups (cdr (assq 'Newsgroups extra-headers)))
> +	     ((setq newsgroups
> +		    (or
> +		     (cdr (assq 'Newsgroups extra-headers))
> +		     (and
> +                      (eq (car (gnus-find-method-for-group
> +                                gnus-newsgroup-name)) 'nntp)
> +                      (replace-in-string gnus-newsgroup-name "^.*:" ""))))
>  	      (concat gnus-summary-newsgroup-prefix newsgroups)))))
>       (inline (gnus-summary-extract-address-component gnus-tmp-from)))))

Emacs doesn't have `replace-in-string', you should use
`gnus-replace-in-string' if you must.  But wouldn't
`gnus-group-real-name' be better?  I've installed this patch:

2006-03-27  Reiner Steib  <Reiner.Steib@gmx.de>

	* gnus-sum.el (gnus-summary-from-or-to-or-newsgroups): Don't use
	XEmacs-only `replace-in-string'.  Use `gnus-group-real-name'
	instead.

--8<---------------cut here---------------start------------->8---
--- gnus-sum.el	27 Mar 2006 17:22:18 -0000	7.129
+++ gnus-sum.el	27 Mar 2006 18:09:52 -0000
@@ -3528,7 +3528,7 @@
 		     (and
                       (eq (car (gnus-find-method-for-group
                                 gnus-newsgroup-name)) 'nntp)
-                      (replace-in-string gnus-newsgroup-name "^.*:" ""))))
+		      (gnus-group-real-name gnus-newsgroup-name))))
 	      (concat gnus-summary-newsgroup-prefix newsgroups)))))
      (inline (gnus-summary-extract-address-component gnus-tmp-from)))))
 
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/



       reply	other threads:[~2006-03-27 18:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1FNvQ3-00022a-00@quimby.gnus.org>
2006-03-27 18:11 ` Reiner Steib [this message]
2006-04-04 20:47   ` gnus-summary-from-or-to-or-newsgroups Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v97j6fu596.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).