Re: Small change to message-tab to allow completion of mail aliases

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Fri, May 30 2008, Stephen Eglen wrote:

> Thanks for fixing the typo in message.el;  as I'm new to using GNUS
> (for reading/writing email, I've used it for news for ages), I just also
> found the following; is gnu.emacs.gnus a sensible place, or is the ding
> maillist more suitable?

The ding list (cc-ed) is more suitable.

(BTW, your message didn't appear on
<http://news.gmane.org/gmane.emacs.gnus.user> yet, which is feed from
the news2mail gateway gnu.emacs.gnus <-> info-gnus-english@gnu).

> From: Stephen Eglen <S.J.Eglen@damtp.cam.ac.uk>   
> Subject: Small change to message-tab to allow completion of mail aliases
> Newsgroups: gnu.emacs.gnus
> Date: Thu, 29 May 2008 19:28:05 +0200
> Organization: University of Cambridge, England
> Message-ID: <t5x1w3lt3yy.fsf@notch.damtp.cam.ac.uk>
> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
>
> Would it be worth making the following small change to
> message-expand-name, so that TAB on a To: field will allow for
> completion of mail aliases, rather than just expansion of complete mail
> aliases.  All that has changed is expand-abbrev has been changed to
> mail-abbrev-complete-alias
>
> (e.g. if you have the alias "moderator", and no other alias starting
> "mo", then "mo TAB" would complete to moderator)

Does this change have any drawbacks?  I always use the bbdb code path,
so I'm not familiar with the current and proposed behavior.

> (defun message-expand-name ()
>   (cond ((and (memq 'eudc message-expand-name-databases)
> 		    (boundp 'eudc-protocol)
> 		    eudc-protocol)
> 	 (eudc-expand-inline))
> 	((and (memq 'bbdb message-expand-name-databases)
> 	      (fboundp 'bbdb-complete-name))
> 	 (bbdb-complete-name))
> 	(t
> 	 (mail-abbrev-complete-alias))))
>          ;;(expand-abbrev))))

BTW (for future suggestions): sending a unified diff is
encouraged.  Like this:

--- message.el	29 May 2008 20:10:06 +0200	7.263
+++ message.el	30 May 2008 19:02:56 +0200	
@@ -7651,7 +7651,7 @@
 	      (fboundp 'bbdb-complete-name))
 	 (bbdb-complete-name))
 	(t
-	 (expand-abbrev))))
+	 (mail-abbrev-complete-alias))))
 
 ;;; Help stuff.

Could you also provide a ChangeLog entry describing the change?

Bye, Reiner
-- 
PGP key available                               http://rsteib.home.pages.de/