From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67007 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: Small change to message-tab to allow completion of mail aliases Date: Fri, 30 May 2008 19:14:50 +0200 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212167796 4287 80.91.229.12 (30 May 2008 17:16:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 May 2008 17:16:36 +0000 (UTC) Cc: ding@gnus.org To: Stephen Eglen Original-X-From: ding-owner+M15478@lists.math.uh.edu Fri May 30 19:17:14 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1K28E2-0003qC-F6 for ding-account@gmane.org; Fri, 30 May 2008 19:17:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1K28C8-0000uE-Ox; Fri, 30 May 2008 12:15:12 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1K28C5-0000tu-Oa for ding@lists.math.uh.edu; Fri, 30 May 2008 12:15:09 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1K28Bz-0007Qg-5B for ding@lists.math.uh.edu; Fri, 30 May 2008 12:15:09 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1K28CE-0003q2-00 for ; Fri, 30 May 2008 19:15:18 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m4UHEx24020754; Fri, 30 May 2008 19:14:59 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id C524A11A11; Fri, 30 May 2008 19:14:59 +0200 (CEST) Mail-Followup-To: Stephen Eglen , ding@gnus.org In-Reply-To: (Stephen Eglen's message of "Fri, 30 May 2008 15:46:51 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.2.50 (gnu/linux) X-DCC-dcc-servers.net-Metrics: poseidon 102; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67007 Archived-At: On Fri, May 30 2008, Stephen Eglen wrote: > Thanks for fixing the typo in message.el; as I'm new to using GNUS > (for reading/writing email, I've used it for news for ages), I just also > found the following; is gnu.emacs.gnus a sensible place, or is the ding > maillist more suitable? The ding list (cc-ed) is more suitable. (BTW, your message didn't appear on yet, which is feed from the news2mail gateway gnu.emacs.gnus <-> info-gnus-english@gnu). > From: Stephen Eglen > Subject: Small change to message-tab to allow completion of mail aliases > Newsgroups: gnu.emacs.gnus > Date: Thu, 29 May 2008 19:28:05 +0200 > Organization: University of Cambridge, England > Message-ID: > User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) > > Would it be worth making the following small change to > message-expand-name, so that TAB on a To: field will allow for > completion of mail aliases, rather than just expansion of complete mail > aliases. All that has changed is expand-abbrev has been changed to > mail-abbrev-complete-alias > > (e.g. if you have the alias "moderator", and no other alias starting > "mo", then "mo TAB" would complete to moderator) Does this change have any drawbacks? I always use the bbdb code path, so I'm not familiar with the current and proposed behavior. > (defun message-expand-name () > (cond ((and (memq 'eudc message-expand-name-databases) > (boundp 'eudc-protocol) > eudc-protocol) > (eudc-expand-inline)) > ((and (memq 'bbdb message-expand-name-databases) > (fboundp 'bbdb-complete-name)) > (bbdb-complete-name)) > (t > (mail-abbrev-complete-alias)))) > ;;(expand-abbrev)))) BTW (for future suggestions): sending a unified diff is encouraged. Like this: --- message.el 29 May 2008 20:10:06 +0200 7.263 +++ message.el 30 May 2008 19:02:56 +0200 @@ -7651,7 +7651,7 @@ (fboundp 'bbdb-complete-name)) (bbdb-complete-name)) (t - (expand-abbrev)))) + (mail-abbrev-complete-alias)))) ;;; Help stuff. Could you also provide a ChangeLog entry describing the change? Bye, Reiner -- PGP key available http://rsteib.home.pages.de/