Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
Subject: Re: security buttons without a face (3)
Date: Wed, 27 Sep 2006 14:30:36 +0200	[thread overview]
Message-ID: <v98xk5a3v7.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <m2d59h7gug.fsf@ooomph.local>

On Wed, Sep 27 2006, Max Froumentin wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> Could you please resend the patch including the diff headers?
>> Preferably using a unified (or at least context) diff format (-u or
>> -c).
>
> certainly:
>
> --- gnus-art.el	2006-09-26 14:43:50.000000000 +0100
> +++ gnus-art.el.7.196	2006-09-26 14:53:16.000000000 +0100
> @@ -7499,24 +7499,18 @@

Committed.

BTW, this patch was reversed (wrong direction).  You should use "diff
-u old-file new-file" or better use "cvs diff -u file" or even better
use Emacs version control features.  I'd recommend PCL-CVS, see (info
"(pcl-cvs)Top").

>  (defun gnus-insert-prev-page-button ()
>    (let ((b (point))
> -        (e (point))

I don't understand why you set `e' to `(point)' here, because later
you're unconditionally setting `e' to some other value.  I've
installed a modification, please holler if there's something wrong
with it.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




      reply	other threads:[~2006-09-27 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28 12:04 Max Froumentin
2006-07-28 13:16 ` Reiner Steib
2006-07-29 18:18   ` Max Froumentin
2006-09-20 16:30     ` Reiner Steib
2006-09-26 13:55       ` Max Froumentin
2006-09-26 14:53         ` Reiner Steib
2006-09-27 10:18           ` Max Froumentin
2006-09-27 12:30             ` Reiner Steib [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v98xk5a3v7.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).