Re: gnus-agent-expire-group-1 bug?

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Oct 22 2007, Katsumi Yamaoka wrote:

> Hi,
>
> The following section (prefixed with `-') in the function
> `gnus-agent-expire-group-1' seems to do nothing, though I'm not
> sure what it is for.  There's no `catch' for `sort-results', and
> the `when' always gets nil.
>
> (I found this while trying replacing `mapcar' with `mapc' or
> `dolist'.
> cf. http://article.gmane.org/gmane.emacs.gnus.general/65429)
>
> --- gnus-agent.el~	2007-10-04 21:53:35 +0000
> +++ gnus-agent.el	2007-10-22 09:55:41 +0000
> @@ -3329,27 +3329,6 @@
>
>  		   (setcdr dlist (cddr dlist)))
>  	       (setq dlist (cdr dlist)))))
> -
> -	 ;; Check the order of the entry positions.  They should be in
> -	 ;; ascending order.  If they aren't, the positions must be
> -	 ;; converted to markers.
> -	 (when (let ((dlist dlist)
> -		     (prev-pos -1)
> -		     pos)
> -		 (while dlist
> -		   (if (setq pos (nth 3 (pop dlist)))
> -		       (if (< pos prev-pos)
> -			   (throw 'sort-results 'unsorted)
> -			 (setq prev-pos pos)))))
> -	   (gnus-message 7 "gnus-agent-expire: Unsorted overview; inserting markers to compensate.")
> -	   (mapcar (lambda (entry)
> -		     (let ((pos (nth 3 entry)))
> -		       (if pos
> -			   (setf (nth 3 entry)
> -				 (set-marker (make-marker)
> -					     pos)))))
> -		   dlist))
> -
>  	 (gnus-message 7 "gnus-agent-expire: Merging entries... Done")
>
>  	 (let* ((len (float (length dlist)))

Kevin, could you please comment on this?  The relevant log entry is

,----
| 2005-03-06  Kevin Greiner  <kevin.greiner@compsol.cc>
| [...]
| 	* gnus-agent.el [...]
| 	(gnus-agent-expire-group-1): Avoid using markers when the overview
| 	is in ascending order; greatly improves performance.
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/