From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65437 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-agent-expire-group-1 bug? Date: Mon, 22 Oct 2007 20:54:57 +0200 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193080304 31383 80.91.229.12 (22 Oct 2007 19:11:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Oct 2007 19:11:44 +0000 (UTC) Cc: ding@gnus.org To: Kevin Greiner Original-X-From: ding-owner+M13936@lists.math.uh.edu Mon Oct 22 21:11:44 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ik2gd-0001mf-OO for ding-account@gmane.org; Mon, 22 Oct 2007 21:11:40 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Ik2fg-00034u-77; Mon, 22 Oct 2007 14:10:40 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Ik2fd-00034i-K3 for ding@lists.math.uh.edu; Mon, 22 Oct 2007 14:10:37 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1Ik2fX-0000yV-5M for ding@lists.math.uh.edu; Mon, 22 Oct 2007 14:10:37 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ik2fQ-0005In-00 for ; Mon, 22 Oct 2007 21:10:24 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id l9MJARKI024249; Mon, 22 Oct 2007 21:10:27 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 1BA2A12CC2; Mon, 22 Oct 2007 21:10:27 +0200 (CEST) X-Face: mtjf/D:es1T0wHO:&CJ'ZXe"l;3C--rw\z!{`eFwL){|]RpI+4{u25L=5C /0>KuGeTsk<~<&NE-AKV1560e!+RJeyWmSskkrJm?[vUV#66{T_m|Ae<||Ku#Mk5`y&O`n~z2;n8eP J5#2h@2eQgV@E70IY_0WlEx!"&giy{+\%h1LJox$zv@/l%ZmU4^tZA>xQpnkUBVC5.jpg#0'(+2?Rs )NAr:>3<=WxHE$ktbLysDIM5TbmHu*3, ding@gnus.org In-Reply-To: (Katsumi Yamaoka's message of "Mon, 22 Oct 2007 18:57:16 +0900") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-DCC-INFN-TO-Metrics: poseidon 1233; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:65437 Archived-At: On Mon, Oct 22 2007, Katsumi Yamaoka wrote: > Hi, > > The following section (prefixed with `-') in the function > `gnus-agent-expire-group-1' seems to do nothing, though I'm not > sure what it is for. There's no `catch' for `sort-results', and > the `when' always gets nil. > > (I found this while trying replacing `mapcar' with `mapc' or > `dolist'. > cf. http://article.gmane.org/gmane.emacs.gnus.general/65429) > > --- gnus-agent.el~ 2007-10-04 21:53:35 +0000 > +++ gnus-agent.el 2007-10-22 09:55:41 +0000 > @@ -3329,27 +3329,6 @@ > > (setcdr dlist (cddr dlist))) > (setq dlist (cdr dlist))))) > - > - ;; Check the order of the entry positions. They should be in > - ;; ascending order. If they aren't, the positions must be > - ;; converted to markers. > - (when (let ((dlist dlist) > - (prev-pos -1) > - pos) > - (while dlist > - (if (setq pos (nth 3 (pop dlist))) > - (if (< pos prev-pos) > - (throw 'sort-results 'unsorted) > - (setq prev-pos pos))))) > - (gnus-message 7 "gnus-agent-expire: Unsorted overview; inserting markers to compensate.") > - (mapcar (lambda (entry) > - (let ((pos (nth 3 entry))) > - (if pos > - (setf (nth 3 entry) > - (set-marker (make-marker) > - pos))))) > - dlist)) > - > (gnus-message 7 "gnus-agent-expire: Merging entries... Done") > > (let* ((len (float (length dlist))) Kevin, could you please comment on this? The relevant log entry is ,---- | 2005-03-06 Kevin Greiner | [...] | * gnus-agent.el [...] | (gnus-agent-expire-group-1): Avoid using markers when the overview | is in ascending order; greatly improves performance. `---- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/