Gnus development mailing list
 help / color / mirror / Atom feed
* display picons _and_ textual address
@ 2004-03-02 15:30 Reiner Steib
  2004-03-02 18:05 ` Wes Hardaker
  2004-03-25  2:05 ` Jesper Harder
  0 siblings, 2 replies; 16+ messages in thread
From: Reiner Steib @ 2004-03-02 15:30 UTC (permalink / raw)


Hi,

does anyone have code to display picons similar to the way Loom [1]
does?  Loom displays the textual address _and_ picons whereas the
picons *replace* the textual parts in Gnus.

I.e. instead of...

  From: Some Name <[UserPicon]@[DomainPicon].[CountryPicon]>

... I'd like to have...

  From: Some Name <user@domain.tld> [UserPicon]@[DomainPicon].[CountryPicon]

... or...

  From: Some Name [UserPicon]@[DomainPicon].[CountryPicon] <user@domain.tld>

... or similar.

Probably this could be done by replacing
`gnus-picon-transform-address' with a different function.  Anyone?

Bye, Reiner.

[1] <URL:http://article.gmane.org/gmane.emacs.pretest.bugs/2272>,
    <URL:http://loom.gmane.org/>, <URL:http://gmane.org/>
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-02 15:30 display picons _and_ textual address Reiner Steib
@ 2004-03-02 18:05 ` Wes Hardaker
  2004-03-02 19:57   ` Reiner Steib
  2004-03-25  2:05 ` Jesper Harder
  1 sibling, 1 reply; 16+ messages in thread
From: Wes Hardaker @ 2004-03-02 18:05 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]

>>>>> On Tue, 02 Mar 2004 16:30:33 +0100, Reiner Steib <4.uce.03.r.s@nurfuerspam.de> said:

Reiner> does anyone have code to display picons similar to the way
Reiner> Loom [1] does?  Loom displays the textual address _and_ picons
Reiner> whereas the picons *replace* the textual parts in Gnus.

Should be easy enough to do.  It should be configurable as to which
form you want.  Note it'll make the line fairly long.

Well, something like the attached patch may work.

The original implementation I did a long time ago was more powerful
but was rewritten by Lars (I presume to provide better Emacs support,
since when I wrote the original version Emacs couldn't handle images
and thus I was probably using XEmacs specific functions).  Anyway, the
new version actually deletes the text (the old I think made the text
invisible and let you toggle between the icons and text using a mouse
button if I recall).  The patch below may keep the text around but
puts the images next to it.  I haven't tested it, as picons appears to
be broken on my xemacs.  I suspect this is another XEmacs 21.5 issue
with respect to specs...  sigh...

If you want, you could always get a copy of the gnus-picon.el file
from CVS before Lars rewrote it...

-- 
"In the bathtub of history the truth is harder to hold than the soap,
 and much more difficult to find."  -- Terry Pratchett

[-- Attachment #2: picon-patch --]
[-- Type: application/octet-stream, Size: 819 bytes --]

Index: gnus-picon.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-picon.el,v
retrieving revision 7.2
diff -u -r7.2 gnus-picon.el
--- gnus-picon.el	5 Feb 2004 02:42:26 -0000	7.2
+++ gnus-picon.el	2 Mar 2004 18:05:14 -0000
@@ -74,6 +74,11 @@
   :type '(repeat string)
   :group 'gnus-picon)
 
+(defcustom gnus-picon-replace-text t
+  "*Replace text with the picons if t, or just insert next to them if nil."
+  :type 'boolean
+  :group 'gnus-picon)
+
 (defface gnus-picon-xbm-face '((t (:foreground "black" :background "white")))
   "Face to show xbm picon in."
   :group 'gnus-picon)
@@ -194,7 +199,8 @@
 	  (gnus-article-goto-header header)
 	  (mail-header-narrow-to-field)
 	  (when (search-forward address nil t)
-	    (delete-region (match-beginnin

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-02 18:05 ` Wes Hardaker
@ 2004-03-02 19:57   ` Reiner Steib
  2004-03-02 20:30     ` Wes Hardaker
  0 siblings, 1 reply; 16+ messages in thread
From: Reiner Steib @ 2004-03-02 19:57 UTC (permalink / raw)


On Tue, Mar 02 2004, Wes Hardaker wrote:

> Well, something like the attached patch may work.

The patch seems to be incomplete. It ends in the middle of this hunk:

,----
| @@ -194,7 +199,8 @@
|  	  (gnus-article-goto-header header)
|  	  (mail-header-narrow-to-field)
|  	  (when (search-forward address nil t)
| -	    (delete-region (match-beginnin
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-02 19:57   ` Reiner Steib
@ 2004-03-02 20:30     ` Wes Hardaker
  2004-03-04 21:17       ` Jesper Harder
  0 siblings, 1 reply; 16+ messages in thread
From: Wes Hardaker @ 2004-03-02 20:30 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

>>>>> On Tue, 02 Mar 2004 20:57:48 +0100, Reiner Steib <4.uce.03.r.s@nurfuerspam.de> said:

Reiner> The patch seems to be incomplete. It ends in the middle of this hunk:

Odd.

Re-diffed and resending.

cvs piped through programs occasionally truncates stuff for me.  Never
figured out why.  Probably a queuing problem.  I redirected to a file,
and that has never truncated for me so I'm confused.  This file,
however, looks complete.  Which means if it doesn't come through ok
then its a gnus problem (much worse!)

-- 
"In the bathtub of history the truth is harder to hold than the soap,
 and much more difficult to find."  -- Terry Pratchett

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: picons.patch --]
[-- Type: text/x-patch, Size: 998 bytes --]

Index: gnus-picon.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-picon.el,v
retrieving revision 7.2
diff -u -r7.2 gnus-picon.el
--- gnus-picon.el	5 Feb 2004 02:42:26 -0000	7.2
+++ gnus-picon.el	2 Mar 2004 20:29:31 -0000
@@ -74,6 +74,11 @@
   :type '(repeat string)
   :group 'gnus-picon)
 
+(defcustom gnus-picon-replace-text t
+  "*Replace text with the picons if t, or just insert next to them if nil."
+  :type 'boolean
+  :group 'gnus-picon)
+
 (defface gnus-picon-xbm-face '((t (:foreground "black" :background "white")))
   "Face to show xbm picon in."
   :group 'gnus-picon)
@@ -194,7 +199,8 @@
 	  (gnus-article-goto-header header)
 	  (mail-header-narrow-to-field)
 	  (when (search-forward address nil t)
-	    (delete-region (match-beginning 0) (match-end 0))
+	    (if gnus-picon-replace-text
+		(delete-region (match-beginning 0) (match-end 0)))
 	    (setq point (point))
 	    (while spec
 	      (goto-char point)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-02 20:30     ` Wes Hardaker
@ 2004-03-04 21:17       ` Jesper Harder
  2004-03-04 22:05         ` Wes Hardaker
  0 siblings, 1 reply; 16+ messages in thread
From: Jesper Harder @ 2004-03-04 21:17 UTC (permalink / raw)


Wes Hardaker <wes@hardakers.net> writes:

>>>>>> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> said:
>
> Reiner> The patch seems to be incomplete. It ends in the middle of this hunk:
>
> Odd.
>
> Re-diffed and resending.

The result looks a little bit strange.  For your From line I see:

  From:  Wes Hardaker <wes@hardakers.netwes@[picon].[picon]>

I think Reiner's suggestion

  From: Some Name <user@domain.tld> [UserPicon]@[DomainPicon].[CountryPicon]

would look nicer (dunno, how hard it would to implement, though).

Maybe I'd prefer to leave out the '.' and '@' between the picons as
well, and omit any part that doesn't have a picon.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-04 21:17       ` Jesper Harder
@ 2004-03-04 22:05         ` Wes Hardaker
  0 siblings, 0 replies; 16+ messages in thread
From: Wes Hardaker @ 2004-03-04 22:05 UTC (permalink / raw)


>>>>> On Thu, 04 Mar 2004 22:17:16 +0100, Jesper Harder <harder@ifa.au.dk> said:

Jesper> The result looks a little bit strange.  For your From line I
Jesper> see:

Hey, it was a 5 second patch ;-)

Jesper> Maybe I'd prefer to leave out the '.' and '@' between the picons as
Jesper> well, and omit any part that doesn't have a picon.

Well, you should try a older pre-rewritten copy of the code instead
(may require XEmacs), as it is a bit nicer about the icons.  It
actually let you toggle them.  IE, it would show up similar to how it
does now but if you clicked on it with the middle button it would
toggle between the text and the image.  It would be fairly trivial to
put a variable in the older code that would simply not make the
original text invisible.

-- 
"In the bathtub of history the truth is harder to hold than the soap,
 and much more difficult to find."  -- Terry Pratchett



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-02 15:30 display picons _and_ textual address Reiner Steib
  2004-03-02 18:05 ` Wes Hardaker
@ 2004-03-25  2:05 ` Jesper Harder
  2004-03-25 13:21   ` Reiner Steib
  1 sibling, 1 reply; 16+ messages in thread
From: Jesper Harder @ 2004-03-25  2:05 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> does anyone have code to display picons similar to the way Loom [1]
> does?  Loom displays the textual address _and_ picons whereas the
> picons *replace* the textual parts in Gnus.

Here's a patch.  I think it looks a lot better than the current style.
(it probably doesn't work in XEmacs -- porting is left as an exercise
for the reader).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2717 bytes --]

diff -c /home/harder/gnus/lisp/gnus-picon.el /home/harder/cvsgnus/lisp/gnus-picon.el
*** /home/harder/gnus/lisp/gnus-picon.el	Thu Feb  5 03:35:28 2004
--- /home/harder/cvsgnus/lisp/gnus-picon.el	Thu Mar 25 02:54:02 2004
***************
*** 151,156 ****
--- 151,158 ----
  
  ;;; Functions that does picon transformations:
  
+ (defvar gnus-picon-style 'right)
+ 
  (defun gnus-picon-transform-address (header category)
    (gnus-with-article-headers
      (let ((addresses
***************
*** 162,168 ****
  	       (mail-encode-encoded-word-string
  		(or (mail-fetch-field header) "")))
  	     (mail-fetch-field header))))
! 	  spec file point cache)
        (dolist (address addresses)
  	(setq address (car address))
  	(when (and (stringp address)
--- 164,170 ----
  	       (mail-encode-encoded-word-string
  		(or (mail-fetch-field header) "")))
  	     (mail-fetch-field header))))
! 	  spec file point cache len)
        (dolist (address addresses)
  	(setq address (car address))
  	(when (and (stringp address)
***************
*** 193,208 ****
  
  	  (gnus-article-goto-header header)
  	  (mail-header-narrow-to-field)
! 	  (when (search-forward address nil t)
! 	    (delete-region (match-beginning 0) (match-end 0))
! 	    (setq point (point))
! 	    (while spec
! 	      (goto-char point)
! 	      (if (> (length spec) 2)
! 		  (insert ".")
! 		(if (= (length spec) 2)
! 		  (insert "@")))
! 	      (gnus-picon-insert-glyph (pop spec) category))))))))
  
  (defun gnus-picon-transform-newsgroups (header)
    (interactive)
--- 195,230 ----
  
  	  (gnus-article-goto-header header)
  	  (mail-header-narrow-to-field)
! 	  (case gnus-picon-style
! 	    (right
! 	     (when (= (length addresses) 1)
! 	       (setq len (apply '+ (mapcar (lambda (x)
! 					     (condition-case nil
! 						 (car (image-size (car x))) 
! 					       (error 0))) spec)))
! 	       (when (> len 0)
! 		 (goto-char (point-at-eol))
! 		 (insert (propertize 
! 			  " " 'display
! 			  (cons 'space (list :align-to (- (window-width) len))))))
! 	       (goto-char (point-at-eol))
! 	       (setq point (point-at-eol))
! 	       (dolist (image spec)
! 		 (unless (stringp image)
! 		   (goto-char point)
! 		   (gnus-picon-insert-glyph image category)))))
! 	    (inline
! 	      (when (search-forward address nil t)
! 		(delete-region (match-beginning 0) (match-end 0))
! 		(setq point (point))
! 		(while spec
! 		  (goto-char point)
! 		  (if (> (length spec) 2)
! 		      (insert ".")
! 		    (if (= (length spec) 2)
! 			(insert "@")))
! 		  (gnus-picon-insert-glyph (pop spec) category)))))
! 	      )))))
  
  (defun gnus-picon-transform-newsgroups (header)
    (interactive)

Diff finished.  Thu Mar 25 02:54:23 2004

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-25  2:05 ` Jesper Harder
@ 2004-03-25 13:21   ` Reiner Steib
       [not found]     ` <v97jx912q4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
  0 siblings, 1 reply; 16+ messages in thread
From: Reiner Steib @ 2004-03-25 13:21 UTC (permalink / raw)


On Thu, Mar 25 2004, Jesper Harder wrote:

> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>
>> does anyone have code to display picons similar to the way Loom [1]
>> does?  Loom displays the textual address _and_ picons whereas the
>> picons *replace* the textual parts in Gnus.
>
> Here's a patch.  I think it looks a lot better than the current
> style.

Thanks, I like it a lot!

I'd prefer one minor change: For Emacs <= 21.3 (I know that CVS-Emacs
handle this better), it would be better to use "window-width minus one
minus len":

-  (cons 'space (list :align-to (- (window-width) 1 len))))))
+  (cons 'space (list :align-to (- (window-width) len))))))

> (it probably doesn't work in XEmacs -- porting is left as an exercise
> for the reader).

Does anyone like to test it (and make it work?) with XEmacs?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
       [not found]     ` <v97jx912q4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
@ 2004-03-27 12:14       ` Jochen Küpper
  2004-05-16 16:10         ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 16+ messages in thread
From: Jochen Küpper @ 2004-03-27 12:14 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Thu, 25 Mar 2004 14:21:55 +0100 Reiner Steib wrote:

Reiner> On Thu, Mar 25 2004, Jesper Harder wrote:

>> Reiner Steib <4.uce.03.r.s-Xv0xCBoRcaZkYx7DZD8BGw@public.gmane.org> writes:
>> 
>>> does anyone have code to display picons similar to the way Loom [1]
>>> does?  Loom displays the textual address _and_ picons whereas the
>>> picons *replace* the textual parts in Gnus.
>> 
>> Here's a patch.  I think it looks a lot better than the current
>> style.

Me too. Thanks!

Reiner> -  (cons 'space (list :align-to (- (window-width) 1 len))))))
Reiner> +  (cons 'space (list :align-to (- (window-width) len))))))

Agreed; looks even nicer;)

I added the analogous patch to gnus-picon-transform-newsgroups,
complete diff against cvs HEAD attached.

Greetings,
Jochen
-- 
Einigkeit und Recht und Freiheit                http://www.Jochen-Kuepper.de
    Liberté, Égalité, Fraternité                GnuPG key: CC1B0B4D
        (Part 3 you find in my messages before fall 2003.)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: picons.diff --]
[-- Type: text/x-patch, Size: 4141 bytes --]

? autom4te.cache
Index: lisp/gnus-picon.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-picon.el,v
retrieving revision 7.2
diff -u -u -r7.2 gnus-picon.el
--- lisp/gnus-picon.el	5 Feb 2004 02:42:26 -0000	7.2
+++ lisp/gnus-picon.el	27 Mar 2004 12:09:20 -0000
@@ -151,6 +151,8 @@
 
 ;;; Functions that does picon transformations:
 
+(defvar gnus-picon-style 'right)
+
 (defun gnus-picon-transform-address (header category)
   (gnus-with-article-headers
     (let ((addresses
@@ -162,7 +164,7 @@
 	       (mail-encode-encoded-word-string
 		(or (mail-fetch-field header) "")))
 	     (mail-fetch-field header))))
-	  spec file point cache)
+	  spec file point cache len)
       (dolist (address addresses)
 	(setq address (car address))
 	(when (and (stringp address)
@@ -193,16 +195,36 @@
 
 	  (gnus-article-goto-header header)
 	  (mail-header-narrow-to-field)
-	  (when (search-forward address nil t)
-	    (delete-region (match-beginning 0) (match-end 0))
-	    (setq point (point))
-	    (while spec
-	      (goto-char point)
-	      (if (> (length spec) 2)
-		  (insert ".")
-		(if (= (length spec) 2)
-		  (insert "@")))
-	      (gnus-picon-insert-glyph (pop spec) category))))))))
+	  (case gnus-picon-style
+	    (right
+	     (when (= (length addresses) 1)
+	       (setq len (apply '+ (mapcar (lambda (x)
+					     (condition-case nil
+						 (car (image-size (car x))) 
+					       (error 0))) spec)))
+	       (when (> len 0)
+		 (goto-char (point-at-eol))
+		 (insert (propertize 
+			  " " 'display
+			  (cons 'space (list :align-to (- (window-width) 1 len))))))
+	       (goto-char (point-at-eol))
+	       (setq point (point-at-eol))
+	       (dolist (image spec)
+		 (unless (stringp image)
+		   (goto-char point)
+		   (gnus-picon-insert-glyph image category)))))
+	    (inline
+	      (when (search-forward address nil t)
+		(delete-region (match-beginning 0) (match-end 0))
+		(setq point (point))
+		(while spec
+		  (goto-char point)
+		  (if (> (length spec) 2)
+		      (insert ".")
+		    (if (= (length spec) 2)
+			(insert "@")))
+		  (gnus-picon-insert-glyph (pop spec) category)))))
+	      )))))
 
 (defun gnus-picon-transform-newsgroups (header)
   (interactive)
@@ -224,16 +246,36 @@
 		      (cons (gnus-picon-create-glyph file)
 			    (nth i spec)))))
 	    (push (cons group spec) gnus-picon-cache))
-	(when (search-forward group nil t)
-	  (delete-region (match-beginning 0) (match-end 0))
-	  (save-restriction
-	    (narrow-to-region (point) (point))
-	    (while spec
-	      (goto-char (point-min))
-	      (if (> (length spec) 1)
-		  (insert "."))
-	      (gnus-picon-insert-glyph (pop spec) 'newsgroups-picon))
-	    (goto-char (point-max))))))))
+        (case gnus-picon-style
+          (right
+           (when (search-forward group nil t)
+             (setq len (apply '+ (mapcar (lambda (x)
+                                           (condition-case nil
+                                               (car (image-size (car x))) 
+                                             (error 0))) spec)))
+             (when (> len 0)
+               (goto-char (point-at-eol))
+               (insert (propertize 
+                        " " 'display
+                        (cons 'space (list :align-to (- (window-width) 1 len))))))
+             (goto-char (point-at-eol))
+             (setq point (point-at-eol))
+             (dolist (image spec)
+               (unless (stringp image)
+                 (goto-char point)
+                 (gnus-picon-insert-glyph image 'newsgroups-picon)))))
+          (inline
+            (when (search-forward group nil t)
+              (delete-region (match-beginning 0) (match-end 0))
+              (save-restriction
+                (narrow-to-region (point) (point))
+                (while spec
+                  (goto-char (point-min))
+                  (if (> (length spec) 1)
+                      (insert "."))
+                  (gnus-picon-insert-glyph (pop spec) 'newsgroups-picon))
+                (goto-char (point-max))))
+            ))))))
 
 ;;; Commands:
 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-03-27 12:14       ` Jochen Küpper
@ 2004-05-16 16:10         ` Lars Magne Ingebrigtsen
       [not found]           ` <m3wu3cbbf3.fsf-qBEgNjfYAPolG3ThADb//ti2O/JbrIOy@public.gmane.org>
  2004-05-18 12:21           ` Reiner Steib
  0 siblings, 2 replies; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2004-05-16 16:10 UTC (permalink / raw)


Jochen Küpper <jochen@fhi-berlin.mpg.de> writes:

> I added the analogous patch to gnus-picon-transform-newsgroups,
> complete diff against cvs HEAD attached.

Does it work in XEmacs, too?  If so, I'd like to apply it (if you
have paperwork on file...)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
       [not found]           ` <m3wu3cbbf3.fsf-qBEgNjfYAPolG3ThADb//ti2O/JbrIOy@public.gmane.org>
@ 2004-05-17 20:32             ` Jochen Küpper
  0 siblings, 0 replies; 16+ messages in thread
From: Jochen Küpper @ 2004-05-17 20:32 UTC (permalink / raw)


On Sun, 16 May 2004 18:10:24 +0200 Lars Magne Ingebrigtsen wrote:

Lars> Does it work in XEmacs, too? 

Dunno.

Moreover there were some issues with addresses of the form 
  account-ps1yJmh03mYq8ddH4TG6mw@public.gmane.org (The Name)
being recognized wrong by bbdb. I believe Reiner Steib send a patch to
the list (which I never got really worked out either).

Lars> If so, I'd like to apply it (if you have paperwork on file...)

If really necessary (really no new code from me, tribute goes to
Jesper and Reiner, I believe) I'm pretty sure I have filed papers for
all contributions, but for the heck of it cannot find any copy right
now... Moved to often lately, I guess;)

Greetings,
Jochen
-- 
Einigkeit und Recht und Freiheit                http://www.Jochen-Kuepper.de
    Liberté, Égalité, Fraternité                GnuPG key: CC1B0B4D
        (Part 3 you find in my messages before fall 2003.)




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-05-16 16:10         ` Lars Magne Ingebrigtsen
       [not found]           ` <m3wu3cbbf3.fsf-qBEgNjfYAPolG3ThADb//ti2O/JbrIOy@public.gmane.org>
@ 2004-05-18 12:21           ` Reiner Steib
       [not found]             ` <v98yfq2af4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
  2004-05-18 21:53             ` Jesper Harder
  1 sibling, 2 replies; 16+ messages in thread
From: Reiner Steib @ 2004-05-18 12:21 UTC (permalink / raw)


On Sun, May 16 2004, Lars Magne Ingebrigtsen wrote:

> Jochen Küpper <jochen@fhi-berlin.mpg.de> writes:
>
>> I added the analogous patch to gnus-picon-transform-newsgroups,
>> complete diff against cvs HEAD attached.
>
> Does it work in XEmacs, too?  

In Emacs, Jesper's code displays the From-Line as...

+----                                                             ---+
| From: [(X)Face] Some Name <user@domain.tld>             [Picon(s)] |
+----                                                             ---+

... when `gnus-picon-style' is 'right.  In XEmacs, we get...

+----                                                             ---+
| From: [(X)Face] Some Name <user@domain.tld>[Picon(s)]              |
+----                                                             ---+

... which is not so nice, but not too bad.  I've added "FIXME: `right'
needs improvement for XEmacs." to `gnus-picon-style'.  Maybe someone
using XEmacs can improve it.

On Mon, May 17 2004, Jochen Küpper wrote:

> On Sun, 16 May 2004 18:10:24 +0200 Lars Magne Ingebrigtsen wrote:
> Lars> If so, I'd like to apply it (if you have paperwork on file...)
>
> If really necessary (really no new code from me, tribute goes to
> Jesper and Reiner, I believe) I'm pretty sure I have filed papers for
> all contributions, but for the heck of it cannot find any copy right
> now... Moved to often lately, I guess;)

Could someone with access to the assignment list check this, please?

I've committed Jesper's my code without Jochen's changes to
`gnus-picon-transform-newsgroups'.  If the assignment is there, we can
apply it too.  Otherwise someone add the code to
`gnus-picon-transform-newsgroups' based on Jesper's change in
`gnus-picon-transform-address' easily.

> Moreover there were some issues with addresses of the form 
>   account@domain.tld (The Name)
> being recognized wrong by bbdb. I believe Reiner Steib send a patch to
> the list (which I never got really worked out either).

It was in <news:v9vfkiwl4f.fsf@marauder.physik.uni-ulm.de>.  The
problem was not the form of the address, but the fact that
`gnus-put-image' was called with non-nil STRING argument.  Instead of
"foo@bar.tld" bbdb got "foo@bar.tld tld" (the second tld was from the
tld-picon.  My change to `gnus-picon-insert-glyph' should fix this.
Jochen, could you check please?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
       [not found]             ` <v98yfq2af4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
@ 2004-05-18 21:49               ` Jochen Küpper
  2006-12-30 14:53                 ` Reiner Steib
  0 siblings, 1 reply; 16+ messages in thread
From: Jochen Küpper @ 2004-05-18 21:49 UTC (permalink / raw)


On Tue, 18 May 2004 14:21:19 +0200 Reiner Steib wrote:

Reiner> It was in <news:v9vfkiwl4f.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>.
Reiner> The problem was not the form of the address, but the fact that
Reiner> `gnus-put-image' was called with non-nil STRING argument.
Reiner> Instead of "foo-rXjzG7uALrI@public.gmane.org" bbdb got "foo-rXjzG7uALrI@public.gmane.org tld" (the
Reiner> second tld was from the tld-picon. My change to
Reiner> `gnus-picon-insert-glyph' should fix this. Jochen, could you
Reiner> check please?

Ok, absolutely correct;) With current cvs it works great for
mail-groups. (Tested on a few personal messages I had around and
ding-messages by Adam Sjøgren, who uses the email (name) style.

Jochen> I'm pretty sure I have filed papers for all contributions, but
Jochen> for the heck of it cannot find any copy right now...

Reiner> Could someone with access to the assignment list check this, please?

Could you please let *me* know what assignment I made as well? (Emacs,
Gnus, ...;) Thanks.

Greetings,
Jochen
-- 
Einigkeit und Recht und Freiheit                http://www.Jochen-Kuepper.de
    Liberté, Égalité, Fraternité                GnuPG key: CC1B0B4D
        (Part 3 you find in my messages before fall 2003.)




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-05-18 12:21           ` Reiner Steib
       [not found]             ` <v98yfq2af4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
@ 2004-05-18 21:53             ` Jesper Harder
  2004-05-18 22:07               ` Lars Magne Ingebrigtsen
  1 sibling, 1 reply; 16+ messages in thread
From: Jesper Harder @ 2004-05-18 21:53 UTC (permalink / raw)


Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:

> I've committed Jesper's my code without Jochen's changes to
> `gnus-picon-transform-newsgroups'.

BTW, does anyone here actually prefer the old inline style?

If not maybe we could avoid adding yet another option,
`gnus-picon-style', and always use the Gmane style.

-- 
Jesper Harder                                <http://purl.org/harder/>



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-05-18 21:53             ` Jesper Harder
@ 2004-05-18 22:07               ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 16+ messages in thread
From: Lars Magne Ingebrigtsen @ 2004-05-18 22:07 UTC (permalink / raw)


Jesper Harder <harder@ifa.au.dk> writes:

> BTW, does anyone here actually prefer the old inline style?

Mee!  Mee!

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: display picons _and_ textual address
  2004-05-18 21:49               ` Jochen Küpper
@ 2006-12-30 14:53                 ` Reiner Steib
  0 siblings, 0 replies; 16+ messages in thread
From: Reiner Steib @ 2006-12-30 14:53 UTC (permalink / raw)
  Cc: Jochen Küpper

On Tue, May 18 2004, Jochen Küpper wrote:

> On Tue, 18 May 2004 14:21:19 +0200 Reiner Steib wrote:
[...]
> Jochen> I'm pretty sure I have filed papers for all contributions, but
> Jochen> for the heck of it cannot find any copy right now...
>
> Reiner> Could someone with access to the assignment list check this, please?
>
> Could you please let *me* know what assignment I made as well? (Emacs,
> Gnus, ...;) Thanks.

You have assignments on file for both, Emacs and Gnus (though Emacs
would be sufficient because it covers Gnus as well).

Jochen, it seem your patch for newsgroup picons has not been applied
yet.  Could you please send a patch against the current code in the
trunk?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2006-12-30 14:53 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-02 15:30 display picons _and_ textual address Reiner Steib
2004-03-02 18:05 ` Wes Hardaker
2004-03-02 19:57   ` Reiner Steib
2004-03-02 20:30     ` Wes Hardaker
2004-03-04 21:17       ` Jesper Harder
2004-03-04 22:05         ` Wes Hardaker
2004-03-25  2:05 ` Jesper Harder
2004-03-25 13:21   ` Reiner Steib
     [not found]     ` <v97jx912q4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
2004-03-27 12:14       ` Jochen Küpper
2004-05-16 16:10         ` Lars Magne Ingebrigtsen
     [not found]           ` <m3wu3cbbf3.fsf-qBEgNjfYAPolG3ThADb//ti2O/JbrIOy@public.gmane.org>
2004-05-17 20:32             ` Jochen Küpper
2004-05-18 12:21           ` Reiner Steib
     [not found]             ` <v98yfq2af4.fsf-WZbs9ZYJ0ya4nSHvGpykACzlmkwuQ7VwhC4ANOJQIlc@public.gmane.org>
2004-05-18 21:49               ` Jochen Küpper
2006-12-30 14:53                 ` Reiner Steib
2004-05-18 21:53             ` Jesper Harder
2004-05-18 22:07               ` Lars Magne Ingebrigtsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).