Re: A lot of questions concerning `gnus-score-edit-file-at-point'

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Mon, Dec 29 2003, Karl Pflästerer wrote:

> That raises another question: is the `(setq truncate-lines t)' really
> necessary?  I don't see a reason and I don't like it at all.

Maybe `truncate-lines' has been used because most of the time people
are more interested in the rule than in the file name.  I also use
<end> quite often in this buffer to see the filename.  Most of the
time I only see the directory.

But we can make the *Score Trace* buffer more readable with
`truncate-lines': We can use `abbreviate-file-name' on the full file
name and also print the file name (without directory and extension).
It could look like this:

("@my-fqdn>$" 10000 nil r) [my-posts] ->  ~/News/score/topics/my-posts.SCORE

Instead of "[", "]" and " -> ", we can use other delimiters: Whatever
fits well in the new `gnus-score-edit-file-at-point' code and is more
or clear for the user.

Additionally, I'd like to add some kind of "Quick help", telling the
user about useful key bindings in that buffer (and maybe explain the
output lines above).  See the patch below[1].  Opinions?

> (defun gnus-score-edit-file-at-point ()
>   "Edit score file at point.  Useful especially after `V t'."
[...]
>     (if (or (string-match "non-file" file) (not file) (string= "" file))

Shouldn't this read...

      (if (or (not file) (string-match "non-file" file) (string= "" file))

If file is nil, `string-match' will error out otherwise.

Bye, Reiner.


--8<---------------cut here---------------start------------->8---
--- gnus-score.el	22 Dec 2003 11:39:05 -0000	6.38
+++ gnus-score.el	29 Dec 2003 20:54:48 -0000
@@ -2354,7 +2365,8 @@
     (let ((gnus-newsgroup-headers
 	   (list (gnus-summary-article-header)))
 	  (gnus-newsgroup-scored nil)
-	  trace)
+	  trace
+	  file)
       (save-excursion
 	(nnheader-set-temp-buffer "*Score Trace*"))
       (setq gnus-score-trace nil)
@@ -2370,12 +2382,26 @@
 			 (interactive)
 			 (bury-buffer nil)
 			 (gnus-summary-expand-window)))
-	(local-set-key "e" 'gnus-score-edit-file-at-point)
+	(local-set-key "e" (lambda ()
+			     "Run `gnus-score-edit-file-at-point'."
+			     (interactive)
+			     (gnus-score-edit-file-at-point)))
 	(setq truncate-lines t)
 	(while trace
-	  (insert (format "%S  ->  %s\n" (cdar trace)
-			  (or (caar trace) "(non-file rule)")))
+	  (setq file (or (caar trace)
+			 "(non-file rule)"))
+	  (insert (format "%S [%s] -> %s\n"
+			  ;; sync with `gnus-score-edit-file-at-point'
+			  (cdar trace)
+			  (file-name-sans-extension
+			   (file-name-nondirectory file))
+			  (abbreviate-file-name file)))
 	  (setq trace (cdr trace)))
+	(insert
+	 "\n\nQuick help:
+
+  q - quit
+  e - edit score file entry")
 	(goto-char (point-min))
 	(gnus-configure-windows 'score-trace)))
     (set-buffer gnus-summary-buffer)
--8<---------------cut here---------------end--------------->8---
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/