Re: [patch] More buttons for emacs stuff, MIDs, mail addresses

[Reiner Steib <4uce.02.r.steib@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

On Fri, Sep 20 2002, Kai Großjohann wrote:

> Committed.  (Including the fix in the second message.)

On Mon, Sep 23 2002, Simon Josefsson wrote:

[ ... in gnus.test: <iluofaoab2o.fsf@latte.josefsson.org> ]

> False positive button:
>
> [...]  to=<anagula@globespan.net>, [...]
         ^^^^^^^^^^^^^^^^^^^^^^^^^^ this is/was buttonized

I already had fixed this kind of false positives in my copy. Did you
encounters more false positives or other problems?

There are also wrong buttons for man pages like this:

  send-pr(1)       --> pr
  ssh-keyscan(1)   --> keyscan

This patch should fix the above mentions problems:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix for man buttons --]
[-- Type: text/x-patch, Size: 2310 bytes --]

Index: gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 6.238
diff -u -w -r6.238 gnus-art.el
--- gnus-art.el	2002/09/20 16:40:28	6.238
+++ gnus-art.el	2002/09/23 18:47:53
@@ -5291,8 +5291,9 @@
 		 (const mail)))
 
 (defcustom gnus-button-guessed-mid-regexp
-  (concat "^<?\\(slrn\\|Pine\\)\\."
-	  "\\|\\.fsf@\\|@4ax\\.com\\|@ID-[0-9]+\\.[a-zA-Z]+\\.dfncis\\.de"
+  (concat
+   "^<?\\(slrn\\|Pine\\.\\)"
+   "\\|\\.fsf@\\|\\.ln@\\|@4ax\\.com\\|@ID-[0-9]+\\.[a-zA-Z]+\\.dfncis\\.de"
 	  "\\|^<?.*[0-9].*[0-9].*[0-9].*[0-9].*[0-9].*[0-9].*@")
   "Regular expression that matches message IDs and not mail addresses."
   ;; TODO: Incorporate more matches from
@@ -5430,11 +5431,13 @@
     ;; Raw URLs.
     (gnus-button-url-regexp 0 t browse-url 0)
     ;; man pages
-    ("\\b\\([a-z][a-z]+\\)([0-9])\\W" 0 (>= gnus-button-man-level 1)
+    ("\\b\\([a-z][a-z]+\\)([0-9])\\W" 0
+     (and (>= gnus-button-man-level 1) (< gnus-button-man-level 3))
      gnus-button-handle-man 1)
     ;; more man pages: resolv.conf(5), iso_8859-1(7), xterm(1x)
-    ("\\b\\([a-zA-Z][-_.a-zA-Z0-9]+\\)([0-9]x?)\\W" 0
-     (>= gnus-button-man-level 3) gnus-button-handle-man 3)
+    ("\\b\\([a-zA-Z][-_.a-zA-Z0-9]+\\)([0-9])\\W" 0
+     (and (>= gnus-button-man-level 3) (< gnus-button-man-level 5))
+     gnus-button-handle-man 1)
     ;; even more: Apache::PerlRun(3pm), PDL::IO::FastRaw(3pm), SoWWWAnchor(3iv)
     ("\\b\\([a-zA-Z][-_.:a-zA-Z0-9]+\\)([0-9][a-z]*)\\W" 0
      (>= gnus-button-man-level 5) gnus-button-handle-man 1)
@@ -5443,7 +5446,7 @@
     ;; at least one dot.  TLD must contain two or three chars or be a know TLD
     ;; (info|name|...).  Put this entry near the _end_ of `gnus-button-alist'
     ;; so that non-ambiguous entries (see above) match first.
-    ("\\b\\(<?[a-zA-Z0-9][^>)!;:,{}\n\t ]*@[a-zA-Z0-9][-.a-zA-Z0-9]+\\.\\([a-zA-Z][a-zA-Z]\\([a-zA-Z]\\)?\\|[Ii][Nn][Ff][Oo]\\|[Nn][Aa][Mm][Ee]\\)>?\\)\\b"
+    ("\\b\\(<?[a-zA-Z0-9][^<>\")!;:,{}\n\t ]*@[a-zA-Z0-9][-.a-zA-Z0-9]+\\.\\([a-zA-Z][a-zA-Z]\\([a-zA-Z]\\)?\\|[Ii][Nn][Ff][Oo]\\|[Nn][Aa][Mm][Ee]\\)>?\\)\\b"
      0 (>= gnus-button-mail-level 5) gnus-button-handle-mid-or-mail 1))
   "*Alist of regexps matching buttons in article bodies.
 

[-- Attachment #3: Type: text/plain, Size: 343 bytes --]


Suggested ChangeLog entry:

	* gnus-art.el (gnus-button-guessed-mid-regexp): Improved regexp.
	(gnus-button-alist): Improved regexp for
	gnus-button-handle-mid-or-mail (false positives), fixed
	gnus-button-handle-man entries.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/