Re: User reserved keybindings in `gnus-diary.el'

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Apr 14 2008, Didier Verna wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>> On Sat, Mar 29 2008, paul r wrote:
>>> Those modifications concern some default key bindings on your mode
>>> map, bound on the C-c[a-zA-Z] pattern, which is supposed to be
>>> reserved for users
>
>    FWIW, when I designed the nndiary backend, I split functionality
> between core features and convenience stuff, in respectively nndiary.el
> and gnus-diary.el. Technically, gnus-diary is not needed to use nndiary,
> so I though of it as a user-level layer, hence the choice of a C-c
> prefix. I'm not strongly opposed to changing that though.

`C-c' followed by a letter (upper or lower case) are reserved for
users in Emacs (IIRC, Stephen J. Turnbull confirmed that also for
XEmacs), so we *must not* use these bindings in Gnus.

>> `gnus-diary.el' uses `C-c D' as a prefix key:
>>
>> (define-key message-mode-map "\C-cDc" 'gnus-diary-check-message)
>> (define-key message-mode-map "\C-cDv" 'gnus-diary-version)
>> (define-key gnus-article-edit-mode-map "\C-cDc" 'gnus-diary-check-message)
>> (define-key gnus-article-edit-mode-map "\C-cDv" 'gnus-diary-version)
>>
>> Do we really need a key binding for `gnus-diary-version'?
>
>   We does this binding bother you (I mean, apart from the C-c part) ? 

Only `C-c letter' bothers me.  But I don't think displaying the
version (of Emacs, Gnus, gnus-diary, ...) is such a frequently used
command that needs a key binding in the first place.

> If that's because there are only two key bindings right now, so you
> would like to remove the prefix altogether and just bind g-d-c-m
> somewhere else, then I'm opposed to this change. I want to keep a
> whole prefix for gnus-diary, so that I don't interfere or risk a
> conflict with another library in the future.

On Mon, Apr 14 2008, Didier Verna wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>> I removed the bindings for `gnus-diary-version' (in v5-10 because
>> binding user reserved is clearly a bug, IMHO; trunk will follow
>> later).
>
>   Grrrr.

Well, how long do you expect me to wait for any reply?

>> We need to find new a keybinding for `gnus-diary-check-message'. We
>> could use `C-c C-f d'. `C-c C-f' because it's the usual prefix for
>> header commands and `d' for "diary". Other suggestion? Didier? I've
>> installed this as well, but we may change it if someone has a better
>> suggestion.
>
>   Like I said in my previous post (sorry for the delay answering this
> thread), I'd like to keep a whole prefix for nndiary stuff. Would C-c
> C-D (a capital D) be acceptable ?

It's acceptable (since it doesn't clash with the user-reserved
bindings).  I'm not sure if `C-c C-D' is distinguishable from `C-c
C-d' on (some) consoles.  Personally, I'd find e.g. `C-c C-f d c' much
easier to type than `C-c C-D ...' = `C-c C-S-d c'.  The prefix `C-c
M-d' is also free and easier to type than `C-c C-S-d'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/