From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66820 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: User reserved keybindings in `gnus-diary.el' Date: Mon, 14 Apr 2008 22:20:51 +0200 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208204765 2784 80.91.229.12 (14 Apr 2008 20:26:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Apr 2008 20:26:05 +0000 (UTC) Cc: ding@gnus.org To: Didier Verna Original-X-From: ding-owner+M15302@lists.math.uh.edu Mon Apr 14 22:26:19 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1JlVDE-0005Zx-VL for ding-account@gmane.org; Mon, 14 Apr 2008 22:23:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1JlVB2-0004P1-Hp; Mon, 14 Apr 2008 15:21:20 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1JlVB1-0004On-44 for ding@lists.math.uh.edu; Mon, 14 Apr 2008 15:21:19 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1JlVAu-0007Kh-Fr for ding@lists.math.uh.edu; Mon, 14 Apr 2008 15:21:19 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1JlVB4-0004H2-00 for ; Mon, 14 Apr 2008 22:21:22 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m3EKL9S7018953; Mon, 14 Apr 2008 22:21:10 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 41BD813036; Mon, 14 Apr 2008 22:21:09 +0200 (CEST) X-Face: P05mdcZT&lL[-s2=mw~RsllZ0zZAb?vdE}.s, ding@gnus.org In-Reply-To: (Didier Verna's message of "Mon, 14 Apr 2008 10:37:02 +0200") User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2.50 (gnu/linux) X-DCC-Misty-Metrics: poseidon 1170; Body=2 Fuz1=2 Fuz2=2 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66820 Archived-At: On Mon, Apr 14 2008, Didier Verna wrote: > Reiner Steib wrote: >> On Sat, Mar 29 2008, paul r wrote: >>> Those modifications concern some default key bindings on your mode >>> map, bound on the C-c[a-zA-Z] pattern, which is supposed to be >>> reserved for users > > FWIW, when I designed the nndiary backend, I split functionality > between core features and convenience stuff, in respectively nndiary.el > and gnus-diary.el. Technically, gnus-diary is not needed to use nndiary, > so I though of it as a user-level layer, hence the choice of a C-c > prefix. I'm not strongly opposed to changing that though. `C-c' followed by a letter (upper or lower case) are reserved for users in Emacs (IIRC, Stephen J. Turnbull confirmed that also for XEmacs), so we *must not* use these bindings in Gnus. >> `gnus-diary.el' uses `C-c D' as a prefix key: >> >> (define-key message-mode-map "\C-cDc" 'gnus-diary-check-message) >> (define-key message-mode-map "\C-cDv" 'gnus-diary-version) >> (define-key gnus-article-edit-mode-map "\C-cDc" 'gnus-diary-check-message) >> (define-key gnus-article-edit-mode-map "\C-cDv" 'gnus-diary-version) >> >> Do we really need a key binding for `gnus-diary-version'? > > We does this binding bother you (I mean, apart from the C-c part) ? Only `C-c letter' bothers me. But I don't think displaying the version (of Emacs, Gnus, gnus-diary, ...) is such a frequently used command that needs a key binding in the first place. > If that's because there are only two key bindings right now, so you > would like to remove the prefix altogether and just bind g-d-c-m > somewhere else, then I'm opposed to this change. I want to keep a > whole prefix for gnus-diary, so that I don't interfere or risk a > conflict with another library in the future. On Mon, Apr 14 2008, Didier Verna wrote: > Reiner Steib wrote: >> I removed the bindings for `gnus-diary-version' (in v5-10 because >> binding user reserved is clearly a bug, IMHO; trunk will follow >> later). > > Grrrr. Well, how long do you expect me to wait for any reply? >> We need to find new a keybinding for `gnus-diary-check-message'. We >> could use `C-c C-f d'. `C-c C-f' because it's the usual prefix for >> header commands and `d' for "diary". Other suggestion? Didier? I've >> installed this as well, but we may change it if someone has a better >> suggestion. > > Like I said in my previous post (sorry for the delay answering this > thread), I'd like to keep a whole prefix for nndiary stuff. Would C-c > C-D (a capital D) be acceptable ? It's acceptable (since it doesn't clash with the user-reserved bindings). I'm not sure if `C-c C-D' is distinguishable from `C-c C-d' on (some) consoles. Personally, I'd find e.g. `C-c C-f d c' much easier to type than `C-c C-D ...' = `C-c C-S-d c'. The prefix `C-c M-d' is also free and easier to type than `C-c C-S-d'. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/