gnus-replace-in-string: Avoid inf-loop in XEmacs (was: New completion mode)

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Apr 17 2006, Steve Youngs wrote:

[ from <news:microsoft-free.87y7y5uk1k.fsf@youngs.au.com> ]

> * Reiner Steib <reinersteib+gmane@imap.cc> writes:
[...]
>   > - In `message-put-addresses-in-ecomplete' you should use
>   >   `gnus-replace-in-string' instead of `replace-regexp-in-string' for
>   >   compatibility with XEmacs.
>
> Only needed for XEmacs 21.4.  XEmacs 21.5 and SXEmacs has
> `replace-regexp-in-string'. 

Is it just a wrapper around `replace-in-string' or is it Emacs
implementation of `replace-regexp-in-string'?  Hm...

,----
| ELISP> emacs-version
| "21.5  (beta21) \"corn\" (+CVS-20050720) XEmacs Lucid"
| ELISP> (replace-regexp-in-string "/*$" "/" "foo")
| "foo/"
| ELISP> (replace-in-string "foo" "/*$" "/")
| *** Eval error ***  Quit during evaluation   (inf-loop -> C-g)
`----

We should change `gnus-replace-in-string' as follows, I think:

--8<---------------cut here---------------start------------->8---
--- gnus-util.el	20 Apr 2006 12:10:00 +0200	6.104.2.24
+++ gnus-util.el	20 Apr 2006 14:52:55 +0200	
@@ -61,8 +61,6 @@
 
 (eval-and-compile
   (cond
-   ((fboundp 'replace-in-string)
-    (defalias 'gnus-replace-in-string 'replace-in-string))
    ((fboundp 'replace-regexp-in-string)
     (defun gnus-replace-in-string (string regexp newtext &optional literal)
       "Replace all matches for REGEXP with NEWTEXT in STRING.
@@ -71,6 +69,8 @@
 
 This is a compatibility function for different Emacsen."
       (replace-regexp-in-string regexp newtext string nil literal)))
+   ((fboundp 'replace-in-string)
+    (defalias 'gnus-replace-in-string 'replace-in-string))
    (t
     (defun gnus-replace-in-string (string regexp newtext &optional literal)
       "Replace all matches for REGEXP with NEWTEXT in STRING.
--8<---------------cut here---------------end--------------->8---

On Thu, Apr 20 2006, Steve Youngs wrote:

> * Katsumi Yamaoka <yamaoka@jpl.org> writes:
[...]
>   > The regexp used in `message-put-addresses-in-ecomplete' causes
>   > an infloop in XEmacs.  The test case is:
>
>   >    (gnus-replace-in-string "yamaoka@jpl.org" "^ +\\| *$" "")
>
>   > It might be due to an XEmacs bug.

It's a bug in XEmacs, see
<http://thread.gmane.org/gmane.emacs.xemacs.beta/16592/focus=16603>.

>   > Though it seems to be solved by replacing the regexp with "^
>   > +\\| +$".
>
> This fixed the problem I was seeing in SXEmacs too.

Does shifting down "((fboundp 'replace-in-string) ...)" solve this
problem too?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/