Re: message-remove-duplicates and gnus-remove-duplicates

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Oct 04 2005, Simon Josefsson wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>>> (if (fboundp 'define-obsolete-function-alias)
>>>>     (define-obsolete-function-alias
>>>>       'gnus-remove-duplicates 'mm-delete-duplicates
>>>>       "22.1");; Gnus 5.10.7 / Gnus 5.11 / No Gnus
>>>>   (defalias 'gnus-remove-duplicates 'mm-delete-duplicates)
>>>>   (make-obsolete 'gnus-remove-duplicates 'mm-delete-duplicates "22.1"))
[...]
>> Emacs 21 doesn't have it, so we need the fall back code even in No
>> Gnus.  Given that, I think it's best to have the same code in trunk
>> and v5-10.
>
> Ok, you convinced me.

I installed the changes[1] in v5-10 and in the trunk.  I didn't add an
alias, because (1) I don't think `gnus-remove-duplicates' has ever
been used outside of Gnus (no XEmacs Sumo package uses it; a Google
search didn't reveal anything) and (2) the above code didn't work form
me: When byte-compiling Gnus with Emacs 21 running the byte-compiled
program in Emacs 22 doesn't work[2].  Normally Emacs 21 byte-code
should run in Emacs 22 (CMIIW) so maybe I'm doing something wrong.  If
anyone wants to add an alias without introducing this problem, feel
free add it.  We could simply add the defalias/make-obsolete, but I
don't think it's useful, see (1).

Bye, Reiner.

[1] 	* gnus-util.el (gnus-remove-duplicates): Remove.

	* nnmail.el (nnmail-article-group): Use mm-delete-duplicates
	instead of gnus-remove-duplicates.

	* message.el (message-remove-duplicates): Remove.
	(message-idna-to-ascii-rhs-1): Use mm-delete-duplicates instead of
	message-remove-duplicates.

	* mm-util.el (mm-delete-duplicates): Use `delete-dups' if
	available, else use implementation from `delete-dups'.

[2] $ emacs-cvs -Q -f toggle-debug-on-error -l ./lisp/gnus-util.elc

Debugger entered--Lisp error: (invalid-function (macro .
  #[(obsolete-name current-name &optional when docstring) "[...]"
  [obsolete-name current-name docstring when progn defalias
  make-obsolete] 6 617511]))
  define-obsolete-function-alias(gnus-remove-duplicates
  mm-delete-duplicates "22.1")
  byte-code("[...]" [fboundp set-process-query-on-exit-flag defalias
  gnus-set-process-query-on-exit-flag process-kill-without-query
  define-obsolete-function-alias gnus-remove-duplicates
  mm-delete-duplicates "22.1" make-obsolete provide gnus-util] 4)
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/