From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61089 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: message-remove-duplicates and gnus-remove-duplicates Date: Tue, 04 Oct 2005 17:50:37 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1128441876 22415 80.91.229.2 (4 Oct 2005 16:04:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 4 Oct 2005 16:04:36 +0000 (UTC) Original-X-From: ding-owner+m9621@lists.math.uh.edu Tue Oct 04 18:04:33 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EMpF5-0003We-FC for ding-account@gmane.org; Tue, 04 Oct 2005 18:02:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EMpEt-0004N4-00; Tue, 04 Oct 2005 11:01:59 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1EMp9l-0004My-00 for ding@lists.math.uh.edu; Tue, 04 Oct 2005 10:56:41 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1EMp9e-0004DW-SX for ding@lists.math.uh.edu; Tue, 04 Oct 2005 10:56:41 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EMp9c-0002BI-00 for ; Tue, 04 Oct 2005 17:56:32 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EMp7P-00012Z-De for ding@gnus.org; Tue, 04 Oct 2005 17:54:15 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Oct 2005 17:54:15 +0200 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Oct 2005 17:54:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 57 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Copies-To: nobody User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:Fp9mxYGLIFXMaFbEJRA3vky90vo= X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61089 Archived-At: On Tue, Oct 04 2005, Simon Josefsson wrote: > Reiner Steib writes: >>>> (if (fboundp 'define-obsolete-function-alias) >>>> (define-obsolete-function-alias >>>> 'gnus-remove-duplicates 'mm-delete-duplicates >>>> "22.1");; Gnus 5.10.7 / Gnus 5.11 / No Gnus >>>> (defalias 'gnus-remove-duplicates 'mm-delete-duplicates) >>>> (make-obsolete 'gnus-remove-duplicates 'mm-delete-duplicates "22.1")) [...] >> Emacs 21 doesn't have it, so we need the fall back code even in No >> Gnus. Given that, I think it's best to have the same code in trunk >> and v5-10. > > Ok, you convinced me. I installed the changes[1] in v5-10 and in the trunk. I didn't add an alias, because (1) I don't think `gnus-remove-duplicates' has ever been used outside of Gnus (no XEmacs Sumo package uses it; a Google search didn't reveal anything) and (2) the above code didn't work form me: When byte-compiling Gnus with Emacs 21 running the byte-compiled program in Emacs 22 doesn't work[2]. Normally Emacs 21 byte-code should run in Emacs 22 (CMIIW) so maybe I'm doing something wrong. If anyone wants to add an alias without introducing this problem, feel free add it. We could simply add the defalias/make-obsolete, but I don't think it's useful, see (1). Bye, Reiner. [1] * gnus-util.el (gnus-remove-duplicates): Remove. * nnmail.el (nnmail-article-group): Use mm-delete-duplicates instead of gnus-remove-duplicates. * message.el (message-remove-duplicates): Remove. (message-idna-to-ascii-rhs-1): Use mm-delete-duplicates instead of message-remove-duplicates. * mm-util.el (mm-delete-duplicates): Use `delete-dups' if available, else use implementation from `delete-dups'. [2] $ emacs-cvs -Q -f toggle-debug-on-error -l ./lisp/gnus-util.elc Debugger entered--Lisp error: (invalid-function (macro . #[(obsolete-name current-name &optional when docstring) "[...]" [obsolete-name current-name docstring when progn defalias make-obsolete] 6 617511])) define-obsolete-function-alias(gnus-remove-duplicates mm-delete-duplicates "22.1") byte-code("[...]" [fboundp set-process-query-on-exit-flag defalias gnus-set-process-query-on-exit-flag process-kill-without-query define-obsolete-function-alias gnus-remove-duplicates mm-delete-duplicates "22.1" make-obsolete provide gnus-util] 4) -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/