Re: Using versions instead of XEmacs codenames in User-Agent

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Jan 10 2005, Steve Youngs wrote:

>   > Is a quoted string like "Aston Martin" allowed in RFC 2616?  
[...]
> Yep, however, IMHO, this...
>
>   SXEmacs/22.1.1 (Aston Martin, berkeley-unix)
>
> doesn't look anywhere near as nice as...
>
>   SXEmacs/22.1.1 "Aston Martin" (berkeley-unix)
>
> :-)

I think we should use the former variant unless there are good reasons
not to do so, as Bjørn already pointed out.

[...]
> Cool.  Can we make the default on (S)XEmacs to include the codename?
> Just to keep as close as possible to current settings.

My intention was to _change_ the default settings.  ;-)
See the subject of this thread.  Maybe that wasn't clear enough in my
previous articles.  The default User-Agent header line should be no
more than 80 chars, IMO.

I have committed the default w/o codename to the trunk.  If you or
anyone strongly wants to include the codename by default, feel free to
change it. :-)

>   > +     ((or (featurep 'sxemacs) (featurep 'xemacs))
> You could write this as:
>   ((featurep '(or sxemacs xemacs))
>
> But I'm not sure how GNU/Emacs would cope with that.  

Emacs would signal an error.

> In this instance it probably shouldn't matter because GNU/Emacs
> wouldn't get to this part of the code.

Yes.  But at least for me my suggestion is more clear.

> Other than that, I think your patch is great!  And works well.

I have improved the conversion code to automatically convert
customized values:

--8<---------------cut here---------------start------------->8---
(defcustom gnus-user-agent '(emacs gnus type)
  ...)

;; Convert old (< 2005-01-10) symbol type values:
(when (symbolp gnus-user-agent)
  (setq gnus-user-agent
	(cond ((eq gnus-user-agent 'emacs-gnus-config)
	       '(emacs gnus config))
	      ((eq gnus-user-agent 'emacs-gnus-type)
	       '(emacs gnus type))
	      ((eq gnus-user-agent 'emacs-gnus)
	       '(emacs gnus))
	      ((eq gnus-user-agent 'gnus)
	       '(gnus))
	      (t gnus-user-agent)))
  (gnus-message 1 "Converted `gnus-user-agent' to `%s'." gnus-user-agent)
  (sit-for 1)
  (if (get 'gnus-user-agent 'saved-value)
      (customize-save-variable 'gnus-user-agent gnus-user-agent)
    (gnus-message 1 "Edit your init file to make this change permanent.")
    (sit-for 2)))
--8<---------------cut here---------------end--------------->8---

But if the user loads first gnus.elc and then does
  (setq gnus-user-agent 'emacs-gnus)
it will fail.  Ideas?

But I doubt that many people have done this.  `gnus-user-agent' is
quite new and most people use the default value, AFAICS.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/