Re: gnus-url-mailto broken on foo+bar@somewhere.invalid

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Tue, Aug 26 2003, Karl Pflästerer wrote:

>     ;; Fixme: Do it like QP.
>     (defun gnus-url-unhex-string (str &optional allow-newlines)
>       "Remove %XX, embedded spaces, etc in a url.
>     If optional second argument ALLOW-NEWLINES is non-nil, then allow the
>     decoding of carriage returns and line feeds in the string, which is normally
>     forbidden in URL encoding."

JFTR: Beside in `gnus-url-mailto' and in `gnus-url-parse-query-string'
(that is only used in `gnus-url-mailto'), `gnus-url-unhex-string' is
only used for info and customize URLs.  It's never used for http URLs.
Ah, there's one occurance in `nnwfm.el'[2], which is not mentioned in
the manual.

>       (setq str (or (mm-subst-char-in-string ?+ ?  str) "")) ; why `or'?
>
> Two questions?
> (a) What's meant with the comment?

ShengHuo[1] changed the line like this:

-  (setq str (or str ""))
+  (setq str (or (mm-subst-char-in-string ?+ ?  str) ""))

Wild guess: No error if `str' is nil?  The comment was added later; I
couldn't find a ChangeLog entry for it.

> (b) What is the substitution good for?

The reason AFAICS are info URLs like <info://gnus/Starting+Up>.  It
has been introduced along with this ChangeLog entry (see patch
below[1]):

,----[ 1 ]
| 2001-08-17 22:00:00  ShengHuo ZHU  <zsh@cs.rochester.edu>
| 
| 	* gnus.el (gnus-info-find-node): Take an argument.
| 
| 	* gnus-art.el (gnus-button-handle-info): New function.
| 	(gnus-url-unhex-string): Replace "+" with " ".
`----

Bye, Reiner.

[1]
--8<---------------cut here---------------start------------->8---
--- gnus-art.el.~6.103~	Tue Aug 26 21:12:16 2003
+++ gnus-art.el.~6.104~	Tue Aug 26 21:07:59 2003
@@ -4697,7 +4697,7 @@
 
 ;;; Internal Variables:
 
-(defcustom gnus-button-url-regexp "[...]mailto\\):[...]"
+(defcustom gnus-button-url-regexp "[...]mailto\\|info\\):[...]"
   "Regular expression that matches URLs."
   :group 'gnus-article-buttons
   :type 'regexp)
@@ -4716,6 +4716,9 @@
     ("\\(<URL: *\\)mailto: *\\([^> \n\t]+\\)>" 0 t gnus-url-mailto 2)
     ("mailto:\\([-a-zA-Z.@_+0-9%=?]+\\)" 0 t gnus-url-mailto 1)
     ("\\bmailto:\\([^ \n\t]+\\)" 0 t gnus-url-mailto 1)
+    ;; This is info
+    ("\\binfo:\\(//\\)?\\([^'\">\n\t ]+\\)" 0 t
+     gnus-button-handle-info 2)
     ;; This is how URLs _should_ be embedded in text...
     ("<URL: *\\([^<>]*\\)>" 0 t gnus-button-embedded-url 1)
     ;; Raw URLs.
@@ -5086,6 +5089,18 @@
      (group
       (gnus-button-fetch-group url)))))
 
+(defun gnus-button-handle-info (url)
+  "Fetch an info URL."
+  (if (string-match 
+       "^\\([^:/]+\\)?/\\(.*\\)"
+       url)
+      (gnus-info-find-node
+       (concat "(" (or (gnus-url-unhex-string (match-string 1 url))
+		       "Gnus") 
+	       ")" 
+	       (gnus-url-unhex-string (match-string 2 url))))
+    (error "Can't parse %s" url)))
+
 (defun gnus-button-message-id (message-id)
   "Fetch MESSAGE-ID."
   (save-excursion
@@ -5142,7 +5157,7 @@
 If optional second argument ALLOW-NEWLINES is non-nil, then allow the
 decoding of carriage returns and line feeds in the string, which is normally
 forbidden in URL encoding."
-  (setq str (or str ""))
+  (setq str (or (mm-subst-char-in-string ?+ ?  str) ""))
   (let ((tmp "")
 	(case-fold-search t))
     (while (string-match "%[0-9a-f][0-9a-f]" str)
--8<---------------cut here---------------end--------------->8---

[2] ;;; nnwfm.el --- interfacing with a web forum
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/