Set temp files (viewing attachments) read-only?

Set temp files (viewing attachments) read-only?

[Reiner Steib]

Hi,

when a user views an attachment, modifies and saves it with the helper
application (say OpenOffice), after quitting the helper application
Gnus deletes the temp file.  I.e. all modifications made by the user
are lost. (Similar to Mozilla: [1])

Setting the temp file read-only[2] should make it clear, that editing
it might be a bad idea.  It also forces the user to choose a different
file name or location when saving.  What do you think?

--8<---------------cut here---------------start------------->8---
--- mm-decode.el	02 Mar 2008 18:05:57 +0100	7.64
+++ mm-decode.el	05 Apr 2008 13:31:01 +0200	
@@ -815,6 +815,10 @@
 					    nil suffix))))
 	  (let ((coding-system-for-write mm-binary-coding-system))
 	    (write-region (point-min) (point-max) file nil 'nomesg))
+	  ;; The file is deleted after the viewer exists.  If the users edits
+	  ;; the file, changes will be lost.  Set file to read-only to make it
+	  ;; clear.
+	  (set-file-modes file (string-to-number "400" 8))
 	  (message "Viewing with %s" method)
 	  (cond
 	   (needsterm
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.

[1] This is currently discussed in a German-language Mozilla newsgroup:
    <news12f4e$47f4f7ee$3e63fcfd$26586@news.inode.at> ff
    <https://bugzilla.mozilla.org/show_bug.cgi?id=191239#c0>
[2] <https://bugzilla.mozilla.org/show_bug.cgi?id=191239#c13>
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Set temp files (viewing attachments) read-only?

[Daniel Pittman]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> when a user views an attachment, modifies and saves it with the helper
> application (say OpenOffice), after quitting the helper application
> Gnus deletes the temp file.  I.e. all modifications made by the user
> are lost. (Similar to Mozilla: [1])
>
> Setting the temp file read-only[2] should make it clear, that editing
> it might be a bad idea.  It also forces the user to choose a different
> file name or location when saving.  What do you think?

I think that this would be a good idea.

Regards,
        Daniel

Re: Set temp files (viewing attachments) read-only?

[Katsumi Yamaoka]

>>>>> Daniel Pittman wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> Setting the temp file read-only[2] should make it clear, that editing
>> it might be a bad idea.  It also forces the user to choose a different
>> file name or location when saving.  What do you think?

> I think that this would be a good idea.

I think that's good, too.

BTW, do you know that performing `gnus-mime-copy-part' on the pdf
part automatically launches the `doc-view-mode'?  I.e., the pdf
file is viewed in an Emacs buffer.  I think it would also be nice
if the `doc-view-mode' supports not only pdf/ps/dvi files but also
the types that OpenOffice supports. ;-)

Regards,

Re: Set temp files (viewing attachments) read-only?

[Magnus Henoch]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> +	  (set-file-modes file (string-to-number "400" 8))

I propose #o400 instead of string-to-number :)

Magnus

Re: Set temp files (viewing attachments) read-only?

[Reiner Steib]

On Tue, Apr 08 2008, Magnus Henoch wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> +	  (set-file-modes file (string-to-number "400" 8))
>
> I propose #o400 instead of string-to-number :)

I seem to recall the Emacs 21 (and maybe XEmacs?) don't support that.
I didn't test it, though.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Set temp files (viewing attachments) read-only?

[Reiner Steib]

On Mon, Apr 07 2008, Katsumi Yamaoka wrote:

>>>>>> Daniel Pittman wrote:
>> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>> Setting the temp file read-only[2] should make it clear, that editing
>>> it might be a bad idea.  It also forces the user to choose a different
>>> file name or location when saving.  What do you think?
>
>> I think that this would be a good idea.
>
> I think that's good, too.

Installed.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/