Re: [spam-report.el] Offline Gmane spam reporting

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Thu, Feb 05 2004, Ted Zlatanov wrote:

> On Tue, 03 Feb 2004, 4.uce.03.r.s@nurfuerspam.de wrote:
>> (defun spam-report-process-queue (&optional file keep)
>>   "Report all queued requests from `spam-report-requests-file'.
[...]
>>       (spam-report-url-ping-plain (match-string 1) (match-string 2))
[...]
> I would use spam-report-url-ping-function instead of s-r-u-p-plain
> there, 

Changed to...

  (funcall spam-report-url-ping-function (match-string 1) (match-string 2))

> unless s-r-u-p-function is equal to s-r-u-p-to-file (then we fall
> back to s-r-u-p-plain or maybe alert the user he's doing something
> strange).

Good idea...

  (if (eq spam-report-url-ping-function 'spam-report-url-to-file)
      (error (concat "Cannot process requests when "
		     "`spam-report-url-ping-function' is "
		     "`spam-report-url-to-file'."))
    (gnus-message 7 "Processing requests using `%s'."
		  spam-report-url-ping-function))

I have committed `spam-report-process-queue' now.

BTW: `spam-report-process-queue' calls `spam-report-url-ping-function'
for each report, i.e. when using `spam-report-url-ping-plain', we do
(open-network-stream ...) for each report.  If we always (or often)
have the same host, we could spare some overhead by sending multiple
"GET"s in one connection.  But I don't know if the performance gain is
worth the effort.

>> (add-to-list 'gnus-agent-plugged-hook
>> 	     (lambda ()
>> 	       (setq spam-report-url-ping-function
>> 		     'spam-report-url-ping-plain))
>> 	       (spam-report-process-queue));; see below
>> (add-to-list 'gnus-agent-unplugged-hook
>> 	     (lambda ()
>> 	       (setq spam-report-url-ping-function
>> 		     'spam-report-url-to-file)))
>
> I would save the old spam-report-url-ping-function in the unplugged
> hook, and restore it in the plugged hook, in case the user wants
> something other than 's-r-u-p-plain (they may already have
> 's-r-u-p-to-file for instance!)

If it gets more complicated, I would suggest to define named
functions, because then users may benefit of improvements without
having to edit the lambdas.  Please install what you have in mind (I'm
not sure how you intend to preserve the values and I'm not familiar
with the agent).

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/