From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63959 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: Search for multipart/(signed|encrypted) in message-forward-make-body Date: Sat, 11 Nov 2006 22:10:08 +0100 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1163280126 31317 80.91.229.2 (11 Nov 2006 21:22:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 11 Nov 2006 21:22:06 +0000 (UTC) Original-X-From: ding-owner+M12483@lists.math.uh.edu Sat Nov 11 22:22:05 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gj0IK-0007hs-I4 for ding-account@gmane.org; Sat, 11 Nov 2006 22:21:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Gj08H-0005Cj-7Y; Sat, 11 Nov 2006 15:11:21 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Gj08E-0005CB-MI for ding@lists.math.uh.edu; Sat, 11 Nov 2006 15:11:18 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1Gj088-0007Cu-In for ding@lists.math.uh.edu; Sat, 11 Nov 2006 15:11:18 -0600 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Gj082-00077H-00 for ; Sat, 11 Nov 2006 22:11:06 +0100 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1Gj07z-0005rn-7l for ding@gnus.org; Sat, 11 Nov 2006 22:11:03 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 11 Nov 2006 22:11:03 +0100 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 11 Nov 2006 22:11:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 42 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: 1;h7XMU[7l}$T@J.D}5z*w8Tg'}B5ArAWc8>2X~otB;kOjKs8X%|hTC#dG:%Vpx")x7S/`v :VXU#fZW$X$zdhEU.RfVQ@<-m9IuN{Hm"fW{,5]6kR'M*vEs+{5Cj!L(JTRzA$(},?5J=sm;%Od Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:63959 Archived-At: On Fri, Nov 10 2006, Katsumi Yamaoka wrote: >>>>>> Reiner Steib wrote: > >> in `message-forward-make-body' we have: > >> (if digest >> (message-forward-make-body-digest forward-buffer) >> (if message-forward-as-mime >> (if (and message-forward-show-mml >> (not (and (eq message-forward-show-mml 'best) >> (with-current-buffer forward-buffer >> (goto-char (point-min)) >> (re-search-forward >> "Content-Type: *multipart/\\(signed\\|encrypted\\)" >> nil t))))) >> (message-forward-make-body-mml forward-buffer) >> (message-forward-make-body-mime forward-buffer)) >> (message-forward-make-body-plain forward-buffer))) > >> Shouldn't the search for multipart/(signed|encrypted) be restricted to >> the headers? > > I don't think so. I tested your patch by forwarding again a > forwarded message in which the forwarded part contains non-ASCII > text and a gpg signature. Ah, I didn't think of this case. Thanks for clarifying. Wouldn't any text like "Content-Type: multipart/encrypted" in this line give a false match? Probably this isn't harmful because the message body looks nice with `message-forward-make-body-mml', but `message-forward-make-body-mime' is safer. Is this correct? Maybe adding a doc string and a few comments to `message-forward-make-body' would be a good idea. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/