Re: Viewing HTML-mails with external browsers - proposed code

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Jan 31 2006, Hynek Schlawack wrote:

> * Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>
>> As for your code, it's fine for now if you use `mm-make-temp-file'
>> instead of `make-temp-name'.
>
> Done. I've attached it - would some Win32-user care to test whether it
> works as expected _please_? Thanks!
>
>>> So, there's the bug with your mail and the temp-file-stuff left,
>>> iirc?
>> You mean removing the temp file(s)?  
>
> I'm still pondering how to get that best. I'll definitely add an
> argument for that because _I_ don't want to be bothered everytime I look
> at a HTML-mail. But any other suggestions? 

Here is an idea:

Store each used temp-filename in a list (internal variable).  Add a
function `gnus-article-browse-delete-temp-files' (better name?)  that
walks through this list and deletes the files (remove deleted files
from the list).  This function can be added to a suitable
gnus-*-exit-hook [1] (say on summary exit or on exit from Gnus).

Add a customizable variable (a list) specifying *when* to delete the
files and whether to prompt the user or not.
E.g. `gnus-article-browse-delete-temp' (better name?).

(memq t gnus-article-browse-delete-temp)    -> prompt before deleting
(eq nil gnus-article-browse-delete-temp)    -> delete w/o prompt

(memq 'summary gnus-article-browse-delete-temp)
  -> run `gnus-article-browse-delete-temp-files' on summary exit
(memq 'gnus gnus-article-browse-delete-temp)
  -> run `gnus-article-browse-delete-temp-files' on exit from Gnus
Maybe not useful:
(memq 'emacs gnus-article-browse-delete-temp)
  -> run `gnus-article-browse-delete-temp-files' on exit from Emacs

Depending on the value of `gnus-article-browse-delete-temp',
`gnus-article-browse-html-parts' does e.g.
(add-hook 'gnus-summary-exit-hook 'gnus-article-browse-delete-temp-files).

(Hm, this would lead to "CHANGED outside Customize" message in
customize.  But `spam-initialize' also does this.)

More simple approach: Run `gnus-article-browse-delete-temp-files' from
`gnus-summary-prepare-exit-hook' and `gnus-exit-gnus-hook'.  Allow
only the values `t' (delete w/o prompt), `nil' (don't delete) and
`ask' for the `gnus-article-browse-delete-temp' variable.

Opinions?

> C'mon guys/gals, it's not only Reiner reading here. ;)

Maybe we get more feedback now that I committed it to `gnus-art.el'.

Bye, Reiner.

[1]
,----
| gnus-after-exiting-gnus-hook
|   Variable: Hook called after exiting Gnus.
| gnus-exit-gnus-hook
|   Variable: Hook called when exiting Gnus.
| gnus-exit-group-hook
|   Variable: *A hook called when exiting summary mode.
| gnus-summary-exit-hook
|   Variable: *A hook called on exit from the summary buffer.
| gnus-summary-prepare-exit-hook
|   Variable: *A hook called when preparing to exit from the summary buffer.
`----
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/