Removing spam-group-ham-mark-p, spam-group-spam-mark-p (was: Changes to emacs/lisp/gnus/ChangeLog)

Removing spam-group-ham-mark-p, spam-group-spam-mark-p (was: Changes to emacs/lisp/gnus/ChangeLog)

[Reiner Steib]

Chong Yidong on emacs-diffs:

> --- emacs/lisp/gnus/ChangeLog:1.414	Sat Dec 17 21:41:33 2005
> +++ emacs/lisp/gnus/ChangeLog	Sun Jan  8 21:29:46 2006
> @@ -1,3 +1,10 @@
> +2006-01-08  Chong Yidong  <cyd@stupidchicken.com>
> +
> +	* spam.el (spam-group-ham-mark-p, spam-group-spam-mark-p)
> +	(spam-group-spam-marks): Delete functions.
> +	(spam-list-articles): Just call spam-group-ham-marks directly.
> +	(spam-group-ham-marks): Simplify.

I'd appreciate if you would discuss non-trivial changes to Gnus on the
Gnus developer list before committing.

I intend to add functionality[1] in the current development version of
Gnus that relies on the functions `spam-group-ham-mark-p' and
`spam-group-spam-mark-p'.

[1] Adding a tool bar button for `gnus-summary-mark-as-spam' depending
    on the result of `spam-group-ham-mark-p', along with improving the
    tool bar in general.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Removing spam-group-ham-mark-p, spam-group-spam-mark-p

[Ted Zlatanov]

On  8 Jan 2006, reinersteib+gmane@imap.cc wrote:

> Chong Yidong on emacs-diffs:
>
>> --- emacs/lisp/gnus/ChangeLog:1.414	Sat Dec 17 21:41:33 2005
>> +++ emacs/lisp/gnus/ChangeLog	Sun Jan  8 21:29:46 2006
>>>> -1,3 +1,10 @@
>> +2006-01-08  Chong Yidong  <cyd@stupidchicken.com>
>> +
>> +	* spam.el (spam-group-ham-mark-p, spam-group-spam-mark-p)
>> +	(spam-group-spam-marks): Delete functions.
>> +	(spam-list-articles): Just call spam-group-ham-marks directly.
>> +	(spam-group-ham-marks): Simplify.
>
> I'd appreciate if you would discuss non-trivial changes to Gnus on the
> Gnus developer list before committing.

Chong, was there a reason for deleting them?  Are they slow?  I'd like
to keep them too.

Ted

p.s. sorry for the late reply, I just caught up with ding :)

Re: Removing spam-group-ham-mark-p, spam-group-spam-mark-p

[Reiner Steib]

On Fri, Feb 03 2006, Ted Zlatanov wrote:

>>> +2006-01-08  Chong Yidong  <cyd@stupidchicken.com>
>>> +
>>> +	* spam.el (spam-group-ham-mark-p, spam-group-spam-mark-p)
>>> +	(spam-group-spam-marks): Delete functions.
>>> +	(spam-list-articles): Just call spam-group-ham-marks directly.
>>> +	(spam-group-ham-marks): Simplify.
[...]
> Chong, was there a reason for deleting them?  Are they slow?  I'd like
> to keep them too.

We agreed to revert this change.  I did this some weeks ago.

Now (in the trunk) the functions are also used in
`gnus-summary-tool-bar-gnome'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Removing spam-group-ham-mark-p, spam-group-spam-mark-p

[Ted Zlatanov]

On  4 Feb 2006, reinersteib+gmane@imap.cc wrote:

> We agreed to revert this change.  I did this some weeks ago.
>
> Now (in the trunk) the functions are also used in
> `gnus-summary-tool-bar-gnome'.

Oh, I see.  Sorry for the noise.

Ted