Re: loading spam.el and gnus-registry.el with set variables only

[4.uce.03.r.s@nurfuerspam.de (Reíner Steib)]

On Thu, Oct 09 2003, Ted Zlatanov wrote:

> Let me know if the attached patch looks OK.

I don't understand the need and the use of the variable
`spam-install-hooks':

(defcustom spam-use-dig t
  [...])

[... other spam-use-VAR defaulting to nil ...]

(defcustom spam-install-hooks (or
			       spam-use-dig
			       spam-use-blacklist
                               [...]
			       spam-use-stat
			       spam-use-spamoracle)
  "Whether the spam hooks should be installed, default to t if one of
the spam-use-* variables is set." [...])

I.e. `spam-install-hooks' is always t when you load `spam.el'?  If you
use the `spam-initialize' function, why do you need the variable
`spam-install-hooks' at all?

If it's not used anymore, you may issue a warning if it's bound while
loading `spam.el', i.e. if someone wants to use the obsoleted
interface.

> +;;;###autoload
> +(defun spam-initialize ()
> +  (interactive)
> +  (setq spam-install-hooks t)
> +  (spam-install-hooks-function)
> +  ;; TODO: How do we redo this every time spam-face is customized?
> +  (push '((eq mark gnus-spam-mark) . spam-face)
> +	gnus-summary-highlight))

Then, I'd add "(push ...) to `spam-install-hooks-function' and rename
it to `spam-initialize'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/