From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/54194 Path: main.gmane.org!not-for-mail From: 4.uce.03.r.s@nurfuerspam.de (=?iso-8859-1?q?Re=EDner_Steib?=) Newsgroups: gmane.emacs.gnus.general Subject: Re: loading spam.el and gnus-registry.el with set variables only Date: Thu, 09 Oct 2003 21:37:10 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Sender: ding-owner@lists.math.uh.edu Message-ID: References: <4ny8vwnb04.fsf@lockgroove.bwh.harvard.edu> <4nbrsqzd41.fsf@lockgroove.bwh.harvard.edu> <4n8ynutho4.fsf@lockgroove.bwh.harvard.edu> Reply-To: reiner.steib@gmx.de NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1065728366 27493 80.91.224.253 (9 Oct 2003 19:39:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 9 Oct 2003 19:39:26 +0000 (UTC) Original-X-From: ding-owner+M2735@lists.math.uh.edu Thu Oct 09 21:39:25 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A7gdA-0005tj-00 for ; Thu, 09 Oct 2003 21:39:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1A7gbS-0004UH-00; Thu, 09 Oct 2003 14:37:38 -0500 Original-Received: from justine.libertine.org ([66.139.78.221]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1A7gbK-0004U9-00 for ding@lists.math.uh.edu; Thu, 09 Oct 2003 14:37:30 -0500 Original-Received: from main.gmane.org (main.gmane.org [80.91.224.249]) by justine.libertine.org (Postfix) with ESMTP id 97FF53A004E for ; Thu, 9 Oct 2003 14:37:28 -0500 (CDT) Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1A7gbH-000419-00 for ; Thu, 09 Oct 2003 21:37:27 +0200 Mail-Followup-To: ding@gnus.org X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Received: from sea.gmane.org ([80.91.224.252]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A7gbG-000411-00 for ; Thu, 09 Oct 2003 21:37:26 +0200 Original-Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian)) id 1A7gbG-00075i-00 for ; Thu, 09 Oct 2003 21:37:26 +0200 Original-Lines: 46 Original-X-Complaints-To: usenet@sea.gmane.org X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Copies-To: nobody User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3 (gnu/linux) Cancel-Lock: sha1:pQh09gOm7t6EnyNYmDVDkm1Jz04= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:54194 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:54194 On Thu, Oct 09 2003, Ted Zlatanov wrote: > Let me know if the attached patch looks OK. I don't understand the need and the use of the variable `spam-install-hooks': (defcustom spam-use-dig t [...]) [... other spam-use-VAR defaulting to nil ...] (defcustom spam-install-hooks (or spam-use-dig spam-use-blacklist [...] spam-use-stat spam-use-spamoracle) "Whether the spam hooks should be installed, default to t if one of the spam-use-* variables is set." [...]) I.e. `spam-install-hooks' is always t when you load `spam.el'? If you use the `spam-initialize' function, why do you need the variable `spam-install-hooks' at all? If it's not used anymore, you may issue a warning if it's bound while loading `spam.el', i.e. if someone wants to use the obsoleted interface. > +;;;###autoload > +(defun spam-initialize () > + (interactive) > + (setq spam-install-hooks t) > + (spam-install-hooks-function) > + ;; TODO: How do we redo this every time spam-face is customized? > + (push '((eq mark gnus-spam-mark) . spam-face) > + gnus-summary-highlight)) Then, I'd add "(push ...) to `spam-install-hooks-function' and rename it to `spam-initialize'. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- PGP key available via WWW http://rsteib.home.pages.de/