Re: Limiting number of Incomingxxxx mails

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

On Sat, Feb 22 2003, Lars Magne Ingebrigtsen wrote:

[ `mail-source-delete-old-incoming' ] 
> I'm not quite sure that such a function is a good idea.  The
> Incoming* files are created only by pretest Gnusae, so they should
> only be produced by versions of Gnus that are dangerous, mail-wise
> speaking.  Having mechanisms for automatically deleting stuff in
> such a situation might be counterproductive.

The default value of `mail-source-delete-incoming' should still be
`nil' in pretest Gnusae, i.e. no automatically deleting, no change to
the current behavior.

I don't see any harm if Gnus would offer an option to delete old
files.  Note that additionally there's a `confirm' argument in
`mail-source-delete-old-incoming' and a variable
`mail-source-delete-old-incoming-confirm'.

I.e. the user has to change `mail-source-delete-incoming' to a
positive integer (default is nil) *and* change
`mail-source-delete-old-incoming-confirm' to nil (default is t) in
order to get automatic deleting without confirmation for every single
incoming file.  I suppose this should be enough protection. :-)

I'll add proper documentation, if this patch will be accepted.

--8<---------------cut here---------------start------------->8---
2003-02-24  Reiner Steib  <Reiner.Steib@gmx.de>

	* mail-source.el (mail-source-delete-incoming): Allow integer value.
	(mail-source-delete-old-incoming-confirm): New variable.
	(mail-source-delete-old-incoming): Use it.  New function.
	(mail-source-callback): Call `mail-source-delete-old-incoming' if
	`mail-source-delete-incoming' is a nonnegative integer.
--8<---------------cut here---------------end--------------->8---

Here's a revised version[1] of the patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mail-source.delete-old-incoming.02.patch --]
[-- Type: text/x-patch, Size: 3367 bytes --]

--- mail-source.el.~6.29.~	Mon Feb 17 11:37:23 2003
+++ mail-source.el	Mon Feb 24 21:07:41 2003
@@ -263,7 +263,21 @@
   :type 'integer)
 
 (defcustom mail-source-delete-incoming nil
-  "*If non-nil, delete incoming files after handling."
+  "*If non-nil, delete incoming files after handling.
+If t, delete immediately, if nil, never delete.  If a positive number, delete
+files older than number of days."
+  ;; Note: The removing happens in `mail-source-callback', i.e. no old
+  ;; incoming files will be deleted, unless you receive new mail.
+  ;;
+  ;; You may also set this to `nil' and call `mail-source-delete-old-incoming'
+  ;; from a hook or interactively.
+  :group 'mail-source
+  :type '(choice (const :tag "immediately" t)
+		 (const :tag "never" nil)
+		 (integer :tag "days")))
+
+(defcustom mail-source-delete-old-incoming-confirm t
+  "*If non-nil, ask for for confirmation before deleting old incoming files."
   :group 'mail-source
   :type 'boolean)
 
@@ -506,6 +520,34 @@
 	  (setq newname (make-temp-name newprefix)))
 	newname))))
 
+(defun mail-source-delete-old-incoming (&optional age confirm)
+  "Remove incoming files older than AGE days.
+If CONFIRM is non-nil, ask for confirmation before removing a file."
+  (interactive "P")
+  (let* ((high2days (/ 65536.0 60 60 24));; convert high bits to days
+	 (low2days  (/ 1.0 65536.0))     ;; convert low bits to days
+	 (diff (if (natnump age) age 30));; fallback, if no valid AGE given
+	 currday files)
+    (setq files (directory-files
+		 mail-source-directory t 
+		 (concat mail-source-incoming-file-prefix "*"))
+	  currday (* (car (current-time)) high2days)
+	  currday (+ currday (* low2days (nth 1 (current-time)))))
+    (while files
+      (let* ((ffile (car files))
+	     (bfile (gnus-replace-in-string
+		     ffile "\\`.*/\\([^/]+\\)\\'" "\\1"))
+	     (filetime (nth 5 (file-attributes ffile)))
+	     (fileday (* (car filetime) high2days))
+	     (fileday (+ fileday (* low2days (nth 1 filetime)))))
+	(setq files (cdr files))
+	(when (and (> (- currday fileday) diff)
+		   (gnus-message 8 "File `%s' is older than %s day(s)"
+				 bfile diff)
+		   (or (not confirm)
+		       (y-or-n-p (concat "Remove file `" bfile "'? "))))
+	  (delete-file ffile))))))
+
 (defun mail-source-callback (callback info)
   "Call CALLBACK on the mail file, and then remove the mail file.
 Pass INFO on to CALLBACK."
@@ -519,7 +561,7 @@
 	(funcall callback mail-source-crash-box info)
       (when (file-exists-p mail-source-crash-box)
 	;; Delete or move the incoming mail out of the way.
-	(if mail-source-delete-incoming
+	(if (eq mail-source-delete-incoming t)
 	    (delete-file mail-source-crash-box)
 	  (let ((incoming
 		 (mail-source-make-complex-temp-name
@@ -528,8 +570,13 @@
 		   mail-source-directory))))
 	    (unless (file-exists-p (file-name-directory incoming))
 	      (make-directory (file-name-directory incoming) t))
-	    (rename-file mail-source-crash-box incoming t)))))))
-
+	    (rename-file mail-source-crash-box incoming t)
+	    ;; remove old incoming files?
+	    (when (natnump mail-source-delete-incoming)
+	      (mail-source-delete-old-incoming
+	       mail-source-delete-incoming
+	       mail-source-delete-old-incoming-confirm))))))))
+  
 (defun mail-source-movemail (from to)
   "Move FROM to TO using movemail."
   (if (not (file-writable-p to))

[-- Attachment #3: Type: text/plain, Size: 232 bytes --]


Bye, Reiner.

[1] Simplified the code (thanks to JPW): Use natnump, set most
    variables in a let* form instead of using setq.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/