Re: nnir.el cleanup

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Apr 22 2008, Christoph Conrad wrote:

>> Could you provide a patch that fixes/silences the Emacs 23 compiler
>> warnings?
[...]
> Changelog entry proposal:
> Fixed byte compiler warnings, deleted unnecessary code.
>
> I also deleted superfluous settings of variables to nil in a let binding.

Thanks.  I've committed it with a more verbose ChangeLog entry.

> I also see some suspicious and potentially dangerous code: the
> nnir-run-* functions not supporting the &optional group all define a
> local group variable in a let binding with default value nil which
> occlude the variable of the parameter list. This is IMHO unnecessary
> cause they throw an error at the beginning of the same function when the
> group parameter is not nil.

I see that it is unnecessary, but could you elaborate why it could be
dangerous and/or provide a patch?

Or is this sufficient?

--8<---------------cut here---------------start------------->8---
--- nnir.el	24 Apr 2008 19:36:35 +0200	7.31
+++ nnir.el	24 Apr 2008 20:05:38 +0200	
@@ -895,7 +895,7 @@
   (save-excursion
     (let ((qstring (cdr (assq 'query query)))
 	  (prefix (nnir-read-server-parm 'nnir-wais-remove-prefix server))
-          artlist score artno dirnam group)
+          artlist score artno dirnam)
       (set-buffer (get-buffer-create nnir-tmp-buffer))
       (erase-buffer)
       (message "Doing WAIS query %s..." query)
@@ -1176,7 +1176,7 @@
 	   (article-pattern (if (string= server "nnmaildir:")
 				":[0-9]+"
 			      "^[0-9]+\\(\\.[a-z0-9]+\\)?$"))
-           score artno dirnam group filenam )
+           score artno dirnam filenam)
 
       (when (equal "" qstring)
         (error "swish++: You didn't enter anything."))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/