From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66867 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: nnir.el cleanup Date: Thu, 24 Apr 2008 20:06:30 +0200 Message-ID: References: <87y77fiszu.fsf@ID-24456.user.uni-berlin.de> <87lk3fvw4l.fsf@ID-24456.user.uni-berlin.de> <873apmapq9.fsf_-_@ID-24456.user.uni-berlin.de> <87k5isa5vc.fsf@ID-24456.user.uni-berlin.de> <87hcdtep8k.fsf@ID-24456.user.uni-berlin.de> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1209061146 28007 80.91.229.12 (24 Apr 2008 18:19:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Apr 2008 18:19:06 +0000 (UTC) Cc: Justus@piater.name, ding@gnus.org To: Christoph Conrad Original-X-From: ding-owner+M15348@lists.math.uh.edu Thu Apr 24 20:19:41 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jp62l-0001ZB-9b for ding-account@gmane.org; Thu, 24 Apr 2008 20:19:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Jp61M-0003Gs-M9; Thu, 24 Apr 2008 13:18:12 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Jp61L-0003GY-42 for ding@lists.math.uh.edu; Thu, 24 Apr 2008 13:18:11 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1Jp61E-0007Ut-Gp for ding@lists.math.uh.edu; Thu, 24 Apr 2008 13:18:11 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Jp61Q-000197-00 for ; Thu, 24 Apr 2008 20:18:16 +0200 Original-Received: from localhost (corona.rz.uni-ulm.de [134.60.1.50]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m3OII1br022754; Thu, 24 Apr 2008 20:18:01 +0200 (MEST) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: Christoph Conrad , Justus@piater.name, ding@gnus.org In-Reply-To: <87hcdtep8k.fsf@ID-24456.user.uni-berlin.de> (Christoph Conrad's message of "Tue, 22 Apr 2008 19:52:58 +0200") User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2.50 (gnu/linux) X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66867 Archived-At: On Tue, Apr 22 2008, Christoph Conrad wrote: >> Could you provide a patch that fixes/silences the Emacs 23 compiler >> warnings? [...] > Changelog entry proposal: > Fixed byte compiler warnings, deleted unnecessary code. > > I also deleted superfluous settings of variables to nil in a let binding. Thanks. I've committed it with a more verbose ChangeLog entry. > I also see some suspicious and potentially dangerous code: the > nnir-run-* functions not supporting the &optional group all define a > local group variable in a let binding with default value nil which > occlude the variable of the parameter list. This is IMHO unnecessary > cause they throw an error at the beginning of the same function when the > group parameter is not nil. I see that it is unnecessary, but could you elaborate why it could be dangerous and/or provide a patch? Or is this sufficient? --8<---------------cut here---------------start------------->8--- --- nnir.el 24 Apr 2008 19:36:35 +0200 7.31 +++ nnir.el 24 Apr 2008 20:05:38 +0200 @@ -895,7 +895,7 @@ (save-excursion (let ((qstring (cdr (assq 'query query))) (prefix (nnir-read-server-parm 'nnir-wais-remove-prefix server)) - artlist score artno dirnam group) + artlist score artno dirnam) (set-buffer (get-buffer-create nnir-tmp-buffer)) (erase-buffer) (message "Doing WAIS query %s..." query) @@ -1176,7 +1176,7 @@ (article-pattern (if (string= server "nnmaildir:") ":[0-9]+" "^[0-9]+\\(\\.[a-z0-9]+\\)?$")) - score artno dirnam group filenam ) + score artno dirnam filenam) (when (equal "" qstring) (error "swish++: You didn't enter anything.")) --8<---------------cut here---------------end--------------->8--- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/