Re: Larger smilies

Re: Larger smilies

[Adam Sjøgren]

On Sun, 16 Feb 2003 13:23:26 +0100, I wrote:

> Gnus comes with some smilies. I'd like them a little larger and more
> "rounded". So I made some.
[...]

>  <http://koldfront.dk/text/larger-smilies.html>

Some discussion ensued and at 18:03:24, I wrote:

> On Sun, 16 Feb 2003 17:40:01 +0100, Lars Magne Ingebrigtsen wrote:

[...nah, 8-9 is too many colours...]

> Ok. I shall nag you in ten years time.

This being the, uh, internets, I hereby declare that the ten years
have gone by and therefore I bring this up again, now.

Nicer smileys, whattayathink, comments?


  :-),

   Adam

-- 
 "we push onward. to you, it is 2005, to us, it is            Adam Sjøgren
  2011. we are always far ahead."                        asjo@koldfront.dk

Re: Larger smilies

[Miles Bader]

asjo@koldfront.dk (Adam Sjøgren) writes:
>> On Sun, 16 Feb 2003 17:40:01 +0100, Lars Magne Ingebrigtsen wrote:
>
> [...nah, 8-9 is too many colours...]
>
>> Ok. I shall nag you in ten years time.
>
> This being the, uh, internets, I hereby declare that the ten years
> have gone by and therefore I bring this up again, now.
>
> Nicer smileys, whattayathink, comments?

Garish yellow smileys are so AOL...

What's _really_ cool is the smileys in gmail's new embedded IM client --
they look like un-adorned text smileys ... but then a second or so after
showing up, they slowly _rotate_ to a vertical orientation!  They're
understated and cool at the same time, very google.

The "slowly rotate into position" part probably doesn't make much sense
with mail (and is harder to implement).  However I really like smileys
that basically look like the text version (no colors, no "border" around
the face) but in a vertical orientation.

:-|

-Miles
-- 
If you can't beat them, arrange to have them beaten.  [George Carlin]

Re: Larger smilies

[Adam Sjøgren]

On Thu, 23 Feb 2006 08:47:12 +0900, Miles wrote:

>> Nicer smileys, whattayathink, comments?

> Garish yellow smileys are so AOL...

Different strokes for different folks...

[... Talk of Google Talk-smileys elided ...]

I have now updated my set of garish AOL-smilies so they match the full
set found in etc/images/smilies/ in Gnus CVS.

I have also created a set of dull smilies that are grey and without
borders. They can do with a lot of improvement though.

 <http://www.koldfront.dk/text/larger-smilies.html>


  Best regards,

    Adam

-- 
 "This reporter was clearly from the "stenography"            Adam Sjøgren
  school of reporting. Math is hard, let's go shopping."  asjo@koldfront.dk

Re: Larger smilies

[Reiner Steib]

[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]

On Wed, Mar 08 2006, Adam Sjøgren wrote:

> I have now updated my set of garish AOL-smilies so they match the full
> set found in etc/images/smilies/ in Gnus CVS.
>
> I have also created a set of dull smilies that are grey and without
> borders. They can do with a lot of improvement though.
>
>  <http://www.koldfront.dk/text/larger-smilies.html>

Apply the attached patch, put Adam's smilies into a /medium and
/grayscale ("dull-*.tar.gz") subdirectory of etc/images/smilies, do
`M-: (push "/path/to/No_Gnus/lisp/" load-path) RET', and customize
`smiley-style'.  WDYT?

For my font size (14) your 16 pixel smilies are too large (causing
increased "linespread").  Maybe you could remove the empty lines from
your "dull" variants?

Bye, Reiner.

Test text with all kinds of smilies follows:

  Lorem ipsum dolor ^:-) sit amet, consectetuer ^:) adipiscing
  elit. Aenean ;-) tincidunt ultrices ;) nisl. Nullam fermentum turpis
  eu ante. Nunc magna :-] augue, rutrum ut, suscipit non, mollis
  vitae, erat. Vivamus ullamcorper ligula 8-) ut nisi. Donec ultrices
  massa sed metus semper :-| congue. Vivamus dignissim, neque non
  placerat :-/ pharetra, mauris sapien mattis justo, a nonummy :-\ dui
  nulla ac dolor. Suspendisse purus eros, :-( sagittis vel, mollis
  non, adipiscing a, justo. Vivamus ultricies, >:-) ipsum quis
  placerat consectetuer, leo lorem eleifend odio, id tincidunt neque
  mi ac mauris. X-) Pellentesque vehicula orci ut nisl. Suspendisse
  potenti. Phasellus ornare, elit a hendrerit :-D vulputate, ipsum
  libero viverra dui, ac imperdiet lectus mi eget metus.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rs-smiley-larger.patch --]
[-- Type: text/x-patch, Size: 4287 bytes --]

--- smiley.el	08 Feb 2006 13:32:51 +0100	7.8
+++ smiley.el	09 Mar 2006 20:16:36 +0100	
@@ -31,8 +31,21 @@
 ;; I'm not sure we need that degree of rococoness and defaults like a
 ;; yellow background.  Also, using PBM means we can display the images
 ;; more generally.  -- fx
+;; `smiley.el' was replaced by `smiley-ems.el' on 2002-01-26 (after fx'
+;; comment).
 
-;;; Test smileys:  :-) :-\ :-( :-/
+;; Test smileys:
+;; smile             ^:-) ^:)
+;; blink             ;-)  ;)
+;; forced            :-]
+;; braindamaged      8-)
+;; indifferent       :-|
+;; wry               :-/  :-\
+;; sad               :-(
+;; evil              >:-)
+;; cry               ;-(
+;; dead              X-)
+;; grin              :-D
 
 ;;; Code:
 
@@ -45,25 +58,59 @@
   :group 'gnus-visual)
 
 ;; Maybe this should go.
-(defcustom smiley-data-directory (nnheader-find-etc-directory "images/smilies")
+(defcustom smiley-style 'low-color
+  "Smiley style."
+  :type '(choice (const :tag "small, 3 colors" low-color)
+		 (const :tag "medium, ~10 colors" medium)
+		 (const :tag "dull, grayscale" grayscale))
+  :set (lambda (symbol value)
+	 (set-default symbol value)
+	 (setq smiley-data-directory (smiley-directory))
+	 (smiley-update-cache))
+  :initialize 'custom-initialize-default
+  :group 'smiley)
+
+;; For compatibility, honor the variable `smiley-data-directory' if the user
+;; has set it.
+
+(defun smiley-directory (&optional style)
+  "Return a the location of the smiley faces files.
+STYLE specifies which style to use, see `smiley-style'.  If STYLE
+is nil, use `smiley-style'."
+  (unless style (setq style smiley-style))
+  (nnheader-find-etc-directory
+   (concat "images/smilies"
+	   (cond ((eq smiley-style 'low-color) "")
+		 ((eq smiley-style 'medium) "/medium")
+		 ((eq smiley-style 'grayscale) "/grayscale")))))
+
+(defcustom smiley-data-directory (smiley-directory)
   "*Location of the smiley faces files."
+  :set (lambda (symbol value)
+	 (set-default symbol value)
+	 (smiley-update-cache))
+  :initialize 'custom-initialize-default
   :type 'directory
   :group 'smiley)
 
 ;; The XEmacs version has a baroque, if not rococo, set of these.
 (defcustom smiley-regexp-alist
-  '(("\\(:-?)\\)\\W" 1 "smile")
+  '(("\\(\\^:-?)\\)\\W" 1 "smile")
     ("\\(;-?)\\)\\W" 1 "blink")
     ("\\(:-]\\)\\W" 1 "forced")
     ("\\(8-)\\)\\W" 1 "braindamaged")
     ("\\(:-|\\)\\W" 1 "indifferent")
     ("\\(:-[/\\]\\)\\W" 1 "wry")
     ("\\(:-(\\)\\W" 1 "sad")
-    ("\\(:-{\\)\\W" 1 "frown"))
+    ("\\(:-{\\)\\W" 1 "frown")
+    ("\\(>:-)\\)\\W" 1 "evil")
+    ("\\(;-(\\)\\W" 1 "cry")
+    ("\\(X-)\\)\\W" 1 "dead")
+    ("\\(:-D\\)\\W" 1 "grin"))
   "*A list of regexps to map smilies to images.
-The elements are (REGEXP MATCH FILE), where MATCH is the submatch in
-regexp to replace with IMAGE.  IMAGE is the name of a PBM file in
-`smiley-data-directory'."
+The elements are (REGEXP MATCH IMAGE), where MATCH is the submatch
+in regexp to replace with IMAGE.  IMAGE is the name of an image
+file in `smiley-data-directory'."
   :type '(repeat (list regexp
 		       (integer :tag "Regexp match number")
 		       (string :tag "Image name")))
@@ -78,7 +125,7 @@
     (when (gnus-image-type-available-p 'xpm)
       (push "xpm" types))
     types)
-  "*List of suffixes on picon file names to try."
+  "*List of suffixes on smiley file names to try."
   :version "22.1"
   :type '(repeat string)
   :group 'smiley)
@@ -86,6 +133,7 @@
 (defvar smiley-cached-regexp-alist nil)
 
 (defun smiley-update-cache ()
+  (setq smiley-cached-regexp-alist nil)
   (dolist (elt (if (symbolp smiley-regexp-alist)
 		   (symbol-value smiley-regexp-alist)
 		 smiley-regexp-alist))
@@ -104,12 +152,13 @@
 	    (push (list (car elt) (cadr elt) image)
 		  smiley-cached-regexp-alist)))))))
 
-(defvar smiley-mouse-map
-  (let ((map (make-sparse-keymap)))
-    (define-key map [down-mouse-2] 'ignore) ; override widget
-    (define-key map [mouse-2]
-      'smiley-mouse-toggle-buffer)
-    map))
+;; Not implemented:
+;; (defvar smiley-mouse-map
+;;   (let ((map (make-sparse-keymap)))
+;;     (define-key map [down-mouse-2] 'ignore) ; override widget
+;;     (define-key map [mouse-2]
+;;       'smiley-mouse-toggle-buffer)
+;;     map))
 
 ;;;###autoload
 (defun smiley-region (start end)

Re: Larger smilies

[Adam Sjøgren]

On Thu, 09 Mar 2006 20:19:07 +0100, Reiner wrote:

> For my font size (14) your 16 pixel smilies are too large (causing
> increased "linespread").  Maybe you could remove the empty lines from
> your "dull" variants?

I have shaved off a pixel from all sides now, making the dull ones
14x14 (v0.03):

 <http://www.koldfront.dk/text/larger-smilies.html>

Better?


  Best regards,

    Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Larger smilies

[Reiner Steib]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

On Mon, Mar 20 2006, Adam Sjøgren wrote:

> On Thu, 09 Mar 2006 20:19:07 +0100, Reiner wrote:
>
>> For my font size (14) your 16 pixel smilies are too large (causing
>> increased "linespread").  Maybe you could remove the empty lines from
>> your "dull" variants?
>
> I have shaved off a pixel from all sides now, making the dull ones
> 14x14 (v0.03):
>
>  <http://www.koldfront.dk/text/larger-smilies.html>
>
> Better?

Yes, thanks.

Any comments WRT the suggested code?  Did you try it?  Attached is an
updated patch.

On Mon, Mar 20 2006, Adam Sjøgren wrote:

> On Thu, 09 Mar 2006 20:19:07 +0100, Reiner wrote:
>> +;; Test smileys:
[...]
> Oops, you forgot:
>
> ;; frown              :-{
>
>   ;-),

Fixed in CVS (v5-10).  :-)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2637 bytes --]

Index: smiley.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/smiley.el,v
retrieving revision 7.9
diff -u -u -r7.9 smiley.el
--- smiley.el	10 Mar 2006 16:06:37 -0000	7.9
+++ smiley.el	20 Mar 2006 19:58:45 -0000
@@ -42,6 +42,7 @@
 ;; indifferent       :-|
 ;; wry               :-/  :-\
 ;; sad               :-(
+;; frown             :-{
 ;; evil              >:-)
 ;; cry               ;-(
 ;; dead              X-)
@@ -58,22 +59,55 @@
   :group 'gnus-visual)
 
 ;; Maybe this should go.
-(defcustom smiley-data-directory
-  (nnheader-find-etc-directory "images/smilies")
-  "Location of the smiley faces files."
+(defcustom smiley-style 'low-color
+  "Smiley style."
+  :type '(choice (const :tag "small, 3 colors" low-color)
+		 (const :tag "medium, ~10 colors" medium)
+		 (const :tag "dull, grayscale" grayscale))
+  :set (lambda (symbol value)
+	 (set-default symbol value)
+	 (setq smiley-data-directory (smiley-directory))
+	 (smiley-update-cache))
+  :initialize 'custom-initialize-default
+  :group 'smiley)
+
+;; For compatibility, honor the variable `smiley-data-directory' if the user
+;; has set it.
+
+(defun smiley-directory (&optional style)
+  "Return a the location of the smiley faces files.
+STYLE specifies which style to use, see `smiley-style'.  If STYLE
+is nil, use `smiley-style'."
+  (unless style (setq style smiley-style))
+  (nnheader-find-etc-directory
+   (concat "images/smilies"
+	   (cond ((eq smiley-style 'low-color) "")
+		 ((eq smiley-style 'medium) "/medium")
+		 ((eq smiley-style 'grayscale) "/grayscale")))))
+
+(defcustom smiley-data-directory (smiley-directory)
+  "*Location of the smiley faces files."
+  :set (lambda (symbol value)
+	 (set-default symbol value)
+	 (smiley-update-cache))
+  :initialize 'custom-initialize-default
   :type 'directory
   :group 'smiley)
 
 ;; The XEmacs version has a baroque, if not rococo, set of these.
 (defcustom smiley-regexp-alist
-  '(("\\(:-?)\\)\\W" 1 "smile")
+  '(("\\(\\^:-?)\\)\\W" 1 "smile")
     ("\\(;-?)\\)\\W" 1 "blink")
     ("\\(:-]\\)\\W" 1 "forced")
     ("\\(8-)\\)\\W" 1 "braindamaged")
     ("\\(:-|\\)\\W" 1 "indifferent")
     ("\\(:-[/\\]\\)\\W" 1 "wry")
     ("\\(:-(\\)\\W" 1 "sad")
-    ("\\(:-{\\)\\W" 1 "frown"))
+    ("\\(:-{\\)\\W" 1 "frown")
+    ("\\(>:-)\\)\\W" 1 "evil")
+    ("\\(;-(\\)\\W" 1 "cry")
+    ("\\(X-)\\)\\W" 1 "dead")
+    ("\\(:-D\\)\\W" 1 "grin"))
   "*A list of regexps to map smilies to images.
 The elements are (REGEXP MATCH IMAGE), where MATCH is the submatch in
 regexp to replace with IMAGE.  IMAGE is the name of an image file in

Re: Larger smilies

[Adam Sjøgren]

On Mon, 20 Mar 2006 21:02:54 +0100, Reiner wrote:

> Any comments WRT the suggested code?  Did you try it?  Attached is an
> updated patch.

I've tried it now.

For some reason the last smiley in your email (the one I'm replying
to) did not get substituted.

I may have botched the regexp in my original email (I'm used to perl
regex'es - emacs' toothpicks give me the willies).

Other than that, it works fine :-)

Is it possible to set smiley-style directly from .gnus?


  Best regards,

    Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Larger smilies

[Reiner Steib]

On Mon, Mar 20 2006, Adam Sjøgren wrote:

> I may have botched the regexp in my original email (I'm used to perl
> regex'es - emacs' toothpicks give me the willies).
>
> Other than that, it works fine :-)

I will look at the regexp problem later.

> Is it possible to set smiley-style directly from .gnus?

(setq smiley-style 'medium) should work, doesn't it?  Just be sure to
do it before `smiley.el' is loaded and don't set
`smiley-data-directory'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Larger smilies

[Adam Sjøgren]

On Tue, 21 Mar 2006 00:09:44 +0100, Reiner wrote:

> (setq smiley-style 'medium) should work, doesn't it?  Just be sure to
> do it before `smiley.el' is loaded and don't set
> `smiley-data-directory'.

Ah. I set it after loading smiley.el (and I did that to set
smiley-data-directory, previously).

Works like a charm now.


  Thanks,

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Larger smilies

[Adam Sjøgren]

On Mon, 20 Mar 2006 21:02:54 +0100, Reiner wrote:

> -  '(("\\(:-?)\\)\\W" 1 "smile")
> +  '(("\\(\\^:-?)\\)\\W" 1 "smile")

Actually this looks bothced to me.

I've got this regexp on my webpage:

 ("\\(\\^\\|[^>]\\)\\(:-?)\\)\\W" 2 "smile")

Which is supposed to say "':-)' either at the start of the line or
after something that is NOT '>' (because that would be evil(.xpm))"

Changing that line in smiley.el makes your changed work fine for me.


  Best regards,

   Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Larger smilies

[Adam Sjøgren]

On Thu, 09 Mar 2006 20:19:07 +0100, Reiner wrote:

> -;;; Test smileys:  :-) :-\ :-( :-/
> +;; Test smileys:
> +;; smile             ^:-) ^:)
> +;; blink             ;-)  ;)
> +;; forced            :-]
> +;; braindamaged      8-)
> +;; indifferent       :-|
> +;; wry               :-/  :-\
> +;; sad               :-(
> +;; evil              >:-)
> +;; cry               ;-(
> +;; dead              X-)
> +;; grin              :-D

Oops, you forgot:

;; frown              :-{


  ;-),

   Adam

-- 
 "You know, if the sun was an oboe, what would you do?"       Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Larger smilies

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Nicer smileys, whattayathink, comments?

Neat.  I think 'medium should be made the default.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Larger smilies

[Reiner Steib]

On Wed, Apr 12 2006, Lars Magne Ingebrigtsen wrote:

> asjo@koldfront.dk (Adam Sjøgren) writes:
>
>> Nicer smileys, whattayathink, comments?
>
> Neat.  I think 'medium should be made the default.

For my font size (14) the medium (16x16 pixel) smilies are too large
(causing increased "linespread").  Maybe the default should depend on
the face height?

(defcustom smiley-style
  (if (and (fboundp 'face-attribute)
	   (>= (face-attribute 'default :height) 160))
      'medium
    'low-color)
  "Smiley style."
  :type '(choice (const :tag "small, 3 colors" low-color) ;; 13x14
		 (const :tag "medium, ~10 colors" medium) ;; 16x16
		 (const :tag "dull, grayscale" grayscale));; 14x14
[...])

I don't know how to check for the size in XEmacs which lacks
`face-attribute'.  It exists in Emacs 21.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Larger smilies

[Lars Magne Ingebrigtsen]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> For my font size (14) the medium (16x16 pixel) smilies are too large
> (causing increased "linespread").  Maybe the default should depend on
> the face height?

Yes, that makes sense.

> I don't know how to check for the size in XEmacs which lacks
> `face-attribute'.  It exists in Emacs 21.

I was going to download the newest XEmacs now to get the canonical
answer (I only have the Debian installed here), but xemacs.org seems
to be down.  *sigh*

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Larger smilies

[Lars Magne Ingebrigtsen]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> I don't know how to check for the size in XEmacs which lacks
> `face-attribute'.  It exists in Emacs 21.

`face-height'.  I'll install the changes.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen