From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61485 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: message.el dependency in mm-uu.el Date: Sat, 10 Dec 2005 11:12:42 +0100 Message-ID: References: <87slt2jcu2.fsf@pacem.orebokech.com> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1134210506 18646 80.91.229.2 (10 Dec 2005 10:28:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Dec 2005 10:28:26 +0000 (UTC) Cc: Original-X-From: ding-owner+m10017@lists.math.uh.edu Sat Dec 10 11:28:16 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1El1wO-0005ZT-6V for ding-account@gmane.org; Sat, 10 Dec 2005 11:26:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1El1wF-0003ZY-00; Sat, 10 Dec 2005 04:26:47 -0600 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1El1qI-0003ZQ-00 for ding@lists.math.uh.edu; Sat, 10 Dec 2005 04:20:38 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1El1qC-0004OR-16 for ding@lists.math.uh.edu; Sat, 10 Dec 2005 04:20:38 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.1]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1El1qA-0005eo-00 for ; Sat, 10 Dec 2005 11:20:30 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.4/8.13.4) with ESMTP id jBAAKRlJ028885; Sat, 10 Dec 2005 11:20:29 +0100 (MET) Original-Received: from me (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by bridgekeeper.physik.uni-ulm.de (Postfix) with SMTP id 6807810DBB; Sat, 10 Dec 2005 11:20:25 +0100 (CET) Original-Received: (nullmailer pid 7986 invoked by uid 170); Sat, 10 Dec 2005 10:12:43 -0000 Original-To: Romain Francoise Mail-Followup-To: X-Face: mtjf/D:es1T0wHO:&CJ'ZXe"l;3C--rw\z!{`eFwL){|]RpI+4{u25L=5C /0>KuGeTsk<~<&NE-AKV1560e!+RJeyWmSskkrJm?[vUV#66{T_m|Ae<||Ku#Mk5`y&O`n~z2;n8eP J5#2h@2eQgV@E70IY_0WlEx!"&giy{+\%h1LJox$zv@/l%ZmU4^tZA>xQpnkUBVC5.jpg#0'(+2?Rs )NAr:>3<=WxHE$ktbLysDIM5TbmHu*3 (Reiner Steib's message of "Sat, 10 Dec 2005 00:16:45 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-DCC--Metrics: gemini 1074; Body=2 Fuz1=2 Fuz2=2 X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61485 Archived-At: [ Cc-ing ding ] On Sat, Dec 10 2005, Reiner Steib wrote: > On Fri, Dec 09 2005, Romain Francoise wrote: > >>> + (message-marks >>> + ,(concat "^" (regexp-quote message-mark-insert-begin)) >>> + ,(concat "^" (regexp-quote message-mark-insert-end)) >>> + (lambda () (mm-uu-verbatim-marks-extract 0 -1 1 -2)) >> >> This causes a problem with MH-E, which uses mm-uu.el for one of its >> functions, but doesn't load message.el first. See the following Debian >> bug: >> >> >> >> A possible solution would be to make mm-uu.el require message.el. >> I'm not too comfortable with that because the dependency is needed for a >> very small part of mm-uu and could probably be avoided. What do you >> think? > > Thanks for pointing this out. > > MML (mml*.el and mm-*.el) is supposed to be independent from Gnus. > Most probably also independent from message.el (which should in turn > be independent from Gnus). > > I'm trying to document the dependencies in `texi/gnus-coding.texi'. > Any help with improving this document and remove existing dependencies > would be very welcome. > > The most simple solution would be to hard-code the values of > message-mark-insert-begin/end (and add a comment to both places > referring to each other). Or do you have a better solution in mind? > > --- message.el 27 Nov 2005 18:15:17 +0100 7.112 > +++ message.el 10 Dec 2005 00:12:25 +0100 > @@ -335,6 +335,9 @@ > > ;;; marking inserted text > > +;; If `message-mark-insert-begin' or `message-mark-insert-end' are changed, we > +;; should also change the `message-marks' element of `mm-uu-type-alist' in > +;; `mm-uu.el'. > (defcustom message-mark-insert-begin > "--8<---------------cut here---------------start------------->8---\n" > "How to mark the beginning of some inserted text." > > --- mm-uu.el 06 Dec 2005 15:47:44 +0100 7.20 > +++ mm-uu.el 10 Dec 2005 00:10:39 +0100 > @@ -165,8 +165,16 @@ > nil > mm-uu-diff-test) > (message-marks > - ,(concat "^" (regexp-quote message-mark-insert-begin)) > - ,(concat "^" (regexp-quote message-mark-insert-end)) > + ;; Don't use `message-mark-insert-begin' and `message-mark-insert-end' > + ;; here to avoid dependency on `message.el'. > + ,(concat > + "^" > + (regexp-quote > + "--8<---------------cut here---------------start------------->8---\n")) > + ,(concat > + "^" > + (regexp-quote > + "--8<---------------cut here---------------end--------------->8---\n")) > (lambda () (mm-uu-verbatim-marks-extract 0 -1 1 -2)) > nil) > ;; Omitting [a-z8<] leads to false positives (bogus signature separators Maybe the following mm-uu.el patch would be better: #v+ --- mm-uu.el 06 Dec 2005 15:47:44 +0100 7.20 +++ mm-uu.el 10 Dec 2005 10:38:29 +0100 @@ -165,8 +165,10 @@ nil mm-uu-diff-test) (message-marks - ,(concat "^" (regexp-quote message-mark-insert-begin)) - ,(concat "^" (regexp-quote message-mark-insert-end)) + ;; Don't use `message-mark-insert-begin' and `message-mark-insert-end' + ;; here to avoid dependency on `message.el'. + "^-\\{2,\\}[8<>]*-\\{9,\\}[a-z ]+-\\{9,\\}[a-z ]+-\\{9,\\}[8<>]*-\\{2,\\}$" + "^-\\{2,\\}[8<>]*-\\{9,\\}[a-z ]+-\\{9,\\}[a-z ]+-\\{9,\\}[8<>]*-\\{2,\\}$" (lambda () (mm-uu-verbatim-marks-extract 0 -1 1 -2)) nil) ;; Omitting [a-z8<] leads to false positives (bogus signature separators #v- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/