Move gnus-article-mode-line-format-alist to gnus-sum.el

Move gnus-article-mode-line-format-alist to gnus-sum.el

[Glenn Morris]

[please cc me in any replies; I'm not subscribed]


Any objection to my moving the definition of
gnus-article-mode-line-format-alist from gnus-art to gnu-sum? This
simplifies the compilation of gnus-sum, since it no longer has to load
its own uncompiled source file part way through.

Patch against Emacs CVS trunk versions:


*** gnus-art.el	29 Feb 2008 04:03:49 -0000	1.155
--- gnus-art.el	4 Mar 2008 03:55:14 -0000
***************
*** 1700,1710 ****
  
  (defvar gnus-save-article-buffer nil)
  
- (defvar gnus-article-mode-line-format-alist
-   (nconc '((?w (gnus-article-wash-status) ?s)
- 	   (?m (gnus-article-mime-part-status) ?s))
- 	 gnus-summary-mode-line-format-alist))
- 
  (defvar gnus-number-of-articles-to-be-saved nil)
  
  (defvar gnus-inhibit-hiding nil)
--- 1700,1705 ----



*** gnus-sum.el	4 Mar 2008 03:52:10 -0000	1.120
--- gnus-sum.el	4 Mar 2008 03:53:28 -0000
***************
*** 1372,1377 ****
--- 1372,1383 ----
      (?E gnus-newsgroup-expunged-tally ?d)
      (?s (gnus-current-score-file-nondirectory) ?s)))
  
+ ;; This is here rather than in gnus-art for compilation reasons.
+ (defvar gnus-article-mode-line-format-alist
+   (nconc '((?w (gnus-article-wash-status) ?s)
+ 	   (?m (gnus-article-mime-part-status) ?s))
+ 	 gnus-summary-mode-line-format-alist))
+ 
  (defvar gnus-last-search-regexp nil
    "Default regexp for article search command.")
  
***************
*** 1563,1583 ****
  	 \"^From:\\\\|^Newsgroups:\\\\|^Subject:\\\\|^Date:\\\\|^To:\")))
  ")
  
- ;; Byte-compiler warning.  Specifically, this is responsible for:
- ;; "Warning: the following functions might not be defined at runtime:
- ;; gnus-build-sparse-threads, gnus-dead-summary-mode, gnus-summary-mark-below".
  (eval-when-compile
    ;; Bind features so that require will believe that gnus-sum has
    ;; already been loaded (avoids infinite recursion)
    (let ((features (cons 'gnus-sum features)))
-     ;; Several of the declarations in gnus-sum are needed to load the
-     ;; following files. Right now, these definitions have been
-     ;; compiled but not defined (evaluated).  We could either do a
-     ;; eval-and-compile about all of the declarations or evaluate the
-     ;; source file.
-     (if (boundp 'gnus-newsgroup-variables)
-         nil
-       (load "gnus-sum.el" t t t))
      (require 'gnus-art)))
  
  ;; MIME stuff.
--- 1569,1578 ----

Re: Move gnus-article-mode-line-format-alist to gnus-sum.el

[Reiner Steib]

On Tue, Mar 04 2008, Glenn Morris wrote:

> [please cc me in any replies; I'm not subscribed]
>
> Any objection to my moving the definition of
> gnus-article-mode-line-format-alist from gnus-art to gnu-sum? 

Fine with me.

> This simplifies the compilation of gnus-sum, since it no longer has
> to load its own uncompiled source file part way through.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/