Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Eli Zaretskii <eliz@gnu.org>
Cc: David Z Maze <dmaze@MIT.EDU>, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: smtpmail.el: set-buffer-file-coding-system takes too many args
Date: Sat, 24 Mar 2007 13:30:56 +0100	[thread overview]
Message-ID: <v9hcsaescf.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <v9lkkfavhl.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Sun\, 07 Jan 2007 13\:09\:58 +0100")

Eli,

could comment on this (your 2006-11-24 change to smtpmail.el), please?

Bye, Reiner.


Original message follows...

On Sun, Jan 07 2007, Reiner Steib wrote:

> On Sun, Jan 07 2007, Simon Josefsson wrote:
>
>> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>>> BTW: Is NOMODIFY really useful here?  In both cases,
>>> `set-buffer-file-coding-system' is followed by
>>> `insert-buffer-substring' which will mark the buffer modified anyhow.
>>> What am I missing?
>>
>> Hm, I agree that it looks funny.  Maybe you could ask whomever applied
>> this, if it is really needed?  I agree that it doesn't seem very
>> useful, and the modified-flag seems rather pointless for temporary
>> buffers anyway.
>
> Eli, we wonder if the NOMODIFY argument to
> `set-buffer-file-coding-system' in your 2006-11-24 change of
> `smtpmail.el' (see below) is useful.  NOMODIFY breaks compatibility
> with Emacs 21.  Although it's not a goal for `smtpmail.el' in Emacs
> CVS to be compatible with Emacs 21, it would be "nice-to-have" because
> `smtpmail.el' provides very useful features for Gnus user on Emacs 21
> (SMTP-AUTH, STARTTLS, ...).  This was the reason why we include a copy
> of `smtpmail.el' from Emacs in Gnus' contrib directory.
>
> (See
> http://thread.gmane.org/gmane.emacs.gnus.general/64222/focus=64233 for
> the rest of this thread.)
>
> ,----
> | 2006-11-24  Eli Zaretskii  <eliz@gnu.org>
> | 
> | 	* mail/smtpmail.el (smtpmail-send-it):
> | 	Copy buffer-file-coding-system from the mail buffer.  Possibly add a
> | 	MIME header for the message encoding.
> | 	Bind coding-system-for-write around the call to mail-do-fcc.
> | 	Use smtpmail-code-conv-from to encode queued mail messages.
> `----
>
> --- smtpmail.el	18 Oct 2006 11:11:32 -0000	1.88
> +++ smtpmail.el	24 Nov 2006 14:32:19 -0000	1.89
> @@ -244,6 +244,11 @@
>  	(save-excursion
>  	  (set-buffer tembuf)
>  	  (erase-buffer)
> +	  ;; Use the same buffer-file-coding-system as in the mail
> +	  ;; buffer, otherwise any write-region invocations (e.g., in
> +	  ;; mail-do-fcc below) will annoy with asking for a suitable
> +	  ;; encoding.
> +	  (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
>  	  (insert-buffer-substring mailbuf)
>  	  (goto-char (point-max))
>  	  ;; require one newline at the end.
>
> [...]
> @@ -370,6 +394,7 @@
>  		(make-directory smtpmail-queue-dir t))
>  	      (with-current-buffer buffer-data
>  		(erase-buffer)
> +		(set-buffer-file-coding-system smtpmail-code-conv-from nil t)
>  		(insert-buffer-substring tembuf)
>  		(write-file file-data)
>  		(set-buffer buffer-elisp)

  reply	other threads:[~2007-03-24 12:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-03 15:30 David Z Maze
2007-01-06 14:50 ` Reiner Steib
2007-01-06 17:59   ` Simon Josefsson
2007-01-06 20:11     ` Reiner Steib
2007-01-07 10:12       ` Simon Josefsson
2007-01-07 12:07         ` Reiner Steib
2007-01-08  8:54           ` Simon Josefsson
2007-01-07 12:09         ` Reiner Steib
2007-03-24 12:30           ` Reiner Steib [this message]
2007-03-24 17:07             ` Eli Zaretskii
2007-03-24 19:18               ` Reiner Steib
2007-03-25  2:14                 ` Miles Bader
2007-03-31 21:18                   ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9hcsaescf.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    --cc=ding@gnus.org \
    --cc=dmaze@MIT.EDU \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).