From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64436 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: smtpmail.el: set-buffer-file-coding-system takes too many args Date: Sat, 24 Mar 2007 13:30:56 +0100 Message-ID: References: <87d55svxxu.fsf@latte.josefsson.org> <87irfjf8m9.fsf@latte.josefsson.org> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174739526 17153 80.91.229.12 (24 Mar 2007 12:32:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2007 12:32:06 +0000 (UTC) Cc: David Z Maze , ding@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 24 13:32:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HV5Pa-0001PD-BO for ged-emacs-devel@m.gmane.org; Sat, 24 Mar 2007 13:31:58 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HV5Rb-0001yK-1z for ged-emacs-devel@m.gmane.org; Sat, 24 Mar 2007 07:34:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HV5RX-0001xu-JB for emacs-devel@gnu.org; Sat, 24 Mar 2007 08:33:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HV5RX-0001xa-1e for emacs-devel@gnu.org; Sat, 24 Mar 2007 08:33:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HV5RW-0001xX-PS for emacs-devel@gnu.org; Sat, 24 Mar 2007 07:33:58 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HV5PU-0007q6-1c; Sat, 24 Mar 2007 08:31:52 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.8/8.13.8) with ESMTP id l2OCVlYS029475; Sat, 24 Mar 2007 13:31:48 +0100 (MET) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 701741295C; Sat, 24 Mar 2007 13:31:47 +0100 (CET) X-Face: /U7=m^"/-Dn61mAl{g9e3>\G5Tp,oEX|V)g2I1hBk\ML; )7A?6cmB-y7y?'NA^J<=oz7syB =(McAwIHgLX!.B?R3X}98d@?>CrT094KLWh]WU4gDpnL/")MS(XoQTv`Oq225uL>+; CpPXo$N5e>N> $tPd-gbB^F{gQS#1ase]XO~D4p4M"3+F-7~u]dy3I?Pb8RO*H-EFeWDUf?Rf, d]pv\Jvh2Cht!A=im yKAS2Z%Ao^;}W/qzMvMm Mail-Followup-To: Eli Zaretskii , ding@gnus.org, David Z Maze , In-Reply-To: (Reiner Steib's message of "Sun\, 07 Jan 2007 13\:09\:58 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) X-DCC--Metrics: arktur 104; Body=4 Fuz1=4 Fuz2=4 X-detected-kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68467 gmane.emacs.gnus.general:64436 Archived-At: Eli, could comment on this (your 2006-11-24 change to smtpmail.el), please? Bye, Reiner. Original message follows... On Sun, Jan 07 2007, Reiner Steib wrote: > On Sun, Jan 07 2007, Simon Josefsson wrote: > >> Reiner Steib writes: >>> BTW: Is NOMODIFY really useful here? In both cases, >>> `set-buffer-file-coding-system' is followed by >>> `insert-buffer-substring' which will mark the buffer modified anyhow. >>> What am I missing? >> >> Hm, I agree that it looks funny. Maybe you could ask whomever applied >> this, if it is really needed? I agree that it doesn't seem very >> useful, and the modified-flag seems rather pointless for temporary >> buffers anyway. > > Eli, we wonder if the NOMODIFY argument to > `set-buffer-file-coding-system' in your 2006-11-24 change of > `smtpmail.el' (see below) is useful. NOMODIFY breaks compatibility > with Emacs 21. Although it's not a goal for `smtpmail.el' in Emacs > CVS to be compatible with Emacs 21, it would be "nice-to-have" because > `smtpmail.el' provides very useful features for Gnus user on Emacs 21 > (SMTP-AUTH, STARTTLS, ...). This was the reason why we include a copy > of `smtpmail.el' from Emacs in Gnus' contrib directory. > > (See > http://thread.gmane.org/gmane.emacs.gnus.general/64222/focus=64233 for > the rest of this thread.) > > ,---- > | 2006-11-24 Eli Zaretskii > | > | * mail/smtpmail.el (smtpmail-send-it): > | Copy buffer-file-coding-system from the mail buffer. Possibly add a > | MIME header for the message encoding. > | Bind coding-system-for-write around the call to mail-do-fcc. > | Use smtpmail-code-conv-from to encode queued mail messages. > `---- > > --- smtpmail.el 18 Oct 2006 11:11:32 -0000 1.88 > +++ smtpmail.el 24 Nov 2006 14:32:19 -0000 1.89 > @@ -244,6 +244,11 @@ > (save-excursion > (set-buffer tembuf) > (erase-buffer) > + ;; Use the same buffer-file-coding-system as in the mail > + ;; buffer, otherwise any write-region invocations (e.g., in > + ;; mail-do-fcc below) will annoy with asking for a suitable > + ;; encoding. > + (set-buffer-file-coding-system smtpmail-code-conv-from nil t) > (insert-buffer-substring mailbuf) > (goto-char (point-max)) > ;; require one newline at the end. > > [...] > @@ -370,6 +394,7 @@ > (make-directory smtpmail-queue-dir t)) > (with-current-buffer buffer-data > (erase-buffer) > + (set-buffer-file-coding-system smtpmail-code-conv-from nil t) > (insert-buffer-substring tembuf) > (write-file file-data) > (set-buffer buffer-elisp)