Gnus development mailing list
 help / color / mirror / Atom feed
From: Reiner Steib <reinersteib+gmane@imap.cc>
Subject: Re: gnus-button-alist: Don't treat " as part MID
Date: Thu, 04 Aug 2005 14:38:29 +0200	[thread overview]
Message-ID: <v9hde5swqi.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <b4md5outs0r.fsf@jpl.org>

On Thu, Aug 04 2005, Katsumi Yamaoka wrote:

>>>>>> In <v9hde8dxx2.fsf@marauder.physik.uni-ulm.de> Reiner Steib wrote:
[...]
>> (d) "news:b4m64uo7ij8.fsf@jpl.org"
[...]
>> AFAICS, `"' can't be part of the domain part, so I suggest apply one
>> of the following patches.
[...]
>> (2) The domain part can only contain alphanumeric characters, `.' and
>>     `-'.  ==> @[a-z0-9.-]+
>
>> I'd prefer (2), but maybe I'm missing something.  Opinions?
>
> I think (2) is also good since it aims to narrow to use for
> nntp\|news which should contain only MIDs.  Though I don't care
> which you use, it will have to be fixed anyway.

I applied (2) plus a modification for the localpart
(gnus-button-valid-localpart-regexp) in v5-10 and the trunk.

Maybe `gnus-button-valid-localpart-regexp' and/or @[a-z0-9.-]+[a-z]
should be used for other buttons as well.  Maybe someone else wants to
check the other MID/mail related buttons.

(I don't have time to test false positives/negatives now and I won't
have reasonable CVS access for the next weeks.  In case my change
breaks something, feel free to revert or fix.)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




      reply	other threads:[~2005-08-04 12:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-02 17:57 Reiner Steib
2005-08-04  1:22 ` Katsumi Yamaoka
2005-08-04 12:38   ` Reiner Steib [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=v9hde5swqi.fsf@marauder.physik.uni-ulm.de \
    --to=reinersteib+gmane@imap.cc \
    --cc=Reiner.Steib@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).